Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[LANG-734] The CHAR_ARRAY cache in CharUtils duplicates the cache in java.lang.Character. 

[LANG-735] Deprecate CharUtils.toCharacterObject(char) in favor of java.lang.Character.valueOf(char).

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1153229 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Gary D. Gregory 2011-08-02 18:04:51 +00:00
parent 9c28c3538d
commit ad5b9b0149
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/org/apache/commons/lang3/CharUtils.java
View File

@ -48,7 +48,6 @@ public class CharUtils {
"\u0078\u0079\u007a\u007b\u007c\u007d\u007e\u007f";
private static final String[] CHAR_STRING_ARRAY = new String[128];
private static final Character[] CHAR_ARRAY = new Character[128];
/**
* {@code \u000a} linefeed LF ('\n').
@ -72,7 +71,6 @@ public class CharUtils {
static {
for (int i = 127; i >= 0; i--) {
CHAR_STRING_ARRAY[i] = CHAR_STRING.substring(i, i + 1);
CHAR_ARRAY[i] = new Character((char) i);
}
}
@ -99,14 +97,13 @@ public CharUtils() {
* CharUtils.toCharacterObject('A') = 'A'
* </pre>
*
* @deprecated Java 5 introduced {@link Character#valueOf(char)} which caches chars 0 through 127.
* @param ch the character to convert
* @return a Character of the specified character
*/
@Deprecated
public static Character toCharacterObject(char ch) {
if (ch < CHAR_ARRAY.length) {
return CHAR_ARRAY[ch];
}
return new Character(ch);
return Character.valueOf(ch);
}
/**
@ -130,7 +127,7 @@ public static Character toCharacterObject(String str) {
if (StringUtils.isEmpty(str)) {
return null;
}
return toCharacterObject(str.charAt(0));
return Character.valueOf(str.charAt(0));
}
//-----------------------------------------------------------------------

2
src/site/changes/changes.xml
View File

@ -33,6 +33,8 @@
<action type="add" issue="LANG-723">Add mode and median Comparable... methods to ObjectUtils</action>
<action type="add" issue="LANG-722">Add BooleanUtils.and + or varargs methods</action>
<action type="add" issue="LANG-730">EnumSet -&gt; bit vector</action>
<action type="fix" issue="LANG-734">The CHAR_ARRAY cache in CharUtils duplicates the cache in java.lang.Character</action>
<action type="update" issue="LANG-735">Deprecate CharUtils.toCharacterObject(char) in favor of java.lang.Character.valueOf(char)</action>
</release>
<release version="3.0" date="2011-07-18" description="Backwards incompatible update of Commons Lang to Java 5">