Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CharUtilsTest#testIsAscii_char loop 

The loop currently loops only up to 128, thus testing just positive
return values of CharUtils#isAscii(char). This patch increase the loop
to go over all the possible values of an unsigned byte, thus testing
also negative return values.
This commit is contained in:
Allon Mureinik 2017-09-30 15:27:42 +03:00 committed by pascalschumacher
parent c7554151d3
commit ae862ae116
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/java/org/apache/commons/lang3/CharUtilsTest.java
View File

@ -219,7 +219,7 @@ public void testIsAscii_char() {
assertTrue(CharUtils.isAscii('\n')); assertTrue(CharUtils.isAscii('\n'));
assertFalse(CharUtils.isAscii(CHAR_COPY)); assertFalse(CharUtils.isAscii(CHAR_COPY));
for (int i = 0; i < 128; i++) { for (int i = 0; i < 255; i++) {
assertEquals(i < 128, CharUtils.isAscii((char) i)); assertEquals(i < 128, CharUtils.isAscii((char) i));
} }
} }