Apache/commons-lang
1
0
Fork 0
mirror of https://github.com/apache/commons-lang.git synced 2025-03-02 22:19:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor magic string into an private constant

Browse Source
This commit is contained in:
Gary Gregory 2024-04-24 19:13:43 -04:00
parent dfe80aaca3
commit bd6a8c4227
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/org/apache/commons/lang3/SystemUtils.java
View File

@ -34,6 +34,11 @@
*/
public class SystemUtils {
/**
* The regex to split version strings.
*/
private static final String VERSION_SPLIT_REGEX = "\\.";
/**
* The prefix String for all Windows OS.
*/
@ -2148,8 +2153,8 @@ static boolean isOsVersionMatch(final String osVersion, final String osVersionPr
}
// Compare parts of the version string instead of using String.startsWith(String) because otherwise
// osVersionPrefix 10.1 would also match osVersion 10.10
final String[] versionPrefixParts = osVersionPrefix.split("\\.");
final String[] versionParts = osVersion.split("\\.");
final String[] versionPrefixParts = osVersionPrefix.split(VERSION_SPLIT_REGEX);
final String[] versionParts = osVersion.split(VERSION_SPLIT_REGEX);
for (int i = 0; i < Math.min(versionPrefixParts.length, versionParts.length); i++) {
if (!versionPrefixParts[i].equals(versionParts[i])) {
return false;