Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Upgrade maven-checkstyle-plugin to 2.17 

This patch upgrades maven-checkstyle-plugin to the latest available
version, 2.17.

This is done in order to consume a fix for checkstyle wrongfully
reporting an error if the @return javadoc tag was used in an
annotation type, as it is in Guarded (line 36).

Note that checkstyle has removed the RedundantThrows check (see
discussion at https://github.com/checkstyle/checkstyle/issues/473),
so it was removed from the project's checkstyle.xml configuration.
This commit is contained in:
Allon Mureinik 2017-03-11 10:13:44 +02:00 committed by pascalschumacher
parent 4259a706ab
commit c121f03d5c
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
checkstyle.xml
View File

@ -36,9 +36,6 @@ limitations under the License.
<module name="RedundantImport"/> <module name="RedundantImport"/>
<module name="UnusedImports"/> <module name="UnusedImports"/>
<module name="NeedBraces"/> <module name="NeedBraces"/>
<module name="RedundantThrows">
<property name="allowUnchecked" value="true"/>
</module>
<module name="JavadocMethod"> <module name="JavadocMethod">
<property name="allowUndeclaredRTE" value="true"/> <property name="allowUndeclaredRTE" value="true"/>
<property name="scope" value="public" /> <property name="scope" value="public" />

2
pom.xml
View File

@ -654,7 +654,7 @@
<plugins> <plugins>
<plugin> <plugin>
<artifactId>maven-checkstyle-plugin</artifactId> <artifactId>maven-checkstyle-plugin</artifactId>
<version>2.15</version> <version>2.17</version>
<configuration> <configuration>
<configLocation>${basedir}/checkstyle.xml</configLocation> <configLocation>${basedir}/checkstyle.xml</configLocation>
<enableRulesSummary>false</enableRulesSummary> <enableRulesSummary>false</enableRulesSummary>