From cbc1dc8c5a01beb9385f5062bf3babb14ae15ef7 Mon Sep 17 00:00:00 2001
From: Henri Yandell <bayard@apache.org>
Date: Sat, 16 May 2009 08:16:29 +0000
Subject: [PATCH] Hooking up findbugs exclude file and updating the exception
 cases

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775427 13f79535-47bb-0310-9956-ffa450edef68
---
 findbugs-exclude-filter.xml | 63 +++++++++++++++++++++++++++++++++----
 pom.xml                     |  1 +
 2 files changed, 58 insertions(+), 6 deletions(-)

diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
index 59427dc7f..36e8c02af 100644
--- a/findbugs-exclude-filter.xml
+++ b/findbugs-exclude-filter.xml
@@ -23,28 +23,79 @@
 -->
 <FindBugsFilter>
 
+  <!-- Reason: Optimization to use == -->
   <Match>
     <Class name="org.apache.commons.lang.BooleanUtils" />
     <Method name="toBoolean" />
     <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
   </Match>
 
+  <!-- Reason: Optimization to use == -->
   <Match>
     <Class name="org.apache.commons.lang.StringUtils" />
     <Method name="indexOfDifference"/>
     <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
   </Match>
 
+  <!-- Reason: Very much intended to do a fall through on the switch -->
   <Match>
-    <Class name="org.apache.commons.lang.BooleanUtils" />
-    <Method name="negate"/>
-    <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+    <Class name="org.apache.commons.lang.math.NumberUtils" />
+    <Method name="createNumber"/>
+    <Bug pattern="SF_SWITCH_FALLTHROUGH" />
   </Match>
 
+  <!-- Reason: Very much intended to do a fall through on the switch -->
   <Match>
-    <Class name="org.apache.commons.lang.BooleanUtils" />
-    <Method name="toBooleanObject"/>
-    <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+    <Class name="org.apache.commons.lang.time.DateUtils" />
+    <Method name="getFragment"/>
+    <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+  </Match>
+
+  <!-- Reason: hashCode is lazily loaded in Range classes -->
+  <!-- TODO: Work out why regex didn't work here -->
+  <Match>
+    <Class name="org.apache.commons.lang.math.DoubleRange" />
+    <Field name="hashCode" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.lang.math.FloatRange" />
+    <Field name="hashCode" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.lang.math.IntRange" />
+    <Field name="hashCode" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.lang.math.LongRange" />
+    <Field name="hashCode" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.lang.math.NumberRange" />
+    <Field name="hashCode" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+
+  <!-- Reason: toProperString is lazily loaded -->
+  <Match>
+    <Class name="org.apache.commons.lang.math.Fraction" />
+    <Field name="toProperString" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+
+  <!-- Reason: It does call super.clone(), but via a subsequent method -->
+  <Match>
+    <Class name="org.apache.commons.lang.text.StrTokenizer" />
+    <Method name="clone"/>
+    <Bug pattern="CN_IDIOM_NO_SUPER_CALL" />
+  </Match>
+
+  <!-- Reason: Testing shows that new Integer(...) etc is quicker than Integer.valueOf -->
+  <Match>
+    <Bug pattern="DM_NUMBER_CTOR" />
   </Match>
 
 </FindBugsFilter>
diff --git a/pom.xml b/pom.xml
index 025ab4db2..3a8445882 100644
--- a/pom.xml
+++ b/pom.xml
@@ -461,6 +461,7 @@
         <configuration>
           <threshold>Normal</threshold>
           <effort>Default</effort>
+          <excludeFilterFile>findbugs-exclude-filter.xml</excludeFilterFile>
        </configuration>
       </plugin>
       <plugin>