Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LANG-992 Fix NumberUtils#isNumber() returns false for "0.0", "0.4790", et al 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1582585 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Niall Pemberton 2014-03-28 03:10:27 +00:00
parent 708da45999
commit cf03e6173b
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/org/apache/commons/lang3/math/NumberUtils.java
View File

@ -1364,7 +1364,8 @@ public class NumberUtils {
}
}
return true;
} else { // leading 0, but not hex, must be octal
} else if (Character.isDigit(chars[start + 1])) {
// leading 0, but not hex, must be octal
int i = start + 1;
for (; i < chars.length; i++) {
if (chars[i] < '0' || chars[i] > '7') {

6
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
View File

@ -1234,6 +1234,12 @@ public class NumberUtilsTest {
compareIsNumberWithCreateNumber("00", true);
}
@Test
public void testLANG992() {
compareIsNumberWithCreateNumber("0.0", true);
compareIsNumberWithCreateNumber("0.4790", true);
}
@Test
public void testLANG972() {
compareIsNumberWithCreateNumber("0xABCD", true);