diff --git a/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java b/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java index 87898a367..b08d8e51c 100644 --- a/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java +++ b/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java @@ -51,20 +51,74 @@ import org.junitpioneer.jupiter.ReadsDefaultTimeZone; /* make test reproducible */ @ReadsDefaultTimeZone public class FastDateParser_TimeZoneStrategyTest extends AbstractLangTest { - private static final String[] FAILS_ON_GH_JAVA_17 = { "zh_HK", "zh_HK_#Hans", "zh_MO_#Hans", "nn", "nn_NO_#Latn", "nn_NO", "pt_AO", "pt_CV", "pt_GW", - "pt_LU", "pt_PT", "pt_TL", "es_AR", "es_BZ", "es_BR", "es_CL", "es_CO", "es_CR", "es_CU", "es_EC", "es_SV", "es_GT", "es_HN", "es_419", "es_MX", - "es_NI", "es_PA", "es_PY", "es_PE", "es_PR", "es_UY", "es_VE", "sv_SE_#Latn", "sv_SE" }; + private static final String[] POSSIBLE_FAILS_ON_GH_JAVA_17 = { + // @formatter:off + "de", + "de_AT", + "de_BE", + "de_CH", + "de_DE", + "de_DE_#Latn", + "de_IT", + "de_LI", + "de_LU", + "es", + "es_419", + "es_AR", + "es_BO", + "es_BR", + "es_BZ", + "es_CL", + "es_CO", + "es_CR", + "es_CU", + "es_DO", + "es_EA", + "es_EC", + "es_ES", + "es_ES_#Latn", + "es_GQ", + "es_GT", + "es_HN", + "es_IC", + "es_MX", + "es_NI", + "es_PA", + "es_PE", + "es_PH", + "es_PR", + "es_PY", + "es_SV", + "es_US", + "es_UY", + "es_VE", + "nn", + "nn_NO", + "nn_NO_#Latn", + "pt_AO", + "pt_CV", + "pt_GW", + "pt_LU", + "pt_PT", + "pt_TL", + "sv_SE", + "sv_SE_#Latn", + "zh_HK", + "zh_HK_#Hans", + "zh_MO_#Hans" + // @formatter:on + }; private static final List Java17Failures = new ArrayList<>(); static { - Arrays.sort(FAILS_ON_GH_JAVA_17); + Arrays.sort(POSSIBLE_FAILS_ON_GH_JAVA_17); } @AfterAll public static void afterAll() { if (!Java17Failures.isEmpty()) { - System.err.printf("Expected failures on Java 17: %,d%n%s%n", FAILS_ON_GH_JAVA_17.length, Arrays.toString(FAILS_ON_GH_JAVA_17)); + System.err.printf("Expected failures on Java 17: %,d%n%s%n", POSSIBLE_FAILS_ON_GH_JAVA_17.length, Arrays.toString(POSSIBLE_FAILS_ON_GH_JAVA_17)); System.err.printf("Actual failures on Java 17: %,d%n%s%n", Java17Failures.size(), Java17Failures); } } @@ -123,7 +177,7 @@ public class FastDateParser_TimeZoneStrategyTest extends AbstractLangTest { } catch (ParseException e) { // How do I know I'm on GH? final String localeStr = locale.toString(); - if (SystemUtils.IS_JAVA_17 && Arrays.binarySearch(FAILS_ON_GH_JAVA_17, localeStr) >= 0) { + if (SystemUtils.IS_JAVA_17 && Arrays.binarySearch(POSSIBLE_FAILS_ON_GH_JAVA_17, localeStr) >= 0) { Java17Failures.add(locale); // Mark as an assumption failure instead of a hard fail System.err.printf("Java 17 - Mark as an assumption failure instead of a hard fail: locale = '%s'%n", localeStr);