From e29f33c36677fa77d2ab66f412988875ef6edfa5 Mon Sep 17 00:00:00 2001 From: Benedikt Ritter Date: Sat, 28 Mar 2015 15:05:04 +0000 Subject: [PATCH] FindBugs: Load of known null value. At this point if lhs is null, rhs will can not be null. So evaluating the line with lhs == null will result in rhs.equals(null) which should always be false. git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1669782 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java b/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java index bf3461941..e4f4ed0fa 100644 --- a/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java +++ b/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java @@ -882,7 +882,7 @@ public DiffBuilder append(final String fieldName, final Object lhs, } // Not array type - if (lhs != null ? lhs.equals(rhs) : rhs.equals(lhs)) { + if (lhs != null && lhs.equals(rhs)) { return this; }