Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify using ternary expressions instead of nested if-elses. 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1606071 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Gary D. Gregory 2014-06-27 12:47:09 +00:00
parent 082eb39c9f
commit e769c18954
1 changed files with 15 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
src/main/java/org/apache/commons/lang3/Conversion.java
View File

@ -466,64 +466,25 @@ public class Conversion {
if (src[srcPos]) {
if (src.length > srcPos + 1 && src[srcPos + 1]) {
if (src.length > srcPos + 2 && src[srcPos + 2]) {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return 'f';
} else {
return 'e';
}
} else {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return 'd';
} else {
return 'c';
}
}
} else {
if (src.length > srcPos + 2 && src[srcPos + 2]) {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return 'b';
} else {
return 'a';
}
} else {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return '9';
} else {
return '8';
}
return src.length > srcPos + 3 && src[srcPos + 3] ? 'f' : 'e';
}
return src.length > srcPos + 3 && src[srcPos + 3] ? 'd' : 'c';
}
} else {
if (src.length > srcPos + 1 && src[srcPos + 1]) {
if (src.length > srcPos + 2 && src[srcPos + 2]) {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return '7';
} else {
return '6';
}
} else {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return '5';
} else {
return '4';
}
}
} else {
if (src.length > srcPos + 2 && src[srcPos + 2]) {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return '3';
} else {
return '2';
}
} else {
if (src.length > srcPos + 3 && src[srcPos + 3]) {
return '1';
} else {
return '0';
}
}
if (src.length > srcPos + 2 && src[srcPos + 2]) {
return src.length > srcPos + 3 && src[srcPos + 3] ? 'b' : 'a';
}
return src.length > srcPos + 3 && src[srcPos + 3] ? '9' : '8';
}
if (src.length > srcPos + 1 && src[srcPos + 1]) {
if (src.length > srcPos + 2 && src[srcPos + 2]) {
return src.length > srcPos + 3 && src[srcPos + 3] ? '7' : '6';
}
return src.length > srcPos + 3 && src[srcPos + 3] ? '5' : '4';
}
if (src.length > srcPos + 2 && src[srcPos + 2]) {
return src.length > srcPos + 3 && src[srcPos + 3] ? '3' : '2';
}
return src.length > srcPos + 3 && src[srcPos + 3] ? '1' : '0';
}
/**