diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 204e3a5dc..757411826 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -32,4 +32,4 @@ jobs: with: java-version: ${{ matrix.java }} - name: Build with Maven - run: mvn -V apache-rat:check javadoc:javadoc -Ddoclint=all package --file pom.xml + run: mvn -V apache-rat:check spotbugs:check javadoc:javadoc -Ddoclint=all package --file pom.xml diff --git a/.travis.yml b/.travis.yml index 09ef4cfd1..b651149f2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -32,4 +32,4 @@ script: - mvn after_success: - - mvn clean test jacoco:report coveralls:report -Ptravis-jacoco javadoc:javadoc -Ddoclint=all + - mvn clean test spotbugs:check jacoco:report coveralls:report -Ptravis-jacoco javadoc:javadoc -Ddoclint=all diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index a2402b18d..793754775 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -6363,9 +6363,7 @@ public class StringUtils { if (isEmpty(text) || isEmpty(searchString) || replacement == null || max == 0) { return text; } - String searchText = text; if (ignoreCase) { - searchText = text.toLowerCase(); searchString = searchString.toLowerCase(); } int start = 0;