Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LANG-1395 - JsonToStringStyle does not escape double quote in a string 

value
This commit is contained in:
Sebb 2018-05-09 18:28:19 +01:00
parent 362dd935f8
commit e7d16c2762
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/changes/changes.xml
View File

@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
<body> <body>
<release version="3.8" date="2018-MM-DD" description="New features and bug fixes. Requires Java 7, supports Java 8, 9, 10."> <release version="3.8" date="2018-MM-DD" description="New features and bug fixes. Requires Java 7, supports Java 8, 9, 10.">
<action issue="LANG-1395" type="fix" dev="sebb" due=to="Jim Gan">JsonToStringStyle does not escape double quote in a string value</action>
<action issue="LANG-1384" type="fix" dev="erans" due-to="Ian Young">New Java version ("11") must be handled</action> <action issue="LANG-1384" type="fix" dev="erans" due-to="Ian Young">New Java version ("11") must be handled</action>
<action issue="LANG-1364" type="fix" dev="pschumacher" due-to="Zheng Xie">ExceptionUtils#getRootCause(Throwable t) should return t if no lower level cause exists</action> <action issue="LANG-1364" type="fix" dev="pschumacher" due-to="Zheng Xie">ExceptionUtils#getRootCause(Throwable t) should return t if no lower level cause exists</action>
<action issue="LANG-1060" type="fix" dev="pschumacher" due-to="Piotr Kosmala">NumberUtils.isNumber assumes number starting with Zero</action> <action issue="LANG-1060" type="fix" dev="pschumacher" due-to="Piotr Kosmala">NumberUtils.isNumber assumes number starting with Zero</action>

4
src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
View File

@ -24,6 +24,7 @@ import java.util.WeakHashMap;
import org.apache.commons.lang3.ClassUtils; import org.apache.commons.lang3.ClassUtils;
import org.apache.commons.lang3.ObjectUtils; import org.apache.commons.lang3.ObjectUtils;
import org.apache.commons.lang3.StringEscapeUtils;
import org.apache.commons.lang3.StringUtils; import org.apache.commons.lang3.StringUtils;
/** /**
@ -62,6 +63,7 @@ import org.apache.commons.lang3.StringUtils;
* *
* @since 1.0 * @since 1.0
*/ */
@SuppressWarnings("deprecation") // StringEscapeUtils
public abstract class ToStringStyle implements Serializable { public abstract class ToStringStyle implements Serializable {
/** /**
@ -2606,7 +2608,7 @@ public abstract class ToStringStyle implements Serializable {
* @param value the value to append. * @param value the value to append.
*/ */
private void appendValueAsString(final StringBuffer buffer, final String value) { private void appendValueAsString(final StringBuffer buffer, final String value) {
buffer.append('"').append(value).append('"'); buffer.append('"').append(StringEscapeUtils.escapeJson(value)).append('"');
} }
@Override @Override

9
src/test/java/org/apache/commons/lang3/builder/JsonToStringStyleTest.java
View File

@ -378,6 +378,15 @@ public class JsonToStringStyleTest {
.toString()); .toString());
} }
@Test
public void testLANG1395() {
assertEquals("{\"name\":\"value\"}",new ToStringBuilder(base).append("name","value").toString());
assertEquals("{\"name\":\"\"}",new ToStringBuilder(base).append("name","").toString());
assertEquals("{\"name\":\"\\\"\"}",new ToStringBuilder(base).append("name",'"').toString());
assertEquals("{\"name\":\"\\\\\"}",new ToStringBuilder(base).append("name",'\\').toString());
assertEquals("{\"name\":\"Let's \\\"quote\\\" this\"}",new ToStringBuilder(base).append("name","Let's \"quote\" this").toString());
}
/** /**
* An object with nested object structures used to test {@link ToStringStyle.JsonToStringStyle}. * An object with nested object structures used to test {@link ToStringStyle.JsonToStringStyle}.
* *