Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add TODOs 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1301150 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Matthew Jason Benson 2012-03-15 19:00:56 +00:00
parent a0de414979
commit e9d6891549
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/org/apache/commons/lang3/Validate.java
View File

@ -846,6 +846,7 @@ public static void validState(boolean expression, String message, Object... valu
* @since 3.0 * @since 3.0
*/ */
public static void matchesPattern(CharSequence input, String pattern) { public static void matchesPattern(CharSequence input, String pattern) {
// TODO when breaking BC, consider returning input
if (Pattern.matches(pattern, input) == false) { if (Pattern.matches(pattern, input) == false) {
throw new IllegalArgumentException(String.format(DEFAULT_MATCHES_PATTERN_EX, input, pattern)); throw new IllegalArgumentException(String.format(DEFAULT_MATCHES_PATTERN_EX, input, pattern));
} }
@ -869,6 +870,7 @@ public static void matchesPattern(CharSequence input, String pattern) {
* @since 3.0 * @since 3.0
*/ */
public static void matchesPattern(CharSequence input, String pattern, String message, Object... values) { public static void matchesPattern(CharSequence input, String pattern, String message, Object... values) {
// TODO when breaking BC, consider returning input
if (Pattern.matches(pattern, input) == false) { if (Pattern.matches(pattern, input) == false) {
throw new IllegalArgumentException(String.format(message, values)); throw new IllegalArgumentException(String.format(message, values));
} }
@ -893,6 +895,7 @@ public static void matchesPattern(CharSequence input, String pattern, String mes
* @since 3.0 * @since 3.0
*/ */
public static <T> void inclusiveBetween(T start, T end, Comparable<T> value) { public static <T> void inclusiveBetween(T start, T end, Comparable<T> value) {
// TODO when breaking BC, consider returning value
if (value.compareTo(start) < 0 || value.compareTo(end) > 0) { if (value.compareTo(start) < 0 || value.compareTo(end) > 0) {
throw new IllegalArgumentException(String.format(DEFAULT_INCLUSIVE_BETWEEN_EX_MESSAGE, value, start, end)); throw new IllegalArgumentException(String.format(DEFAULT_INCLUSIVE_BETWEEN_EX_MESSAGE, value, start, end));
} }
@ -917,6 +920,7 @@ public static <T> void inclusiveBetween(T start, T end, Comparable<T> value) {
* @since 3.0 * @since 3.0
*/ */
public static <T> void inclusiveBetween(T start, T end, Comparable<T> value, String message, Object... values) { public static <T> void inclusiveBetween(T start, T end, Comparable<T> value, String message, Object... values) {
// TODO when breaking BC, consider returning value
if (value.compareTo(start) < 0 || value.compareTo(end) > 0) { if (value.compareTo(start) < 0 || value.compareTo(end) > 0) {
throw new IllegalArgumentException(String.format(message, values)); throw new IllegalArgumentException(String.format(message, values));
} }
@ -941,6 +945,7 @@ public static <T> void inclusiveBetween(T start, T end, Comparable<T> value, Str
* @since 3.0 * @since 3.0
*/ */
public static <T> void exclusiveBetween(T start, T end, Comparable<T> value) { public static <T> void exclusiveBetween(T start, T end, Comparable<T> value) {
// TODO when breaking BC, consider returning value
if (value.compareTo(start) <= 0 || value.compareTo(end) >= 0) { if (value.compareTo(start) <= 0 || value.compareTo(end) >= 0) {
throw new IllegalArgumentException(String.format(DEFAULT_EXCLUSIVE_BETWEEN_EX_MESSAGE, value, start, end)); throw new IllegalArgumentException(String.format(DEFAULT_EXCLUSIVE_BETWEEN_EX_MESSAGE, value, start, end));
} }
@ -965,6 +970,7 @@ public static <T> void exclusiveBetween(T start, T end, Comparable<T> value) {
* @since 3.0 * @since 3.0
*/ */
public static <T> void exclusiveBetween(T start, T end, Comparable<T> value, String message, Object... values) { public static <T> void exclusiveBetween(T start, T end, Comparable<T> value, String message, Object... values) {
// TODO when breaking BC, consider returning value
if (value.compareTo(start) <= 0 || value.compareTo(end) >= 0) { if (value.compareTo(start) <= 0 || value.compareTo(end) >= 0) {
throw new IllegalArgumentException(String.format(message, values)); throw new IllegalArgumentException(String.format(message, values));
} }
@ -990,6 +996,7 @@ public static <T> void exclusiveBetween(T start, T end, Comparable<T> value, Str
* @since 3.0 * @since 3.0
*/ */
public static void isInstanceOf(Class<?> type, Object obj) { public static void isInstanceOf(Class<?> type, Object obj) {
// TODO when breaking BC, consider returning obj
if (type.isInstance(obj) == false) { if (type.isInstance(obj) == false) {
throw new IllegalArgumentException(String.format(DEFAULT_IS_INSTANCE_OF_EX_MESSAGE, type.getName(), throw new IllegalArgumentException(String.format(DEFAULT_IS_INSTANCE_OF_EX_MESSAGE, type.getName(),
obj == null ? "null" : obj.getClass().getName())); obj == null ? "null" : obj.getClass().getName()));
@ -1014,6 +1021,7 @@ public static void isInstanceOf(Class<?> type, Object obj) {
* @since 3.0 * @since 3.0
*/ */
public static void isInstanceOf(Class<?> type, Object obj, String message, Object... values) { public static void isInstanceOf(Class<?> type, Object obj, String message, Object... values) {
// TODO when breaking BC, consider returning obj
if (type.isInstance(obj) == false) { if (type.isInstance(obj) == false) {
throw new IllegalArgumentException(String.format(message, values)); throw new IllegalArgumentException(String.format(message, values));
} }
@ -1039,6 +1047,7 @@ public static void isInstanceOf(Class<?> type, Object obj, String message, Objec
* @since 3.0 * @since 3.0
*/ */
public static void isAssignableFrom(Class<?> superType, Class<?> type) { public static void isAssignableFrom(Class<?> superType, Class<?> type) {
// TODO when breaking BC, consider returning type
if (superType.isAssignableFrom(type) == false) { if (superType.isAssignableFrom(type) == false) {
throw new IllegalArgumentException(String.format(DEFAULT_IS_ASSIGNABLE_EX_MESSAGE, type == null ? "null" : type.getName(), throw new IllegalArgumentException(String.format(DEFAULT_IS_ASSIGNABLE_EX_MESSAGE, type == null ? "null" : type.getName(),
superType.getName())); superType.getName()));
@ -1063,6 +1072,7 @@ public static void isAssignableFrom(Class<?> superType, Class<?> type) {
* @see #isAssignableFrom(Class, Class) * @see #isAssignableFrom(Class, Class)
*/ */
public static void isAssignableFrom(Class<?> superType, Class<?> type, String message, Object... values) { public static void isAssignableFrom(Class<?> superType, Class<?> type, String message, Object... values) {
// TODO when breaking BC, consider returning type
if (superType.isAssignableFrom(type) == false) { if (superType.isAssignableFrom(type) == false) {
throw new IllegalArgumentException(String.format(message, values)); throw new IllegalArgumentException(String.format(message, values));
} }