Use hamcrest matchers for better readability of assertions

This commit is contained in:
Benedikt Ritter 2015-05-04 21:42:50 +02:00
parent f175a241c8
commit ea1a69d638
1 changed files with 8 additions and 6 deletions

View File

@ -17,8 +17,10 @@
package org.apache.commons.lang3.builder; package org.apache.commons.lang3.builder;
import org.apache.commons.lang3.ArrayUtils; import static org.hamcrest.Matchers.containsString;
import org.junit.Assert; import static org.hamcrest.Matchers.not;
import static org.junit.Assert.assertThat;
import org.junit.Test; import org.junit.Test;
/** /**
@ -47,10 +49,10 @@ public class ReflectionToStringBuilderExcludeWithAnnotationTest {
public void test_toStringExclude() { public void test_toStringExclude() {
final String toString = ReflectionToStringBuilder.toString(new TestFixture()); final String toString = ReflectionToStringBuilder.toString(new TestFixture());
Assert.assertEquals(ArrayUtils.INDEX_NOT_FOUND, toString.indexOf(SECRET_FIELD)); assertThat(toString, not(containsString(SECRET_FIELD)));
Assert.assertEquals(ArrayUtils.INDEX_NOT_FOUND, toString.indexOf(SECRET_VALUE)); assertThat(toString, not(containsString(SECRET_VALUE)));
Assert.assertTrue(toString.indexOf(NOT_SECRET_FIELD) > ArrayUtils.INDEX_NOT_FOUND); assertThat(toString, containsString(NOT_SECRET_FIELD));
Assert.assertTrue(toString.indexOf(NOT_SECRET_VALUE) > ArrayUtils.INDEX_NOT_FOUND); assertThat(toString, containsString(NOT_SECRET_VALUE));
} }
} }