From f19304299f419a556d33279e0fc35c1e863386a7 Mon Sep 17 00:00:00 2001
From: Gary Gregory <garydgregory@gmail.com>
Date: Wed, 21 Aug 2024 14:02:06 -0400
Subject: [PATCH] Add TimeZonesTest

---
 .../commons/lang3/time/CalendarUtilsTest.java |  8 ++--
 .../commons/lang3/time/TimeZonesTest.java     | 39 +++++++++++++++++++
 2 files changed, 42 insertions(+), 5 deletions(-)
 create mode 100644 src/test/java/org/apache/commons/lang3/time/TimeZonesTest.java

diff --git a/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java b/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java
index 7e9a5c8d2..70a53d557 100644
--- a/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java
@@ -35,8 +35,6 @@
 
 public class CalendarUtilsTest extends AbstractLangTest {
 
-    private static final String TIME_ZONE_GET_AVAILABLE_IDS = "java.util.TimeZone#getAvailableIDs()";
-
     @Test
     public void testGetDayOfMonth() {
         assertEquals(Calendar.getInstance().get(Calendar.DAY_OF_MONTH), CalendarUtils.getInstance().getDayOfMonth());
@@ -94,7 +92,7 @@ public void testGetYear() {
     }
 
     @ParameterizedTest
-    @MethodSource(TIME_ZONE_GET_AVAILABLE_IDS)
+    @MethodSource(TimeZonesTest.TIME_ZONE_GET_AVAILABLE_IDS)
     public void testToLocalDateTime(final String id) {
         final TimeZone timeZone = TimeZone.getTimeZone(id);
         final ZoneId zoneId = timeZone.toZoneId();
@@ -107,7 +105,7 @@ public void testToLocalDateTime(final String id) {
     }
 
     @ParameterizedTest
-    @MethodSource(TIME_ZONE_GET_AVAILABLE_IDS)
+    @MethodSource(TimeZonesTest.TIME_ZONE_GET_AVAILABLE_IDS)
     public void testToOffsetDateTime(final String id) {
         final TimeZone timeZone = TimeZone.getTimeZone(id);
         final ZoneId zoneId = timeZone.toZoneId();
@@ -120,7 +118,7 @@ public void testToOffsetDateTime(final String id) {
     }
 
     @ParameterizedTest
-    @MethodSource(TIME_ZONE_GET_AVAILABLE_IDS)
+    @MethodSource(TimeZonesTest.TIME_ZONE_GET_AVAILABLE_IDS)
     public void testToZonedDateTime(final String id) {
         final TimeZone timeZone = TimeZone.getTimeZone(id);
         final ZoneId zoneId = timeZone.toZoneId();
diff --git a/src/test/java/org/apache/commons/lang3/time/TimeZonesTest.java b/src/test/java/org/apache/commons/lang3/time/TimeZonesTest.java
new file mode 100644
index 000000000..b8590e5a7
--- /dev/null
+++ b/src/test/java/org/apache/commons/lang3/time/TimeZonesTest.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.lang3.time;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.TimeZone;
+
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests {@link TimeZones}.
+ */
+public class TimeZonesTest {
+
+    static final String TIME_ZONE_GET_AVAILABLE_IDS = "java.util.TimeZone#getAvailableIDs()";
+
+    @Test
+    public void testToTimeZone() {
+        assertEquals(TimeZone.getDefault(), TimeZones.toTimeZone(null));
+        assertEquals(TimeZone.getDefault(), TimeZones.toTimeZone(TimeZone.getDefault()));
+        assertEquals(TimeZones.GMT, TimeZones.toTimeZone(TimeZones.GMT));
+    }
+}