Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add ThreadUtils.sleepQuietly(Duration) 

Remove new ThreadUtils.sleepQuietly(long)
This commit is contained in:
Gary Gregory 2022-08-21 15:17:44 -04:00
parent e92dafdc3b
commit f8df864f4c
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/changes/changes.xml
View File

@ -110,7 +110,7 @@ The <action> type attribute can be add,update,fix,remove.
<action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ArrayUtils.newInstance(Class&gt;T>, int).</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ArrayUtils.newInstance(Class&gt;T>, int).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add and use null-safe Streams.of(T...).</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add and use null-safe Streams.of(T...).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add ClassUtils.comparator().</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add ClassUtils.comparator().</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ThreadUtils.sleepQuietly(long).</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ThreadUtils.sleepQuietly(Duration).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ArrayUtils.setAll(T[], IntFunction).</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ArrayUtils.setAll(T[], IntFunction).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ArrayUtils.setAll(T[], Supplier).</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add and use ArrayUtils.setAll(T[], Supplier).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add BooleanConsumer.</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add BooleanConsumer.</action>

10
src/main/java/org/apache/commons/lang3/ThreadUtils.java
View File

@ -554,17 +554,17 @@ public class ThreadUtils {
} }
/** /**
* Sleeps for the given amount of milliseconds while ignoring {@link InterruptedException}. * Sleeps for the given duration while ignoring {@link InterruptedException}.
* <p> * <p>
* The sleep duration may be shorter than {@code millis} if we catch a {@link InterruptedException}. * The sleep duration may be shorter than duration if we catch a {@link InterruptedException}.
* </p> * </p>
* *
* @param millis the length of time to sleep in milliseconds * @param duration the length of time to sleep.
* @since 3.13.0 * @since 3.13.0
*/ */
public static void sleepQuietly(final long millis) { public static void sleepQuietly(final Duration duration) {
try { try {
sleep(Duration.ofMillis(millis)); sleep(duration);
} catch (final InterruptedException e) { } catch (final InterruptedException e) {
// be quiet. // be quiet.
} }

8
src/test/java/org/apache/commons/lang3/time/StopWatchTest.java
View File

@ -32,14 +32,14 @@ import org.apache.commons.lang3.reflect.FieldUtils;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
/** /**
* TestCase for StopWatch. * Tests {@link StopWatch}.
*/ */
public class StopWatchTest extends AbstractLangTest { public class StopWatchTest extends AbstractLangTest {
private static final Duration MILLIS_200 = Duration.ofMillis(200); private static final Duration MILLIS_200 = Duration.ofMillis(200);
private static final Duration MILLIS_550 = Duration.ofMillis(550); private static final Duration MILLIS_550 = Duration.ofMillis(550);
private static final String MESSAGE = "Baking cookies"; private static final String MESSAGE = "Baking cookies";
private static final int MIN_SLEEP_MILLISECONDS = 20; private static final Duration MIN_SLEEP = Duration.ofMillis(20);
private static final String ZERO_HOURS_PREFIX = "00:"; private static final String ZERO_HOURS_PREFIX = "00:";
private static final String ZERO_TIME_ELAPSED = "00:00:00.000"; private static final String ZERO_TIME_ELAPSED = "00:00:00.000";
@ -144,7 +144,7 @@ public class StopWatchTest extends AbstractLangTest {
@Test @Test
public void testFormatSplitTime() { public void testFormatSplitTime() {
final StopWatch watch = StopWatch.createStarted(); final StopWatch watch = StopWatch.createStarted();
ThreadUtils.sleepQuietly(MIN_SLEEP_MILLISECONDS); ThreadUtils.sleepQuietly(MIN_SLEEP);
watch.split(); watch.split();
final String formatSplitTime = watch.formatSplitTime(); final String formatSplitTime = watch.formatSplitTime();
assertNotEquals(ZERO_TIME_ELAPSED, formatSplitTime); assertNotEquals(ZERO_TIME_ELAPSED, formatSplitTime);
@ -155,7 +155,7 @@ public class StopWatchTest extends AbstractLangTest {
public void testFormatSplitTimeWithMessage() { public void testFormatSplitTimeWithMessage() {
final StopWatch watch = new StopWatch(MESSAGE); final StopWatch watch = new StopWatch(MESSAGE);
watch.start(); watch.start();
ThreadUtils.sleepQuietly(MIN_SLEEP_MILLISECONDS); ThreadUtils.sleepQuietly(MIN_SLEEP);
watch.split(); watch.split();
final String formatSplitTime = watch.formatSplitTime(); final String formatSplitTime = watch.formatSplitTime();
assertFalse(formatSplitTime.startsWith(MESSAGE), formatSplitTime); assertFalse(formatSplitTime.startsWith(MESSAGE), formatSplitTime);