Mariano de Achaval
2e1a1d4536
Fix javadoc in wrapIfMissing
...
wrapIfMissing function was referencing warp function in the javadoc
2019-03-12 09:40:44 -03:00
Gary Gregory
82b69a4dd6
[LANG-1436] (doc) Fix javadoc for 'startIndex' parameter of
...
StringUtils.join() methods. GitHub PR #412 .
2019-03-04 17:44:26 -05:00
Andrei Troie
353e06a8ac
(doc) Fix javadoc for 'startIndex' parameter of StringUtils.join() methods ( #412 )
2019-03-04 17:41:38 -05:00
Alex Herbert
fa9f1aae19
Consolidate the StringUtils.equals and equalsIgnoreCase methods. ( #409 )
...
* Consolidate the StringUtils.equals and equalsIgnoreCase methods.
Implement the same edge case logic for null. Use the same parameter
names. Use the same Javadoc wording. Change the equals method to use a
step-wise charAt comparison.
* LANG-1436: Added Jira to changes.xml.
2019-03-03 08:43:23 -05:00
Rob Tompkins
589ce59307
Merge pull request #391 from RahulNagekar/JsonToStringStyle_Junits
...
Adding junits for JsonToStringStyle
2019-02-18 18:34:22 -05:00
Benedikt Ritter
75768ba272
Simplify test code by using lambda expressions
2019-02-09 16:56:09 +01:00
pascalschumacher
508ddd1295
Update checkstyle to version 8.17
2019-02-09 13:54:01 +01:00
pascalschumacher
c127a7266a
Update EasyMock to version 4.0.2
2019-02-09 13:46:58 +01:00
pascalschumacher
b5ed6c6180
Update Hamcrest to version 2.1
2019-02-09 13:43:15 +01:00
pascalschumacher
c6bb13cb99
Remove dependency management for JUnit (since the update to JUnit 5.4.0 we only have a single JUnit test dependency).
2019-02-09 13:31:34 +01:00
Allon Mureinik
c01fa9aa42
Simplify assertions ( closes #404 )
...
Use JUnit methods to clean up the test and simplify the assertions:
- assertArraysEqual(x, y) replaces assertTrue(Arrays.equals(x, y))
- assertEquals(x, y) replaces assertTrue(x == y)
- assertNotEquals(x, y) replaces assertFalse(x == y)
2019-02-09 12:44:42 +01:00
Allon Mureinik
a4adb41259
Use assertThrows in FunctionsTest (closes #404 )
...
Use JUnit Jupiter's elegant assertThrows method instead of the
boilerplate pattern of try-fail-catch to assert an exception was
thrown.
2019-02-09 12:44:06 +01:00
Eitan Adler
6b7a848010
[ToStringBuilderTest] clean up after some old issues
...
- Remove code to handle old JDK 6 bugs
- Fix a mis-ordered assertEquals
- Remove a deprecated call to Character's constructor
2019-02-09 02:08:32 -08:00
Allon Mureinik
bfa50b3edf
Clean up floating point assertions ( closes #402 )
...
JUnit Jupiter 5.4.0 supports deltas of 0 when asserting double and
float equalities.
This patch utilizes these new assertEquals methods and removes the
hack of using assertTrue with an == statement that was needed in older
JUnit versions.
2019-02-08 19:54:17 +01:00
Allon Mureinik
2273b6e44e
Upgrade JUnit depedency to 5.4.0 ( closes #402 )
...
Upgrade the JUnit dependency to the latest available 5.4.0.
Note that JUnit simplified its artifacts, and now it contains a
single, simple org.junit:junit-jupiter artifact.
2019-02-08 19:53:20 +01:00
pascalschumacher
17bbe77262
Skip javadoc on Java 11 to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module."
2019-02-08 19:50:44 +01:00
pascalschumacher
43badd4dfa
Merge remote-tracking branch 'origin/pr/403'
2019-02-08 19:41:40 +01:00
Allon Mureinik
fc6a392b7c
Fix javadoc errors in Functions.java
2019-02-08 20:08:56 +02:00
Allon Mureinik
f12cfc8d4e
FunctionsTest whitespaces
...
Use four spaces instead of a tab as per the projcet's Checkstyle
rules.
2019-02-08 19:39:01 +02:00
Allon Mureinik
19a5a09b09
FunctionsTest whitespace after comma
...
Add a space after the comma as per the project's Checkstyle rules
2019-02-08 19:37:38 +02:00
Allon Mureinik
5e315d1ac9
FunctionsTest method references
...
Use method references instead of lambda expression to clean up the
code and comply to the project's Checkstyle rules.
2019-02-08 19:36:29 +02:00
Allon Mureinik
76a243c587
FunctionTest redundant constructor modifier
...
Remove redundant public modifiers from inner classes constructors as
per the project's Checkstyle rules.
2019-02-08 19:34:40 +02:00
Allon Mureinik
95926eb5d9
FunctionsTest imports
...
Clean up FunctionsTest's imports as per the project's Checkstyle
rules.
2019-02-08 19:32:39 +02:00
Allon Mureinik
c5eadb1c6d
Functions.java whitspaces
...
Replace tabs with four spaces, as per the project's Checkstyle rules.
2019-02-08 19:30:35 +02:00
Allon Mureinik
962e529984
Add spaces after commas in Functions.java
...
Add spaces after commas as per the project's Checkstyle rules.
2019-02-08 19:29:06 +02:00
Allon Mureinik
028c9ec70c
Remove unused generic argument from Functions#tryWithResources
2019-02-08 19:25:27 +02:00
Allon Mureinik
b08c92e75d
Fix Javadoc issues in Functions
2019-02-08 19:23:40 +02:00
Allon Mureinik
f7fae53aec
Functions' interfaces modifiers
...
Remove the redundant public modifier from the inner interfaces in
Functions, as per the Checkstyle policy of the project.
2019-02-08 18:18:40 +02:00
Allon Mureinik
1c48eb0d8b
Add license to FunctionsTest.java
...
Add a license header to FunctionsTest.java to make the rat maven task
pass.
2019-02-08 17:47:29 +02:00
Benedikt Ritter
ef1480a505
Add missing Apache license header
2019-02-08 16:42:31 +01:00
Jochen Wiedmann (jwi)
2ebc17ba3f
Added Functions.tryWithResources.
2019-01-29 11:42:07 +01:00
Jochen Wiedmann (jwi)
11d9eb47a4
Adding the Functions class as a helper for dealing with Java 8 Lambdas.
2019-01-23 14:59:25 +01:00
Bruno P. Kinoshita
b00e65686e
Fix checkstyle issues in new test code
2019-01-08 20:01:56 +13:00
Bruno P. Kinoshita
104cc28105
Merge branch 'pr-379'
...
This closes pr #379
Thanks to @apirom9
2019-01-08 19:48:34 +13:00
Apirom Na Nakorn
bf77678673
add test use ImmutablePair class with java.util.HashMap and java.util.TreeMap
2019-01-08 19:48:22 +13:00
pascalschumacher
f7c62b29c9
Update spotbugs-maven-plugin to version 3.1.10
2019-01-05 22:51:18 +01:00
pascalschumacher
ef18f3ea26
Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on. ( closes #396 )
2019-01-05 22:13:24 +01:00
RahulNagekar
cee7cc6b64
Refactoring junits of JsonToStringStyle
2018-12-21 01:05:50 +05:30
RahulNagekar
92e63fb3c8
Adding junits for JsonToStringStyle
...
Signed-off-by: RahulNagekar <rahul.nagekar1@gmail.com>
2018-12-21 00:42:34 +05:30
pascalschumacher
e0a5a4b5b6
Update to JaCoCo 0.8.2 with works Java 11+.
2018-12-20 14:48:34 +01:00
pascalschumacher
a48d045709
LANG-1427: Add SystemUtils.isJavaVersionAtMost(JavaVersion)
...
Fix checkstyle violations.
2018-12-20 14:26:28 +01:00
Gary Gregory
e21cb463c0
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-lang.git
2018-12-10 17:48:30 -07:00
Gary Gregory
a410aab651
[LANG-1427] Add API
...
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JavaVersion)
2018-12-10 17:48:06 -07:00
RahulNagekar
c368955343
Add additional tests for StandardToStringStyle ( closes #390 )
2018-12-02 19:59:59 +01:00
pascalschumacher
37ba8d3981
Update to JUnit version 5.3.2
2018-12-02 14:11:09 +01:00
pascalschumacher
aae1a0a681
Travis: Stop building with Java 9 and 10, as these are superseded by Java 11 and not supported anymore.
2018-11-24 12:47:38 +01:00
pascalschumacher
60b8f18e46
Update Spotbugs Maven Plugin to version 3.1.8
2018-11-20 21:38:15 +01:00
pascalschumacher
5cdac9cfd5
Make whitespace use around generic tokens consistent and add a checkstyle rule to enforce it.
2018-11-19 22:05:18 +01:00
pascalschumacher
07f537120f
Make whitespace use before tokens consistent and add a checkstyle rule to enforce it.
2018-11-19 22:05:11 +01:00
pascalschumacher
89cbfa54b0
Make whitespace use after tokens consistent and add a checkstyle rule to enforce it.
2018-11-19 22:04:35 +01:00