Commit Graph

5280 Commits

Author SHA1 Message Date
Gary Gregory 7f8897faba Processor.java: check enum euqality with == instead of .equals() method
#690.
2021-01-03 11:14:28 -05:00
Ali K. Nouri 43b926eef8
Processor.java: check enum euqality with == instead of .equals() method (#690) 2021-01-03 11:12:45 -05:00
Gary Gregory e6e1682089 Replace cascading if-else's with a case statement. 2021-01-03 11:08:27 -05:00
Gary Gregory 1948d987db Remove dead comments. 2021-01-01 13:44:31 -05:00
Gary Gregory 876543f6cc Add JavaVersion.JAVA_17 now that Java 17-ea is out. 2021-01-01 13:44:01 -05:00
Gary Gregory a36b59c6f8 CLean up odds and ends.
- Use EMPTY constant.
- Move a guard clause down to the implementating method from wrapper
method.
- Remove dead comments.
- Remove duplicate null check.
- Remove duplicate empty-string check.
- Use Charsets.toCharset).
2021-01-01 13:34:56 -05:00
Gary Gregory 733768a6d9 Add recent macOS versions.
macOS 10.12 Sierra
macOS 10.13 High Sierra
macOS 10.14 Mojave
macOS 10.15 Catalina
macOS 10.16 Big Sur (a.k.a. 11.0, 11.1)
2021-01-01 11:12:07 -05:00
Gary Gregory f5c86f6d4e Update commons.japicmp.version 0.14.4 -> 0.15.1. 2020-12-31 02:27:57 -05:00
Gary Gregory 9801f93d47 Update commons.japicmp.version 0.14.3 -> 0.14.4. 2020-12-29 18:54:45 -05:00
Gary Gregory cd013c9239 Use less mysterious names. 2020-12-29 13:23:19 -05:00
Gary Gregory 8aff0a08f2 Show Java version in assertion failure message. 2020-12-29 11:45:04 -05:00
Gary Gregory 5157875ce5 Javadoc to make is easier to use your IDE to jump to the method. 2020-12-29 11:41:49 -05:00
Arturo Bernal 9fa1d734f6
LANG-1631 - Check if the char to be searched is defined (#682) 2020-12-27 12:05:33 -05:00
Gary Gregory 45bec219d2 Add FailableShortSupplier, handy for JDBC APIs. 2020-12-24 10:02:37 -05:00
Gary Gregory b5bb3e6d3a Fix test method names. 2020-12-23 20:05:48 -05:00
Gary Gregory 157ba27be7 Minor internal clean ups. Add and use constants. 2020-12-23 10:24:13 -05:00
Gary Gregory b1da31ef40 Simplify Javadocs. 2020-12-23 10:03:31 -05:00
Gary Gregory 31ede5565b Use final. 2020-12-22 16:07:02 -05:00
Gary Gregory 44b0bb5273 Use ArraySorter. 2020-12-22 16:06:55 -05:00
Gary Gregory 5aab41b365 Update for new class. 2020-12-22 15:20:10 -05:00
Gary Gregory ad69874a78 [LANG-1544] MethodUtils.invokeMethod NullPointerException in case of
null in args list #680.
2020-12-22 15:16:41 -05:00
Gary Gregory 2d97e0daf8 [LANG-1544] MethodUtils.invokeMethod NullPointerException in case of
null in args list #680.
2020-12-22 15:13:37 -05:00
Michael Buck fb6a7e7788
[LANG-1544] MethodUtils.invokeMethod NullPointerException in case of null in args list (#680)
* LANG-1544:
- Null guards in place to handle one or more nulls specified as one of the parameters of the method to invoke.
- Check for an exact match of the actual parameter types against all of the methods on the class. This prevents picking an "upcasted" method (i.e. int specified but a method with a double is chosen).
- Throw an IllegalStateException with a helpful message if multiple candidate methods were found. This happens when multiple Methods had the same "distance" from the desired parameter types. Before this change the algorithm would just chose the first one.
- Tests for the above.

Co-authored-by: mike.buck@pb.com <mike.buck@pb.com>
2020-12-22 15:12:14 -05:00
Gary Gregory f22dbf0399 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-lang.git 2020-12-22 15:03:29 -05:00
Gary Gregory 1b96fc1494 Correct markup in Javadoc for unbalanced braces #679. 2020-12-22 10:28:54 -05:00
Felix Schumacher 0a4505fa97
Correct markup in javadoc for unbalanced braces (#679)
Use <code>{</code> instead of {@code {}, as the latter one is
invalid. It works onn the current javadoc, as it is accompanied
with the equally invalid closing statement {@code }}, which
balances the used braces in the @code fragements and combines
the first invalid statement with the last one.
2020-12-22 10:26:31 -05:00
Gary Gregory b4456352bc Move new sort methods to a new class and add primitive versions.
This avoid growing ArrayUtils even more while keeping the new class
focused on sort APIs.
2020-12-21 16:43:30 -05:00
Gary Gregory c9e825e823 Add and use LocaleUtils.toLocale(Locale) to avoid NPEs and use the
default locale when an input locale is null.
2020-12-21 12:56:19 -05:00
Gary Gregory b5de0ef280 Sort members. 2020-12-21 12:26:32 -05:00
LeeJuHyun 1f2003041b
[LANG-1629] Delete white space (#678) 2020-12-21 12:21:40 -05:00
Gary Gregory d704c0dc70 Fix spelling in comment. 2020-12-20 13:23:54 -05:00
dependabot[bot] 2f60e45087 Bump jmh.version from 1.21 to 1.27
Bumps `jmh.version` from 1.21 to 1.27.

Updates `jmh-core` from 1.21 to 1.27

Updates `jmh-generator-annprocess` from 1.21 to 1.27

Signed-off-by: dependabot[bot] <support@github.com>
2020-12-20 08:58:45 +13:00
Bruno P. Kinoshita e0de3be47c [LANG-1628] changelog 2020-12-20 08:42:48 +13:00
avijitchakraborty85@gmail.com 123606371b [LANG-1628] Javadoc correction for RandomStringUtils.random() letters, numbers parameters 2020-12-20 08:40:57 +13:00
Gary Gregory 55570e8ef7 Fix spelling. 2020-12-17 14:39:47 -05:00
Gary Gregory e9647813f7 Fix spelling. 2020-12-17 14:39:09 -05:00
Gary Gregory 615eee5d51 [LANG-1626] Correction in Javadoc of some methods. #673. 2020-12-11 00:05:27 -05:00
Kanak Sony efbfd2de97
[LANG-1626] Correction in Javadoc of some methods. (#673)
1) Found Javadoc examples in ArrayUtils.addFirst() incorrectly refer to add() at 9 places.
2) Basic code format in 3 files from time package.
2020-12-11 00:03:30 -05:00
Gary Gregory 55e0776408 Bump spotbugs from 4.1.4 to 4.2.0 #671. 2020-12-10 15:13:00 -05:00
Gary Gregory 041cf552c5 [LANG-1580] Refine StringUtils.deleteWhitespace #569. 2020-12-05 12:31:42 -05:00
XenoAmess 5a17dc7ad3
refine deleteWhitespace (#569) 2020-12-05 12:30:42 -05:00
Gary Gregory eaebffb59a Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-lang.git 2020-12-05 12:29:04 -05:00
Gary Gregory 0532e10668 [LANG-1584] Refine StringUtils.isNumericSpace #573 2020-12-05 12:28:58 -05:00
XenoAmess ea8428ab75
[LANG-1584] Refine StringUtils.isNumericSpace (#573)
* refine isNumericSpace

* fix same issues in other two functions
2020-12-05 12:24:22 -05:00
Gary Gregory 902a0faab4 [LANG-1620] Refine StringUtils.lastIndexOfIgnoreCase #664.
[LANG-1619] Refine StringUtils.abbreviate #663.
2020-12-05 12:22:28 -05:00
Arturo Bernal dd7f02feac
LANG-1619 - refine StringUtils.abbreviate (#663) 2020-12-05 12:20:00 -05:00
Arturo Bernal 76443d7f1d
LANG-1620 - refine StringUtils.lastIndexOfIgnoreCase (#664) 2020-12-05 12:16:31 -05:00
Gary Gregory f9f4c09fd7 Document third party bumps.
- Bump checkstyle from 8.37 to 8.38 #665.
- Bump junit-pioneer from 1.0.0 to 1.1.0 #662.
- Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #660.
2020-12-05 11:24:31 -05:00
Gary Gregory 605f59d869 [LANG-1622] Corrected reference to right methods. #667. 2020-12-05 11:20:34 -05:00
Gary Gregory c008f4d895 [LANG-1622] Corrected reference to right methods. #667. 2020-12-05 11:18:47 -05:00
Kanak Sony 9bd9643a0b
[LANG-1622] Corrected reference to right methods. (#667) 2020-12-05 11:17:19 -05:00
Gary Gregory 66b54723f0 [LANG-1622] Javadoc of some methods incorrectly refers to another method
#668.
2020-12-03 10:36:33 -05:00
anomen-s d878091c2c
[LANG-1622] - javadoc of some methods incorrectly refers to another method (#668) 2020-12-03 10:32:59 -05:00
Gary Gregory 8c66a5fcb7 [LANG-1535] Add StringUtils.containsAnyIgnoreCase(CharSequence,
CharSequence...).
2020-11-29 13:11:46 -05:00
Gary Gregory 1bf275cb60 [LANG-1535] Add StringUtils.containsAnyIgnoreCase(CharSequence,
CharSequence...).
2020-11-29 13:11:13 -05:00
Gary Gregory c2da7e3c51 Don't need local var. 2020-11-26 10:00:32 -05:00
Gary Gregory ebed08cb25 [LANG-1618] ypeUtils. containsTypeVariables does not support
GenericArrayType #661.
2020-11-26 09:58:28 -05:00
Arturo Bernal b74c697bba
LANG-1618 - Add GenericArrayType (#661) 2020-11-26 09:55:48 -05:00
Gary Gregory 5b025fe4b6 Use a String instead of building one. 2020-11-21 14:10:54 -05:00
Gary Gregory 90e357d461 Redundant return. 2020-11-21 13:51:16 -05:00
Gary Gregory 764b9bba52 Use final. 2020-11-20 22:12:25 -05:00
Gary Gregory d5196e7fe4 No need to initialize to default value. 2020-11-20 21:45:32 -05:00
Gary Gregory f3346dd067 Fix ctor call. 2020-11-20 21:45:19 -05:00
Gary Gregory 53e4f62b51 Remove redundant calls to super(). 2020-11-20 18:00:10 -05:00
Gary Gregory d8f8d9a3a8 Initialize a collection when you create it. 2020-11-20 16:09:58 -05:00
Gary Gregory f2480a984f Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-lang.git 2020-11-17 15:19:06 -05:00
Gary Gregory 12e4ad1cfa Fix formatting of isAn.
yBlank() and isAnyEmpty(). #513
2020-11-17 15:18:58 -05:00
Isira Seneviratne 5f3a9a6eae
Fix formatting of isAnyBlank() and isAnyEmpty(). (#513) 2020-11-17 15:17:57 -05:00
Gary Gregory 412f1e13c9 [LANG-1610] Fix StringUtils.unwrap throws
StringIndexOutOfBoundsException #636
2020-11-17 15:14:28 -05:00
Tony Liang c6f577555b
LANG-1610: Fix StringUtils.unwrap throws StringIndexOutOfBoundsException (#636)
Co-authored-by: Tony Liang <shuchel@zillowgroup.com>
2020-11-17 15:11:19 -05:00
Gary Gregory bd8dbbe0be Fix Javadoc for SystemUtils.isJavaVersionAtMost() #638. 2020-11-17 15:08:19 -05:00
John R. D'Orazio 2adf71bf23
fix javadoc for isJavaVersionAtMost (#638)
the javadoc for isJavaVersionAtMost was the same as for isJavaVersionAtLeast! They sure don't do the same thing :)
2020-11-17 15:06:27 -05:00
Gary Gregory 61e82e832e [LANG-1615] ArrayUtils contains() and indexOf() fails to handle
Float.NaN.
2020-11-15 17:42:04 -05:00
Arturo Bernal 2ccc58e344
[LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN (#651)
* LANG-1615 - ArrayUtils contains && indexOf fails to handle Float.NaN

* Change var name

* Fix checkstyle spaces black

* Fix checkstyle spaces black
2020-11-15 17:37:54 -05:00
Gary Gregory 08d1f66236 [LANG-1612] Fix flaky tests in FieldUtilsTest. 2020-11-15 12:24:13 -05:00
Gary Gregory 3bda8be036 Add fluent-style ArrayUtils.sort(Object[], Comparable). 2020-11-15 12:08:32 -05:00
Gary Gregory 35799d0958 [LANG-1420] TypeUtils.isAssignable returns wrong result for
GenericArrayType and ParameterizedType.
2020-11-15 11:49:11 -05:00
Gary Gregory e123bab198 Fix potential NPE in TypeUtils.isAssignable(Type, ParameterizedType,
Map, Type>).
2020-11-15 10:55:53 -05:00
Gary Gregory 43b2326713 Consistently use just the parameter name for the message of
NullPointerExceptions.
2020-11-15 10:40:31 -05:00
Gary Gregory fe1c7903a8 Sort members. 2020-11-15 09:37:29 -05:00
Gary Gregory 46cdc660f2 Javadoc. 2020-11-15 09:37:10 -05:00
Gary Gregory 0e2ebd347c [LANG-1541] ArrayUtils.contains() and indexOf() fails to handle
Double.NaN #647.

Also remove trailing whitespaces.
2020-11-14 16:33:35 -05:00
Gary Gregory 4cf3dc8c8f [LANG-1613] - BigDecimal is created when you pass it the minimum values…
#642.
2020-11-14 12:23:33 -05:00
Gary Gregory 09c662429b Add fluent-style ArrayUtils.sort(Object[]). 2020-11-14 11:41:46 -05:00
Gary Gregory 14b60bbb9f Update maven-surefire-plugin 2.22.2 -> 3.0.0-M5.
Organize changes.xml for 3.12 entries.
2020-11-14 10:00:46 -05:00
Gary Gregory 6aab14bf1c [LANG-1359] Add StopWatch.getStopTime().
Simplify test.
2020-11-14 09:41:51 -05:00
Gary Gregory e832b70e40 [LANG-1359] Add StopWatch.getStopTime(). 2020-11-14 09:31:59 -05:00
Gary Gregory c9722131d5 Add StopWatch.getStopTime().
Also:
- Rename private instance variable to reflect scale.
- More precise Javadocs.
- Throw IllegalStateException instead of RuntimeException.
- Refactor common code in test for sleeping the current thread.
2020-11-14 09:27:04 -05:00
Gary Gregory 93d520a3e1 Add StringUtils.containsAnyIgnoreCase(CharSequence, CharSequence...). 2020-11-13 10:30:08 -05:00
Gary Gregory 6a991d8413 Close HTML tag. 2020-11-13 10:10:27 -05:00
Gary Gregory 6f51b9b7cb Sort members. 2020-11-13 10:01:10 -05:00
Gary Gregory 6b3f258ed7 Bump checkstyle from 8.36.2 to 8.37 #637. 2020-11-06 09:46:31 -05:00
Gary Gregory 146ddf2363 Bump actions/checkout from v2.3.3 to v2.3.4 #639. 2020-11-06 09:44:21 -05:00
Gary Gregory 20ae8f6888 More test coverage for CharSequenceUtils. #631. 2020-10-25 10:53:14 -04:00
Edgar Asatryan 34a3096eb4
More coverage for CharSequenceUtils. (#631) 2020-10-25 10:52:16 -04:00
Gary Gregory 05cb6139b9 Bump spotbugs-maven-plugin from 4.1.3 to 4.1.4 #632. 2020-10-25 10:47:11 -04:00
Gary Gregory 13eab3b25e Use own API for ser/deser roundtrip since the point of the test is not
proper usage of JRE API but whether our classes are properly
implemented.
2020-10-25 10:43:33 -04:00
Gary Gregory 54afd64c79 Fix param name. 2020-10-25 10:36:34 -04:00
Gary Gregory 4d066361c0 Suppress warning and add comment; use a simpler error messgae. 2020-10-25 10:34:59 -04:00
Gary Gregory 8fbf27a830 Sort methods. 2020-10-25 10:29:58 -04:00
Gary Gregory faa48f6b6a Fix generics warning. 2020-10-25 10:21:12 -04:00
Gary Gregory 75b4058ac4 NumberUtilsTest - incorrect types in min/max tests #634.
- Document change.
- Sort methods.
- Format to max line length 120.
2020-10-25 10:18:00 -04:00
Hubert 6d7a3e6eeb
NumberUtilsTest - incorrect types in min/max tests (#634)
* Fix: correctly declared types and added castings

* Fix: code format

* Redo - optimize imports
2020-10-25 10:12:45 -04:00
Gary Gregory 110b4c021e Checkstyle. 2020-10-22 14:53:59 -04:00
Gary Gregory 7995aad79f Split out tests for a Java 15 bug.
These tests fail on Java 15 due to a bug which was only fixed for Java
16.
See https://bugs.openjdk.java.net/browse/JDK-8248434
See https://bugs.openjdk.java.net/browse/JDK-8248655
2020-10-22 14:47:45 -04:00
Gary Gregory bcdff98f02 Sort methods. 2020-10-20 11:45:46 -04:00
Gary Gregory b8204aa29b Checkstyle: Whitepace. 2020-10-20 11:05:14 -04:00
Gary Gregory d05ad7abd6 Add missing Javadoc. 2020-10-20 10:47:07 -04:00
Gary Gregory e14a2d9226 Update dependencies.
- Bump biz.aQute.bndlib from 5.1.2 to 5.2.0 #628.
- Bump spotbugs from 4.1.3 to 4.1.4 #627.
- Bump junit-pioneer from 0.9.2 to 1.0.0 #625.
2020-10-20 10:21:56 -04:00
Alex Herbert 43c80576cf LANG-1608: Track changes 2020-10-17 14:00:54 +01:00
Gary Gregory 8ff63a0da3 Bump spotbugs-maven-plugin from 4.0.4 to 4.1.3 #623. 2020-10-03 10:28:45 -04:00
Gary Gregory a6f97f358f Bump junit-pioneer from 0.9.0 to 0.9.2 #624. 2020-10-02 11:15:43 -04:00
Rob Tompkins c1c4a7535b (changes) Bump junit-jupiter from 5.6.2 to 5.7.0 2020-10-01 10:16:03 -04:00
Rob Tompkins dd1c0d9292 (changes) Bump spotbugs from 4.1.2 to 4.1.3 2020-10-01 10:10:16 -04:00
Rob Tompkins 66681a7643 (changes) Bump checkstyle from 8.36 to 8.36.2 2020-10-01 10:07:30 -04:00
Gary Gregory b2e7374bfb Add BooleanUtils.booleanValues().
Add BooleanUtils.primitiveValues().

Handy for tools and tests.
Make next release version 3.12.0.
2020-09-28 15:31:56 -04:00
Gary Gregory a3e5a0134e Sort members. 2020-09-28 15:19:12 -04:00
Gary Gregory 218eae4c3a Sort members. 2020-09-28 15:13:28 -04:00
Gary Gregory bae0e42fac Update commons.jacoco.version 0.8.5 to 0.8.6 (Fixes Java 15 builds). 2020-09-19 16:05:16 -04:00
Sebb 4b5f1cf57d One per line 2020-09-12 23:38:51 +01:00
Sebb 433700ea80 One per line 2020-09-12 23:37:12 +01:00
Sebb 693e5129e8 Useless assignment 2020-09-12 23:34:29 +01:00
Sebb 875d1054c0 Useless parentheses 2020-09-12 23:32:56 +01:00
Sebb 7ab21126a0 Docs 2020-09-12 23:31:44 +01:00
Sebb 38a9209456 LANG-1606 StringUtils.countMatches - fix Javadoc 2020-09-12 23:23:18 +01:00
Gary Gregory 0054e51500 checkstyle from 8.35 to 8.36 #614. 2020-09-08 11:47:02 -04:00
Gary Gregory 3621a65051 ContextedException Javadoc add missing semicolon #581. 2020-08-30 18:33:34 -04:00
iamchao1129 ddac01fc9a
Add semicolon (#581)
Co-authored-by: zhangchao36 <zhangchao36@jd.com>
2020-08-30 18:31:34 -04:00
Gary Gregory 81efeaacad [LANG-1600] Restore handling of collections for non-JSON ToStringStyle
#610.
2020-08-30 18:29:54 -04:00
Michael F 772f97c437
[LANG-1600] Restore handling of collections for non-JSON ToStringStyle (#610)
* [LANG-1600] add test cases for non-empty collections, maps, and arrays

* break out those test cases into separate methods for legibility
* addresses issue introduced in LANG-1542 with commit 1dddec8

* [LANG-1600] restore non-json-style handling of appendDetail() for Collection

* addresses issue introduced in LANG-1542 with commit 1dddec8
2020-08-30 18:27:17 -04:00
Gary Gregory 47f96a3c95 End sentence with a period. 2020-08-30 18:13:45 -04:00
Gary Gregory 0683ab262d Revert "Better link."
This reverts commit b1a66d2da9.
2020-08-30 18:13:18 -04:00
Gary Gregory b1a66d2da9 Better link. 2020-08-30 18:12:26 -04:00
Gary Gregory 5512896585 spotbugs from 4.1.1 to 4.1.2 #609. 2020-08-30 11:37:31 -04:00
Gary Gregory fb34130520 actions/setup-java from v1.4.0 to v1.4.2 #612. 2020-08-30 11:34:48 -04:00
Gary Gregory 21fe158cb2 Merge branch 'release' and resolve conficts. 2020-08-30 11:33:31 -04:00
Gary Gregory 2f19010c7a Fix a Javadoc link to always point to the current release and not
mention a specific version label.
2020-08-30 11:27:37 -04:00
Gary Gregory 31dc5c700e Remove old comments. 2020-08-20 13:50:23 -04:00
Gary Gregory 5d05df0f9e Simplify lambdas. 2020-08-14 23:35:42 -04:00
Gary Gregory 348cf47741 [LANG-1596] ArrayUtils.toPrimitive(Object) does not support boolean and
other types #607.
2020-08-14 23:27:31 -04:00
Richard Eckart de Castilho 6996806101
[LANG-1596] ArrayUtils.toPrimitive(Object) does not support boolean and other types (#607)
- Add support for the missing types to toPrimitive(Object)
- Added tests for toPrimitive methods which did not have test coverage yet
- Added explicit test for the toPrimitive(Object) method for all primitive types
2020-08-14 23:25:54 -04:00
Gary Gregory 9f52471fab junit-pioneer from 0.8.0 to 0.9.0 #600. 2020-08-10 12:03:02 -04:00
Gary Gregory 17e1f408f7 actions/checkout from v2.3.1 to v2.3.2 #601. 2020-08-10 12:02:06 -04:00
Gary Gregory 8a877ec12e Describe recent change. 2020-08-03 09:29:10 -04:00
Gary Gregory 528e4c7655 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-lang.git 2020-08-03 09:20:46 -04:00
Gilles Sadowski 4897c8869b LANG-1593: Add unit test with OP's use-case that shows unexpected difference in behaviour.
Unit test is set to "@Disabled" to not fail the build.
2020-08-03 12:24:13 +02:00
Gary Gregory 03ae165039 Document recent changes. 2020-07-31 09:13:40 -04:00
aherbert c3b4e22562 Fix changes description to include class name 2020-07-29 11:50:55 +01:00
aherbert dbe022e646 LANG-1579: Improve stripAccents conversion of remaining accents
Single characters can be changed in place to avoid delete then insert.

Closes #568
2020-07-29 11:47:46 +01:00
Gary Gregory f22f659321 Document recent change. 2020-07-23 11:14:40 -04:00