Commit Graph

3422 Commits

Author SHA1 Message Date
Joerg Schaible 46448a690c Simplify expressions again.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1393539 13f79535-47bb-0310-9956-ffa450edef68
2012-10-03 15:26:13 +00:00
Joerg Schaible bb7462c8b5 Document exceptions. Use IllegalArgumentException instead of assert. Throw IllegalArgumentException for empty arrays.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1393425 13f79535-47bb-0310-9956-ffa450edef68
2012-10-03 11:25:51 +00:00
Joerg Schaible 216411597d Use lowercase presentation for hex values as it is done in the JDK.
Use JDK functionality where available.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1393073 13f79535-47bb-0310-9956-ffa450edef68
2012-10-02 18:12:53 +00:00
Sebastian Bazley f01111b634 Add some code comments
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391783 13f79535-47bb-0310-9956-ffa450edef68
2012-09-29 11:28:57 +00:00
Sebastian Bazley 86226bb499 There are only two distinct boolean values
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391701 13f79535-47bb-0310-9956-ffa450edef68
2012-09-28 23:59:55 +00:00
Sebastian Bazley 2be663db75 LANG-838 ArrayUtils removeElements methods clone temporary index arrays unnecessarily
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391695 13f79535-47bb-0310-9956-ffa450edef68
2012-09-28 23:30:31 +00:00
Joerg Schaible 6545db8bb7 Revert 1391258 by veto of Sebb.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391571 13f79535-47bb-0310-9956-ffa450edef68
2012-09-28 17:40:16 +00:00
Joerg Schaible 413a98eb21 Use conversion tables for boolean arrays.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391258 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 22:53:46 +00:00
Joerg Schaible 560bde10c7 "import java.lang.*" is always implicit.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391246 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 22:35:09 +00:00
Sebastian Bazley 91b9a3de99 Document sync. strategy
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391242 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 22:30:08 +00:00
Joerg Schaible 38fea7d456 Avoid unnecessary conversions.
Use StringBuilder instead of StringBuffer.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391237 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 22:10:55 +00:00
Joerg Schaible 3de2a0c914 Implement test TODO.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391233 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 21:52:05 +00:00
Joerg Schaible 342a9184a9 JUnit 3 --> JUnit 4
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391222 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 21:08:54 +00:00
Sebastian Bazley c62d888e94 Use JUnit4 methods where possible
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391216 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 21:00:02 +00:00
Sebastian Bazley 0ee336a58f Convert to JUNit4
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391199 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 20:24:35 +00:00
Sebastian Bazley 82f04621a4 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391195 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 20:10:33 +00:00
Sebastian Bazley 2abc129650 Convert Strategy to abstract class; simplifies the subclasses
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391187 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 19:41:33 +00:00
Joerg Schaible 1000d1a1bd LANG-801: Add Conversion utility to convert between data types on byte level
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391148 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 18:09:08 +00:00
Sebastian Bazley 7c7c9447f6 Add test for StringBuilder
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391116 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 17:27:29 +00:00
Sebastian Bazley b5c79770db Add comment
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391113 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 17:22:50 +00:00
Sebastian Bazley 89c6497228 StringBuffer => StringBuilder where being used as a local-only buffer
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391112 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 17:21:12 +00:00
Sebastian Bazley 3ab8e13026 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391095 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 16:46:50 +00:00
Sebastian Bazley acb89828f1 Javadoc typos
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391048 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 15:02:09 +00:00
Sebastian Bazley a0148b0e20 Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391027 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 14:20:10 +00:00
Sebastian Bazley f9837a0728 Suppress boxing warnings for assertEquals()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391025 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 14:18:55 +00:00
Sebastian Bazley cc730589cd Document some @SuppressWarning annotations
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1391003 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 13:34:33 +00:00
Sebastian Bazley 76833dc4a4 Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390993 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 13:16:30 +00:00
Sebastian Bazley f068cb71b5 Tab police
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390989 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 13:12:09 +00:00
Sebastian Bazley 0490f1c291 LANG-820 TypeUtils.normalizeUpperBounds broken?
Added test to show it works OK

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390984 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 13:01:57 +00:00
Sebastian Bazley 04babff379 LANG-818 FastDateFormat's "z" pattern does not respect timezone of Calendar instances passed to format()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390980 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 12:56:19 +00:00
Sebastian Bazley cfab1e4fa1 LANG-815 DurationFormatUtils.formatPeriod() mis-calculation
Add test case to show there is no issue

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390971 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 12:46:42 +00:00
Sebastian Bazley 77eed078c8 LANG-777 jar contains velocity template of release notes
Merge releases notes into standard location

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390966 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 12:32:45 +00:00
Sebastian Bazley 586e0b1c8a Copy of Commons Parent version; generates same output
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390962 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 12:21:51 +00:00
Sebastian Bazley 6ecb0a30c3 LANG-830 FastDateParser could use \Q \E to quote regexes
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390954 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 11:50:52 +00:00
Sebastian Bazley e5ae84a6fc LANG-829 FastDateParser could use Calendar.getDisplayNames for all text fields
Remove unnecessary KeyValue instances

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390937 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 10:59:30 +00:00
Chas Honton 8c87749695 LANG-829: FastDateParser could use Calendar.getDisplayNames for all text fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390839 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 04:50:21 +00:00
Sebastian Bazley 9960dd4204 Add some more tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390816 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 03:04:49 +00:00
Sebastian Bazley 67914b1475 Add some more tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390815 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 02:46:55 +00:00
Sebastian Bazley 9dabaeeb96 Show where the parsing failed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390814 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 02:33:01 +00:00
Sebastian Bazley f899c178b7 Don't save short eras if they are the same as the long eras
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390811 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 02:18:18 +00:00
Sebastian Bazley 65a6458eaa LANG-832 FastDateParser does not handle unterminated quotes correctly
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390795 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 00:55:31 +00:00
Sebastian Bazley ad72b9f2bf LANG-831 FastDateParser does not handle white-space properly
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390779 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 00:09:15 +00:00
Sebastian Bazley 192b1e1b6b Allow access to parsedPattern for test purposes
Make ParseException text similar to that thrown by SimpleDateFormat

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390778 13f79535-47bb-0310-9956-ffa450edef68
2012-09-27 00:02:58 +00:00
Sebastian Bazley c03f033c1c Trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390722 13f79535-47bb-0310-9956-ffa450edef68
2012-09-26 20:44:16 +00:00
Sebastian Bazley de3d06ff01 Package protection is sufficient here
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390656 13f79535-47bb-0310-9956-ffa450edef68
2012-09-26 18:43:40 +00:00
Sebastian Bazley e568101617 Wrong class name; make line stand out better
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390650 13f79535-47bb-0310-9956-ffa450edef68
2012-09-26 18:37:31 +00:00
Sebastian Bazley d7af943548 LANG-828 FastDateParser does not handle non-Gregorian calendars properly
Use Calendar#getDisplayNames() instead of DateFormatSymbols#getEras()

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390626 13f79535-47bb-0310-9956-ffa450edef68
2012-09-26 18:03:24 +00:00
Sebastian Bazley e582456625 LANG-828 FastDateParser does not handle non-Gregorian calendars properly
Fix bug in Java 7 (Locale.toString() format has changed)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390189 13f79535-47bb-0310-9956-ffa450edef68
2012-09-25 22:12:14 +00:00
Sebastian Bazley 73ea9c43c6 Extract constant
Label output with test case name

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390172 13f79535-47bb-0310-9956-ffa450edef68
2012-09-25 21:46:34 +00:00
Sebastian Bazley eedd1169bf Label output with test case name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1390171 13f79535-47bb-0310-9956-ffa450edef68
2012-09-25 21:46:11 +00:00