5187 Commits

Author SHA1 Message Date
ggregory
577f7b3b54 Add missing Javadoc. 2017-05-25 10:38:30 -07:00
Gary Gregory
8cfc1b1207 Add missing '@Deprecated' annotations. 2017-05-25 09:28:33 -07:00
Gary Gregory
6a688cf36e Make code more readable with less nesting (move block out of else
clause).
2017-05-25 09:25:56 -07:00
Andy Klimczak
ef3015cc99 [LANG-1304] StringUtils method to check for mixed case in string (closes #223) 2017-05-25 16:14:46 +02:00
pascalschumacher
ebe7bb58a5 LANG-1316: Deprecate classes/methods moved to commons-text
Deprecated WordUtils and RandomStringUtils now that commons-text 1.1 was released.
2017-05-25 14:49:46 +02:00
pascalschumacher
8019416d81 ObjectUtils#identityToString(StrBuilder, Object): improve deprecating javadoc comment 2017-05-25 14:46:50 +02:00
pascalschumacher
670bb2e0a1 include checkstyle-suppressions.xml file in source distribution
Now checkstyle can be successfully executed from the source distribution (e.g. as part of the site life-cylce).
2017-05-25 14:00:38 +02:00
pascalschumacher
9f2fe9bb80 LANG-1320: correct id in changes.xml 2017-05-23 00:34:59 +02:00
duncan
7c19a1ff4c Deprecate CharEncoding and direct users to Java 7 classes
Java 7 introduced java.nio.charset.StandardCharsets, which negates the
need for our CharEncoding method. Additionally, the constants in the
class now point to the constants defined in Java 7.

Fixes: LANG-1334
2017-05-22 13:16:29 +01:00
duncan
53def50140 Remove wildcard static import
My last commit accidentally added a wildcard to a static import. This
commit reverses that.
2017-05-19 21:52:27 +01:00
duncan
7587431987 Avoid endless loop printing array with MultilineRecursiveToStringStyle
Previous implementation was causing an endless loop by calling
'super.appendDetail' rather than 'super.reflectionAppendArrayDetail'
when it encountered an array type.

Fixes: LANG-1319
2017-05-19 21:44:28 +01:00
Benedikt Ritter
05e18cc5c1
Remove LANG-1291 from changes.xml since it has been reverted 2017-05-17 10:27:20 -04:00
Benedikt Ritter
796b051f28
Remove annotations for documenting concurrency behavior.
As discussed on the ML, we need more time to figure out the design of
this annotations. So I'm removing them in order to get the next release
out of the door.
2017-05-17 10:21:41 -04:00
Benedikt Ritter
5a87fa172e
Add missing JavaDocs to make Checkstyle happy 2017-05-17 10:14:07 -04:00
Gary Gregory
585b1cb97b [LANG-1332] ImmutableTriple.nullTriple() 2017-05-14 20:41:59 -07:00
Gary Gregory
e1bc286245 [LANG-1331] ImmutablePair.nullPair() Update @SuppressWarnings. 2017-05-14 20:36:31 -07:00
Gary Gregory
776b86e99a [LANG-1331] ImmutablePair.nullPair() 2017-05-14 20:33:59 -07:00
pascalschumacher
340f5f70e9 pom.xml: add goals executed on travis as defaultGoal to make it easy to run the same checks locally 2017-05-04 21:27:40 +02:00
pascalschumacher
1375e931d7 StrBuilder: remove commented-out code 2017-05-04 13:01:38 +02:00
Bruno P. Kinoshita
7ddfc8ae1c Merge branch 'pr/266'
This closes #266

Thanks!
2017-05-01 21:54:51 +12:00
Bruno P. Kinoshita
88da5f49bc LANG-1325: update changes.xml 2017-05-01 21:48:04 +12:00
Bruno P. Kinoshita
af32371247 Merge branch 'pr/265'
This closes #265

Thanks
2017-05-01 21:45:25 +12:00
pascalschumacher
610caab590 LANG-1307: Add getDigits method to StringUtils
add since javadoc tag and changes.xml entry
2017-05-01 11:08:10 +02:00
Arshad Basha
9b3257e4d1 LANG-1307: Added getDigits method to StringUtils (closes #225) 2017-05-01 11:05:45 +02:00
Basha
6d74e8f83e javadocs - fixed faulty samples of isNoneEmpty/isNoneBlank
and added new ones to isAnyEmpty/isNoneEmpty/isAnyBlank/isNoneBlank for better understanding
2017-04-30 00:13:06 +05:30
Basha
9766e22b42 Adding testcase to cover a missing branch. 2017-04-29 20:06:31 +05:30
Basha
ece2f255ee Increase test coverage of ToStringBuilder class to 100% 2017-04-29 19:22:59 +05:30
Allon Mureinik
c8e648b92c HashSetvBitSetTest: use diamond operator (closes #264)
Use Java 7's diamond operator to make the code a tad more elegant, as
done in the rest of the codebase.
2017-04-29 10:48:41 +02:00
pascalschumacher
d61090ab64 LANG-1256: Add JMH maven dependencies.
move checkstyle exclusion of JMH generated classes from pom.xml to checkstyle-suppressions.xml
2017-04-28 21:03:56 +02:00
pascalschumacher
b7cc7a1c7b LANG-1256: Add JMH maven dependencies.
fix checkstyle exclusion on older maven versions
2017-04-28 19:09:14 +02:00
pascalschumacher
331d2f21f9 LANG-1256: Add JMH maven dependencies.
do not run checksytle on classes generated by JMH

remove unnecessary maven-compiler-plugin configuration from benchmark profile
2017-04-28 18:34:29 +02:00
pascalschumacher
e685d847b4 LANG-1110: Implement HashSetvBitSetTest using JMH
(side effect: closes #253, closes #191)
2017-04-28 17:36:58 +02:00
Artem Barger
111fd3f6ee LANG-1256: Add JMH maven dependencies. (closes #182)
In order to provide patch for LANG-1110, required dependency on JMH lib.
Current commit add benchmark profile and ability to run JMH based benchmark by
executing "mvn test -P benchmark" command, moreover it's also possible to
specify exact benchmark name by running "mvn test -P benchmark
-Dbenchmark=benchmark.full.class.name".
2017-04-28 17:30:46 +02:00
pascalschumacher
a060733e63 use Assert#assertFalse instead of Assert#assertTrue with a negated condition 2017-04-22 22:25:52 +02:00
Allon Mureinik
d5be24a126 Use String#contains where possible (closes #263)
Since the project defines a JDK 7 source compatibility, it's safe to use JDK 5's features.
This patch replaces usages of String#indexOf with String#contains where possible to make the code easier to read and maintain.
2017-04-22 22:18:16 +02:00
pascalschumacher
8cafd87c83 LANG-1317: Add MethodUtils#findAnnotation and extend MethodUtils#getMethodsWithAnnotation for non-public, super-class and interface methods
fix bug introduced by last commit
2017-04-21 10:53:17 +02:00
pascalschumacher
314b6b56be LANG-1317: Add MethodUtils#findAnnotation and extend MethodUtils#getMethodsWithAnnotation for non-public, super-class and interface methods
Add changes.xml entry and minimal clean-up.
2017-04-21 10:45:03 +02:00
Yasser Zamani
46007c151e LANG-1317: Adds MethodUtils#findAnnotation and extend MethodUtils#getMethodsWithAnnotation for non-public, super-class and interface methods (closes #261) 2017-04-21 10:44:41 +02:00
pascalschumacher
859224ffad LANG-1167: Add null filter to ReflectionToStringBuilder
Fix/add since javadoc tags, fix checkstyle violations and do other small clean-ups.
2017-04-20 19:15:31 +02:00
Rob Tompkins
0446364ffa LANG-1167: attributing work to Mark Dacek 2017-04-20 11:23:42 -04:00
Rob Tompkins
8147cc5b3d Merge branch 'LANG-1167' of https://github.com/MarkDacek/commons-lang 2017-04-20 11:08:03 -04:00
pascalschumacher
ff6b0ada72 use Validate#isTrue to validate arguments 2017-04-19 21:07:05 +02:00
pascalschumacher
52d6e24d19 use Validate#notNull instead of "throw new NullPointerException" 2017-04-19 20:17:58 +02:00
Emmanuel Bourg
82cc24437f LANG-1272: Added shuffle methods to ArrayUtils 2017-04-19 18:54:23 +02:00
Allon Mureinik
9ceaaeb656 Add FindBugs to Travis CI (closes #262)
This patch copies the FindBugs configuration in pom.xml from the
reporting section to the build section so findbugs can be used as part
of the build process (by using the maven goal findbugs:check).

It then adds this goal to the Travis CI build so that FindBugs
becomes part of the CI, and new patches would be prevented from
introducing new FindBugs errors.
2017-04-19 18:25:04 +02:00
Allon Mureinik
9f7d03f091 Add a default case to switch to appease FindBugs 2017-04-19 18:24:58 +02:00
Allon Mureinik
8069e1c1ce Exclude SF_SWITCH_NO_DEFAULT on FastDatePrinter
FastDatePrinter#appendFullDigits uses a switch case without break
statements.

SF_SWITCH_NO_DEFAULT unfortunately cannot recognize this pattern, and
leave us with no choice but to suppress it.
2017-04-19 18:24:57 +02:00
Allon Mureinik
4d343ccc11 Exclude SF_SWITCH_FALLTHROUGH on FastDatePrinter
FastDatePrinter#appendFullDigits uses a switch statement that
intentionally falls through the cases.
This patch adds a FindBugs suppression for it.
2017-04-19 18:24:57 +02:00
Allon Mureinik
c40dcf6598 Exclude SF_SWITCH_NO_DEFAULT on FastDateParser
FastDateParser#simpleQuote uses a switch case that actually has a
default branch in it, but doesn't use break statements.

SF_SWITCH_NO_DEFAULT unfortunately cannot recognize this pattern, and
leave us with no choice but to suppress it.
2017-04-19 18:24:57 +02:00
Allon Mureinik
3304965840 FindBugs exclude filter for StringUtils
Exclude ES_COMPARING_PARAMETER_STRING_WITH_EQ FindBugs warnings from
StringUtils methods compare(String, String, boolean) and
compareIgnoreCase(String, String, boolean).

The usages of the == operator seem to be intentional optimizations
similar to the usage in indexOfDifference. If this reasoning is ever
overruled, this suppression should be removed.
2017-04-19 18:24:57 +02:00