Commit Graph

1340 Commits

Author SHA1 Message Date
Henri Yandell b57c699e69 Rolling back r489734 - Boolean.valueOf(boolean) only available from JDK 1.4 onwards
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@490161 13f79535-47bb-0310-9956-ffa450edef68
2006-12-25 18:57:37 +00:00
Henri Yandell cf20d13c64 Applying test for LANG-304 and fix to LocaleUtils
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@489749 13f79535-47bb-0310-9956-ffa450edef68
2006-12-22 20:34:37 +00:00
Henri Yandell 848a8144bc Fixed import. Also optimised list.toArray(..) to use new Token[list.size()] so that the passed in array is used and not reflection. Latter reported by FindBugs
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@489740 13f79535-47bb-0310-9956-ffa450edef68
2006-12-22 19:51:19 +00:00
Henri Yandell 5a4594cd37 new Boolean -> Boolean.valueOf. (Reported by FindBugs)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@489734 13f79535-47bb-0310-9956-ffa450edef68
2006-12-22 19:31:28 +00:00
Henri Yandell 37875137e9 Removing the Serializable implements. As far as I can tell, Number has been serializable since at the least Java 1.2. (Reported by FindBugs)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@489733 13f79535-47bb-0310-9956-ffa450edef68
2006-12-22 19:29:53 +00:00
Henri Yandell 03cc852bef Added a test for the under a day range in formatPeriod
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@488929 13f79535-47bb-0310-9956-ffa450edef68
2006-12-20 06:24:00 +00:00
Henri Yandell 4f514d5eb3 More tests, more bugfixes (aka rewrite of the guts).
It's looking much better, the only edge case that throws it for a loop is if things start on the 29th of February in a year. I've hacked it in the day mode, but I'm not sure why I had to do that - however I trust the brute force test to be right in day mode. 
In month mode, it's even trickier as to what the correct answer is. How many months between 29th Feb and 28th of Feb the next year? The answer is 11, or with days included it's 11 months and 28 days. I can't see any reason to define that better, so I'm declaring that law. 

Things are weird if you start on Feb 29 :)

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@488926 13f79535-47bb-0310-9956-ffa450edef68
2006-12-20 06:10:26 +00:00
Henri Yandell 381ed0c0f6 Added new tests (failing) in comments. Improved output for debugging brute force tests.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@488859 13f79535-47bb-0310-9956-ffa450edef68
2006-12-20 00:00:51 +00:00
Henri Yandell 93aa88fded Updated comment
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@488858 13f79535-47bb-0310-9956-ffa450edef68
2006-12-19 23:59:51 +00:00
Henri Yandell 1536077409 Fixing LANG-300 (reported by Jeremy Lemaire) - 1L to 9L incorrectly throw exceptions when passed into NumberUtils.createNumber. Fixed in both the math.NumbersUtils and the deprecated NumberUtils classes.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@488819 13f79535-47bb-0310-9956-ffa450edef68
2006-12-19 21:50:04 +00:00
Henri Yandell 868dd28444 Let a few tab characters slip in - Eclipse wasn't configured yet. Replacing with spaces.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@486525 13f79535-47bb-0310-9956-ffa450edef68
2006-12-13 07:12:38 +00:00
Henri Yandell dd23ae863a More unit tests and bugfixes. The currently failing test is commented out, so more bugfixes to come.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@486523 13f79535-47bb-0310-9956-ffa450edef68
2006-12-13 07:09:24 +00:00
Henri Yandell 9b0b19a916 Applying a unit test for LANG-299 and the fix that Francisco Benavent suggests.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@486377 13f79535-47bb-0310-9956-ffa450edef68
2006-12-12 22:34:39 +00:00
Henri Yandell 5fb6521ab9 More tests added to DurationFormatUtilsTest and discovered bugs fixed in the DurationFormatUtils.formatPeriod method.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@485481 13f79535-47bb-0310-9956-ffa450edef68
2006-12-11 03:33:09 +00:00
Henri Yandell ee4ad2727f Added javadoc to explain the quandry in how to count month/day differences
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@483891 13f79535-47bb-0310-9956-ffa450edef68
2006-12-08 09:05:52 +00:00
Henri Yandell 012998b3d4 Applying max/min for Comparables as supplied by David Karlsen in LANG-291
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@475113 13f79535-47bb-0310-9956-ffa450edef68
2006-11-15 04:14:42 +00:00
Henri Yandell 11a4975580 Bit of an odd unit test, causes trouble under maven-2. So fixing it to make it more like the other tests
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@475111 13f79535-47bb-0310-9956-ffa450edef68
2006-11-15 04:11:55 +00:00
Henri Yandell 5387645b15 Removing @author query
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@471630 13f79535-47bb-0310-9956-ffa450edef68
2006-11-06 04:14:45 +00:00
Henri Yandell d8a6e05b5f Removing my @author tags
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@471626 13f79535-47bb-0310-9956-ffa450edef68
2006-11-06 04:02:09 +00:00
Henri Yandell 1a158281aa Fixng LANG-295 - thisBuf.length calls. There were two of the calls, so I've committed a unit test showing things are broken and a fix in both cases.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@469696 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 23:00:54 +00:00
Henri Yandell 8e52e2169b Fixing #LANG-294. The indexOf method did not take into account the size variable that limited the amount of the buffer that should be looked at.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@469677 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 22:15:00 +00:00
Henri Yandell d8b6f5b5c6 Applying unit test and fix for #LANG-292. Also fixes a couple of problems with the unescape(Writer..) overload that came up
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@469661 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 21:34:03 +00:00
Henri Yandell 8fde2caf64 Adding equals(int[], int[]) style methods to NumberUtils as requested by Paul Benedict in LANG-238
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@467482 13f79535-47bb-0310-9956-ffa450edef68
2006-10-24 21:02:56 +00:00
Henri Yandell 7a003412c6 Adding NumberUtils.max(byte[]) and NumberUtils.min(byte[]) as noted in LANG-289
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@467477 13f79535-47bb-0310-9956-ffa450edef68
2006-10-24 20:51:08 +00:00
Henri Yandell 285fc07c5a Applying optimisation from LANG-287. Thanks to Stepan Koltsov and Holger Hoffstatte.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@467467 13f79535-47bb-0310-9956-ffa450edef68
2006-10-24 20:29:44 +00:00
Henri Yandell 10bdedc90b Taking a stab at adding information on a Lang and Java 5.0 enum comparison
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@466285 13f79535-47bb-0310-9956-ffa450edef68
2006-10-20 22:36:21 +00:00
Henri Yandell fd206080b0 Adding note that using switch is not type-safe
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@466275 13f79535-47bb-0310-9956-ffa450edef68
2006-10-20 22:02:34 +00:00
Henri Yandell 94530f113e Refactored duration tests to make it simpler to add new ones. Added a few edge cases to test the replacement for the += 31 code
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@454427 13f79535-47bb-0310-9956-ffa450edef68
2006-10-09 16:57:28 +00:00
Henri Yandell 25ef9a58cb formetted to formatted - typo fix
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@454426 13f79535-47bb-0310-9956-ffa450edef68
2006-10-09 16:56:49 +00:00
Henri Yandell 1d5c03fac6 Adding a unit test for #LANG-281 and a fix. The fix involves removing the reduceAndCorrect method. It appears that this method was doing sod all - which is worrying as it used to be important. I'm guessing that it was a bad fix for a bug that was then subsequently fixed with other code. I'll create a JIRA issue to create more tests to test out the +31 block of code.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@453818 13f79535-47bb-0310-9956-ffa450edef68
2006-10-07 00:22:42 +00:00
Gary D. Gregory 5e864d372f // comments.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@451406 13f79535-47bb-0310-9956-ffa450edef68
2006-09-29 19:56:41 +00:00
Henri Yandell 320b0b259c Applying patch from Will Pugh in #LANG-268 - Addition of new variants of the join method.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@451394 13f79535-47bb-0310-9956-ffa450edef68
2006-09-29 19:20:03 +00:00
Henri Yandell c1fe78ffa1 Applying -r449108:449370 from the LANG_2_2_X branch to the trunk
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@449372 13f79535-47bb-0310-9956-ffa450edef68
2006-09-24 07:01:49 +00:00
Henri Yandell 58069b3d2a Folding r448432 in from the LANG_2_2_X release branch
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@448433 13f79535-47bb-0310-9956-ffa450edef68
2006-09-21 02:15:43 +00:00
Gary D. Gregory c51cba098e The parameter object is hiding a field from type ToStringBuilder.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@448263 13f79535-47bb-0310-9956-ffa450edef68
2006-09-20 16:53:53 +00:00
Henri Yandell 0d3658d7fb Applied the optimisations to the join(Iterator, x) methods that Stepan Koltsov included in his patch for #LANG-266.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@448015 13f79535-47bb-0310-9956-ffa450edef68
2006-09-19 23:45:14 +00:00
Henri Yandell 57f8eb522e Appying the wished for join(Collection, x) method from Stepan Koltsov in #LANG-266
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@448006 13f79535-47bb-0310-9956-ffa450edef68
2006-09-19 22:55:00 +00:00
Henri Yandell 22f9c428e3 Removing a few lines ending with whitespace. Very trivial commit
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@448002 13f79535-47bb-0310-9956-ffa450edef68
2006-09-19 22:42:11 +00:00
Gary D. Gregory b33bbaa7c8 HashCodeBuilder throws java.lang.StackOverflowError when an object contains a cycle.
https://issues.apache.org/jira/browse/LANG-279

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@447989 13f79535-47bb-0310-9956-ffa450edef68
2006-09-19 21:58:11 +00:00
Henri Yandell 116463ba4f Applying requested fix from Neil Redway in #LANG-262
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@447975 13f79535-47bb-0310-9956-ffa450edef68
2006-09-19 21:20:56 +00:00
Gary D. Gregory d032bda7e5 https://issues.apache.org/jira/browse/LANG-279
HashCodeBuilder throws java.lang.StackOverflowError when an object contains a cycle.

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@447947 13f79535-47bb-0310-9956-ffa450edef68
2006-09-19 20:20:06 +00:00
Henri Yandell 4b25008ec5 #LANG-59 fails under JDK 1.3, so much as with the earlier code in this class, I've modified it so that it only runs with 1.4 and above. A warning is output, and I improved the other warning message at the same time.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@447778 13f79535-47bb-0310-9956-ffa450edef68
2006-09-19 08:18:02 +00:00
Henri Yandell e0c25af499 Added methods back in that were lost in r397016 (my fault). Testing with jardiff again, there are now no removed or changed methods - in keeping with a minor release.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@447139 13f79535-47bb-0310-9956-ffa450edef68
2006-09-17 20:36:53 +00:00
Henri Yandell ba57d261f1 Fixing javadoc example and adding a unit test to prove the example; as reported in #LANG-278
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@442618 13f79535-47bb-0310-9956-ffa450edef68
2006-09-12 15:29:31 +00:00
Henri Yandell 66704164a0 Fixed javadoc typo as mentioned in #LANG-258
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@441929 13f79535-47bb-0310-9956-ffa450edef68
2006-09-10 08:04:17 +00:00
Henri Yandell 462a89b82e Fixed 2nd javadoc bug mentioned in #LANG-277 and added more unit tests to match the javadoc examples
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@438574 13f79535-47bb-0310-9956-ffa450edef68
2006-08-30 18:22:12 +00:00
Henri Yandell 4aa2a0ae6a Fixing license header
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@437556 13f79535-47bb-0310-9956-ffa450edef68
2006-08-28 06:23:26 +00:00
Henri Yandell a5a4f9067a Fixing the ASF copyright and placing it in the NOTICE file
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@437554 13f79535-47bb-0310-9956-ffa450edef68
2006-08-28 06:21:41 +00:00
Gary D. Gregory 447c1b4225 Updated Copyrights to 2006.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@437239 13f79535-47bb-0310-9956-ffa450edef68
2006-08-26 22:07:15 +00:00
Gary D. Gregory 30a547ddc1 Change "Copyright ....-2005" to "Copyright ....-2006"
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@437237 13f79535-47bb-0310-9956-ffa450edef68
2006-08-26 21:52:47 +00:00
Henri Yandell 5290bee389 Added test for StopWatch.toSplitString
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@436673 13f79535-47bb-0310-9956-ffa450edef68
2006-08-25 06:27:02 +00:00
Henri Yandell 62bf5bfcb0 Added unit test to enforce the existence of the empty constructor
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@436670 13f79535-47bb-0310-9956-ffa450edef68
2006-08-25 06:11:47 +00:00
Henri Yandell 95e3fccc98 Set the milliseconds to 0 to stop unit tests sometimes failing. Thanks Jörg
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@433527 13f79535-47bb-0310-9956-ffa450edef68
2006-08-22 05:46:45 +00:00
Stephen Colebourne 07b7795b33 LANG-259 - Fix compareTo to check the type is the same
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@432748 13f79535-47bb-0310-9956-ffa450edef68
2006-08-18 22:21:47 +00:00
Stephen Colebourne d9c6932a6e Ensure classes are the same in Enum.compareTo
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@432703 13f79535-47bb-0310-9956-ffa450edef68
2006-08-18 19:51:26 +00:00
Stephen Colebourne 14172271a3 Change protected to package scope
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@432694 13f79535-47bb-0310-9956-ffa450edef68
2006-08-18 19:31:37 +00:00
Gary D. Gregory 0e2905ef36 Access to enclosing constructors is emulated by a synthetic accessor methods. Increasing its visibility will improve your performance (Eclipse compiler).
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@432025 13f79535-47bb-0310-9956-ffa450edef68
2006-08-16 20:36:35 +00:00
Gary D. Gregory eb68acff59 Make sure this exception code does not depend on Java 1.4 nested exceptions. SVN revision 38990 does not compile with Java 1.3.1.
Compiled with Sun Java 1.3.1_15
Tested with Sun Java 1.3.1_15
Tested with Sun Java 1.4.2_12
Tested with Sun Java 1.5.0_08
All of the above on Windows XP SP2 + patches.

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@432024 13f79535-47bb-0310-9956-ffa450edef68
2006-08-16 20:34:01 +00:00
Stephen Colebourne e6cde16e0a LANG-271 - Change tests now JDK1.6 states the US has two national languages
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430537 13f79535-47bb-0310-9956-ffa450edef68
2006-08-10 21:26:27 +00:00
Stephen Colebourne 5fa96c51b0 Enhance StrSubtstitutor with StringBuffer methods and replaceIn() methods
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430176 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:52:45 +00:00
Gary D. Gregory 051484c740 Unnecessary cast from char to int
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430168 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:21:38 +00:00
Gary D. Gregory 5d915eb6c6 Format method for legibility (added some spaces in expressions.)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430167 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:18:43 +00:00
Gary D. Gregory 06ebaca91c Unnecessary cast from char to int
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430166 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:16:21 +00:00
Gary D. Gregory 2ef7b77769 Remove unused import java.util.Date
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430165 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:14:51 +00:00
Gary D. Gregory 279675745a Remove unused import java.lang.reflect.Field
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430164 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:14:15 +00:00
Gary D. Gregory e3d0e94e71 Unnecessary cast from String[] to String[]
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430163 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:11:03 +00:00
Gary D. Gregory fdc82b0e01 Access to enclosing constructor Enum.Entry() is emulated by a synthetic accessor method. Increasing its visibility will improve your performance (Eclipse compiler).
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430161 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:10:03 +00:00
Gary D. Gregory ebed83b646 Unnecessary cast from Object to Enum.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430157 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:09:11 +00:00
Gary D. Gregory 4d472d6ac6 Access to enclosing constructor Enum.Entry() is emulated by a synthetic accessor method. Increasing its visibility will improve your performance (Eclipse compiler).
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430156 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:08:34 +00:00
Gary D. Gregory e9f981378c Unnecessary cast from Object to Enum.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@430154 13f79535-47bb-0310-9956-ffa450edef68
2006-08-09 22:07:04 +00:00
Stephen Colebourne 53d756b003 VariableFormatter became StrSubstitutor
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429884 13f79535-47bb-0310-9956-ffa450edef68
2006-08-08 23:35:31 +00:00
Stephen Colebourne db95187390 Create StrLookup by extraction from StrSubstitutor
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429881 13f79535-47bb-0310-9956-ffa450edef68
2006-08-08 23:28:45 +00:00
Stephen Colebourne b2b04b2284 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429877 13f79535-47bb-0310-9956-ffa450edef68
2006-08-08 23:25:52 +00:00
Stephen Colebourne df326b1747 Rename variable for JDK1.5 compliance
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429876 13f79535-47bb-0310-9956-ffa450edef68
2006-08-08 23:24:49 +00:00
Stephen Colebourne 927e736103 Give more power to StrSubstitutor subclasses
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429507 13f79535-47bb-0310-9956-ffa450edef68
2006-08-07 23:06:41 +00:00
Gary D. Gregory 9c66638127 Javadoc comments for serialVersionUID.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429439 13f79535-47bb-0310-9956-ffa450edef68
2006-08-07 19:14:31 +00:00
Gary D. Gregory cc407e88e2 The Javadoc comment "Lang version 1.0.1 serial compatibility" is incorrect since these classes came into existance in version 2.1.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429421 13f79535-47bb-0310-9956-ffa450edef68
2006-08-07 18:14:27 +00:00
Gary D. Gregory bacc52875b Adds missing serialVersionUID to Serializable classes.
A note from http://wiki.eclipse.org/index.php/FAQ_Why_does_the_Eclipse_compiler_create_a_different_serialVersionUID_from_javac%3F:

If you don’t explicitly define a serialVersionUID, the language requires that the VM generate one, using some function of all field and method names in the class. The problem is, the compiler generates some synthetic methods that you never see in your source file, and there is no clear specification for how these synthetic method names are generated. Any two compilers are likely to generate different method names, and so the serialVersionUID will be different. Bottom line: Always define the serialVersionUID explicitly in your source files.

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@429413 13f79535-47bb-0310-9956-ffa450edef68
2006-08-07 17:57:25 +00:00
Henri Yandell 2d4e279d19 Line was longer than 120 chars - shortening
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@428644 13f79535-47bb-0310-9956-ffa450edef68
2006-08-04 06:35:51 +00:00
Henri Yandell 807e6d6038 Missing ) in javadoc
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424901 13f79535-47bb-0310-9956-ffa450edef68
2006-07-24 04:49:58 +00:00
Stephen Colebourne 4bfa1f6cb9 Initial commit of StrSubstitutor (VariableFormatter) for review
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424871 13f79535-47bb-0310-9956-ffa450edef68
2006-07-24 01:00:37 +00:00
Stephen Colebourne 8b2b1ba0f2 Copyright dates
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424613 13f79535-47bb-0310-9956-ffa450edef68
2006-07-22 18:12:41 +00:00
Stephen Colebourne cbf6c47104 Link builder to tokenizer properly
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424612 13f79535-47bb-0310-9956-ffa450edef68
2006-07-22 18:10:16 +00:00
Stephen Colebourne d22e559db1 Add toString
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424611 13f79535-47bb-0310-9956-ffa450edef68
2006-07-22 18:09:27 +00:00
Stephen Colebourne 7917cc095b Allow tokenizer state to be adjusted before and after tokenizing
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424608 13f79535-47bb-0310-9956-ffa450edef68
2006-07-22 17:25:38 +00:00
Stephen Colebourne b7b7d7c935 Add method to get all tokens as a list as well as an array
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424596 13f79535-47bb-0310-9956-ffa450edef68
2006-07-22 16:08:25 +00:00
Henri Yandell 9cbf70d822 Adding Niall's fix for LANG-59 - an edge case in date truncation - and his enhancement
for the unit test that was there. 

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@424192 13f79535-47bb-0310-9956-ffa450edef68
2006-07-21 05:47:07 +00:00
Niall Pemberton b9b6b027db Fix for LANG-272 - Minor JavaDoc changes to clean up checkstyle issues
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@420491 13f79535-47bb-0310-9956-ffa450edef68
2006-07-10 11:23:57 +00:00
Stephen Colebourne 6e041ae62f Add serialization version id and javadoc
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419740 13f79535-47bb-0310-9956-ffa450edef68
2006-07-06 23:34:47 +00:00
Stephen Colebourne 7d0e5c002e Layout action methods to match general lang formatting
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419739 13f79535-47bb-0310-9956-ffa450edef68
2006-07-06 23:31:00 +00:00
Stephen Colebourne 3d6bdcae69 Layout getters and setters in pairs to match general lang formatting
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419738 13f79535-47bb-0310-9956-ffa450edef68
2006-07-06 23:27:57 +00:00
Stephen Colebourne 6aa020e6bc Javadoc
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419737 13f79535-47bb-0310-9956-ffa450edef68
2006-07-06 23:24:06 +00:00
Stephen Colebourne c94fd719e7 Reduce scope from public to protected in parser
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419726 13f79535-47bb-0310-9956-ffa450edef68
2006-07-06 22:18:31 +00:00
Henri Yandell 21870c8afa Applying javadoc fixes from Michael Heuer for the stripXxx methods as mentioned in LANG-270
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419651 13f79535-47bb-0310-9956-ffa450edef68
2006-07-06 18:43:02 +00:00
Stephen Colebourne 3a48c43f4d Remove debugging code
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419387 13f79535-47bb-0310-9956-ffa450edef68
2006-07-05 23:49:33 +00:00
Stephen Colebourne 00d021f30e Fix char/Character methods in ArrayUtils
LANG-267

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419386 13f79535-47bb-0310-9956-ffa450edef68
2006-07-05 23:42:43 +00:00
Henri Yandell d9c144d8c3 Fixed a bit of javadoc with bad xhtml
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419177 13f79535-47bb-0310-9956-ffa450edef68
2006-07-05 06:36:02 +00:00
Henri Yandell 3f84c0412c Added hashCode method for inner Token class as recommended by PMD
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419176 13f79535-47bb-0310-9956-ffa450edef68
2006-07-05 06:33:33 +00:00
Henri Yandell 4a453bd132 Minor style fixes suggested by checkstyle
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419174 13f79535-47bb-0310-9956-ffa450edef68
2006-07-05 06:14:13 +00:00
Henri Yandell f5bc3757bb Adding the missing char/Character methods in ArrayUtils, as pointed out (and patched) by Andres Almiray in LANG-267
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@419122 13f79535-47bb-0310-9956-ffa450edef68
2006-07-05 00:04:28 +00:00
Henri Yandell ed0f4c03e1 Removing trace statement
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@418918 13f79535-47bb-0310-9956-ffa450edef68
2006-07-04 05:38:56 +00:00
Henri Yandell 81340ea32f Adding unit test for LANG-59. Sometimes passes, sometimes fails
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@418834 13f79535-47bb-0310-9956-ffa450edef68
2006-07-03 19:21:14 +00:00
Henri Yandell 9c2f070f61 Fixed escaping of backslash-u in javadoc notes for issue reported in LANG-66
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@418833 13f79535-47bb-0310-9956-ffa450edef68
2006-07-03 19:19:51 +00:00
Henri Yandell 7f8f3da321 Added note in javadoc of issue reported in LANG-66
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@418831 13f79535-47bb-0310-9956-ffa450edef68
2006-07-03 19:11:02 +00:00
Stephen Colebourne 1cdf7916ec Fix compilation error
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@418568 13f79535-47bb-0310-9956-ffa450edef68
2006-07-02 10:46:52 +00:00
Stephen Colebourne 5c20e64552 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@418567 13f79535-47bb-0310-9956-ffa450edef68
2006-07-02 10:31:34 +00:00
Henri Yandell b014341965 Adding a test and a fix for LANG-100. This is a bug in which the randomly created String can sometimes be illegal unicode; because the code does not consider when relationships exist between characters. High and low surrogates are now dealt with, but I'm skipping private high surrogates because I can't find out what to do. Need to go plod very slowly through the spec. This site was very useful: http://www.alanwood.net/unicode/private_use_high_surrogates.html
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@417319 13f79535-47bb-0310-9956-ffa450edef68
2006-06-27 00:28:43 +00:00
Henri Yandell cac478de51 Fixing isSmoker attribute name to smoker to match the code example in both of these files - spotted by Corey Tripp in LANG-264
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@416495 13f79535-47bb-0310-9956-ffa450edef68
2006-06-22 23:03:20 +00:00
Henri Yandell d3c425d6f1 Added Collection APIs for the excludeFieldNames as suggested at the end of LANG-226
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@416487 13f79535-47bb-0310-9956-ffa450edef68
2006-06-22 22:20:44 +00:00
Henri Yandell b7d3fd9e4d Committing fix for LANG-140. By reversing the order of field calculation, Yu Peng's bug goes away
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@415317 13f79535-47bb-0310-9956-ffa450edef68
2006-06-19 12:48:08 +00:00
Henri Yandell 30753fb56a Added unit test for LANG-140 - thanks to Yu Peng for the test case
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@415316 13f79535-47bb-0310-9956-ffa450edef68
2006-06-19 12:47:28 +00:00
Henri Yandell baff3dca73 Added containsIgnoreCase method - LANG-263
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@412200 13f79535-47bb-0310-9956-ffa450edef68
2006-06-06 19:35:14 +00:00
Henri Yandell 1aed55020d Exposing the unescapeXml and escapeXml methods that take Writers - LANG-260. A recent thread did point out that there are problems with the concept of escaping Xml as a single method, and instead it needs to be an xml parser that escapes the body and the attribute content differently - however we're obviously not there yet and I don't think making the existing 80/20 good enough code more usable hurts.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@412009 13f79535-47bb-0310-9956-ffa450edef68
2006-06-06 05:23:37 +00:00
Henri Yandell 80e957ecc4 Fixing Javadoc and adding Unit Test for the example for #LANG-261.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@411898 13f79535-47bb-0310-9956-ffa450edef68
2006-06-05 19:37:19 +00:00
Stephen Colebourne 76ca3f317f Javadoc for not escaping apos
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@406082 13f79535-47bb-0310-9956-ffa450edef68
2006-05-13 12:11:13 +00:00
Stephen Colebourne 2bdf879815 Style changes to match rest of class
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@406081 13f79535-47bb-0310-9956-ffa450edef68
2006-05-13 12:10:37 +00:00
Stephen Colebourne fa7c1ed4a4 Javadoc improvement
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@406080 13f79535-47bb-0310-9956-ffa450edef68
2006-05-13 11:37:28 +00:00
Stephen Colebourne e28889038a Javadoc improvement
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@406078 13f79535-47bb-0310-9956-ffa450edef68
2006-05-13 11:36:15 +00:00
Henri Yandell e7918ea4c8 stye to style
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@405325 13f79535-47bb-0310-9956-ffa450edef68
2006-05-09 07:36:31 +00:00
Fredrik Westermarck e8c5f9fbb6 Resolved a few checkstyle issues.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@400092 13f79535-47bb-0310-9956-ffa450edef68
2006-05-05 15:23:31 +00:00
Fredrik Westermarck ea1f4106da Renamed a parameter in the javadoc to reflect the name of the input parameter in the method signature.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@399834 13f79535-47bb-0310-9956-ffa450edef68
2006-05-04 19:29:00 +00:00
Henri Yandell fceff5aa54 Commenting out unit test for 36061 so unit tests pass again
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@399148 13f79535-47bb-0310-9956-ffa450edef68
2006-05-03 05:28:59 +00:00
Henri Yandell 26d2f4a4a2 Committing a failing test (StackOverflow) as a part of #36061
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@399141 13f79535-47bb-0310-9956-ffa450edef68
2006-05-03 04:59:09 +00:00
Henri Yandell 1da2453bc6 Applying the optimisation advised by Paul Benedict in #39368
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@399127 13f79535-47bb-0310-9956-ffa450edef68
2006-05-03 04:33:47 +00:00
Henri Yandell c803367cd0 Fixing the lack of ClassLoader consideration in the compareTo methods of enum.Enum and enums.Enum, along with unit tests, as mentioned on Bugzilla entry #32619 by Kathy Van Stone.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@398812 13f79535-47bb-0310-9956-ffa450edef68
2006-05-02 05:21:00 +00:00
Gary D. Gregory 56541a7485 Fix Javadoc nit: use the active voice.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@398809 13f79535-47bb-0310-9956-ffa450edef68
2006-05-02 04:58:09 +00:00
Gary D. Gregory 5b7e9f59f1 Fix Javadoc nits.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@398808 13f79535-47bb-0310-9956-ffa450edef68
2006-05-02 04:56:12 +00:00
Henri Yandell 048e444c84 Can't believe that Gary meant for the enums.EnumTest to import the enum.ColorEnum class.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@398807 13f79535-47bb-0310-9956-ffa450edef68
2006-05-02 04:54:18 +00:00
Henri Yandell da0e534f15 Archimedes Trajano offered another method for the class
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@398536 13f79535-47bb-0310-9956-ffa450edef68
2006-05-01 06:37:14 +00:00
Henri Yandell 79c3898c90 Adding unit test for #39410. Implementing fix by switching from using Math.log to Integer.toString to figure out the number of digits.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@398530 13f79535-47bb-0310-9956-ffa450edef68
2006-05-01 05:32:43 +00:00
Henri Yandell 2f4408d33c Applying Pete Gieser's enhancement for the CompareToBuilder - a clone of the EqualsBuilder and HashCodeBuilder fixes previously applied. Bugzilla issue #39398
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@397016 13f79535-47bb-0310-9956-ffa450edef68
2006-04-25 23:15:05 +00:00
Henri Yandell 8393f10b79 Adding new excludeFields functionality for EqualsBuilder and HashCodeBuilder, as submitted by Pete Gieser, Bugzilla: #39315
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@396461 13f79535-47bb-0310-9956-ffa450edef68
2006-04-24 07:00:00 +00:00
Henri Yandell fc9b4cc1d8 Added new method to allow work-arounds for Java bug 4071957; as specified in issue 34351
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@395153 13f79535-47bb-0310-9956-ffa450edef68
2006-04-19 06:30:14 +00:00
Henri Yandell 2330a3343c Fixing issue #38569
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394875 13f79535-47bb-0310-9956-ffa450edef68
2006-04-18 07:23:02 +00:00
Henri Yandell 4143a12a0e Test the getXxx methods
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394763 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 19:56:08 +00:00
Henri Yandell f19304cd06 Fixing javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394727 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 16:59:40 +00:00
Henri Yandell 77fdd9eaae Added new class CompositeFormat, as per issue #30184 (http://issues.apache.org/bugzilla/show_bug.cgi?id=30184)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394617 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 06:59:50 +00:00
Henri Yandell 7c4b3e8894 Added note on lack of ' support as detailed in issue #37385 (http://issues.apache.org/bugzilla/show_bug.cgi?id=37385)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394616 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 06:28:14 +00:00
Gary D. Gregory fc55439441 [lang] Using ReflectionToStringBuilder and excluding secure fields.
ASF Bugzilla Bug 36925.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36925

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394615 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 06:18:22 +00:00
Gary D. Gregory 0e85c6e6f1 [lang] Using ReflectionToStringBuilder and excluding secure fields.
ASF Bugzilla Bug 36925.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36925

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394614 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 06:18:07 +00:00
Gary D. Gregory 3eebd98b54 Replace internal use of the magic number -1 with a new constant INDEX_NOT_FOUND. Javadoc changes: Use the active voice "Finds..." (was "Find..."), mention INDEX_NOT_FOUND, and other minor Javadoc nit picking.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394613 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 06:06:52 +00:00
Stephen Colebourne 12491a6801 Javadoc to explain what iterator methods actually do
bug 33609

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394555 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 20:55:25 +00:00
Stephen Colebourne 72f58cfd20 Add methods that operate on a Date object
rfe 33102, from David Bowers

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394553 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 20:29:57 +00:00
Henri Yandell 902706e0d9 Fixed spelling error
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@394265 13f79535-47bb-0310-9956-ffa450edef68
2006-04-15 06:22:56 +00:00
Stephen Colebourne 756cdad67c Add checks for JDK1.6
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@389912 13f79535-47bb-0310-9956-ffa450edef68
2006-03-29 22:27:48 +00:00
Stephen Colebourne d7db8448a1 Handle badly formatted java version numbers without exceptions
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@389911 13f79535-47bb-0310-9956-ffa450edef68
2006-03-29 22:22:32 +00:00
Stephen Colebourne a9f5a6b188 Fix infinite loops leading to OutOfMemory with circular cause chain
bug 37038

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@389900 13f79535-47bb-0310-9956-ffa450edef68
2006-03-29 22:07:53 +00:00
Stephen Colebourne 62a97240a5 Increment, decrement add and subtract methods
from Stephen Putman

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@387322 13f79535-47bb-0310-9956-ffa450edef68
2006-03-20 22:09:44 +00:00
Henri Yandell 976c15d1a3 Finally applying Chas Emerick's improved getLevenshtein implementation
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@385745 13f79535-47bb-0310-9956-ffa450edef68
2006-03-14 06:09:27 +00:00
Gary D. Gregory 80dbd1dab0 Cobertura unit test coverage is now 100%.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@384095 13f79535-47bb-0310-9956-ffa450edef68
2006-03-08 02:25:50 +00:00