Commit Graph

4578 Commits

Author SHA1 Message Date
Steven Caswell 8ac7a8a0f4 corrected a couple of refactoring items missed:
- in testGetThrowableI, replaced construction of explicit class instance with getThrowable abstract method
   - in testPrintPartialStackTrace, replaced class name in startsWith assert from explcit class name to class from getNestable abstract method
   - in testPrintStackTrace, replaced class name in startsWith assert from explicit class name to class name from getThrowableClass abstract method
   - in testPrintStackTrace, replaced class name in indexOf assert from explicit class name to class name from getNestable abstract method
removed extranous commented code


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137010 13f79535-47bb-0310-9956-ffa450edef68
2002-09-11 19:40:14 +00:00
Steven Caswell d1b1006b66 updated javadocs
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137009 13f79535-47bb-0310-9956-ffa450edef68
2002-09-11 19:04:26 +00:00
Steven Caswell 0acf0a6f35 added NestableErrorTestCase to test suite
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137008 13f79535-47bb-0310-9956-ffa450edef68
2002-09-11 18:17:42 +00:00
Steven Caswell 51a06ca201 created
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137007 13f79535-47bb-0310-9956-ffa450edef68
2002-09-11 18:17:23 +00:00
Steven Caswell 31c87c4b23 refactored to share funcrionality from AbstractNestableTestCase
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137006 13f79535-47bb-0310-9956-ffa450edef68
2002-09-11 18:16:53 +00:00
Steven Caswell bb372402d6 created by refactoring NestableException revision 1.3
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137005 13f79535-47bb-0310-9956-ffa450edef68
2002-09-11 18:16:10 +00:00
Stephen Colebourne 6a28a47e51 Updated my personal details
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137004 13f79535-47bb-0310-9956-ffa450edef68
2002-09-08 15:58:02 +00:00
Stephen Colebourne 3189949155 Removed to sandbox ready for 1.0 release
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137003 13f79535-47bb-0310-9956-ffa450edef68
2002-09-06 22:43:55 +00:00
Henri Yandell 5176b8f7c2 Removed stackTrace and getStackTrace. ExceptionUtils has getStackTrace and
stackTrace is only slightly different in that it uses a ByteArrayOutputStream
and not a StringWriter. A change since the beta, but not allowing obvious ones
to happen will be silly.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137002 13f79535-47bb-0310-9956-ffa450edef68
2002-08-31 19:05:32 +00:00
Stephen Colebourne 3e44b6f86f Improve checkstyle report
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137001 13f79535-47bb-0310-9956-ffa450edef68
2002-08-31 11:11:03 +00:00
Stephen Colebourne dfec8f3aed Improve checkstyle report
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137000 13f79535-47bb-0310-9956-ffa450edef68
2002-08-31 10:51:02 +00:00
Daniel Rall 2257a019e4 split(String, String, int): Integrated some good suggested
improvements from John Yu <john@scioworks.com>.


split(String, String): Referenced split(String, String, int) to avoid
maintainence overhead of duplicated JavaDoc.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136999 13f79535-47bb-0310-9956-ffa450edef68
2002-08-30 02:52:54 +00:00
Henri Yandell 763d50ad44 made it run TestCases as well as Tests
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136998 13f79535-47bb-0310-9956-ffa450edef68
2002-08-28 06:02:02 +00:00
Daniel Rall 75fd5eaba1 CAUSE_METHOD_NAMES: Added "getSourceException" to list of method
names.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12043


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136997 13f79535-47bb-0310-9956-ffa450edef68
2002-08-26 16:40:43 +00:00
Daniel Rall 7cc9255061 Extend java.lang.Error rather than Exception.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136996 13f79535-47bb-0310-9956-ffa450edef68
2002-08-26 06:03:57 +00:00
Daniel Rall 2789de54dc Added a second action item for exception package tests.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136995 13f79535-47bb-0310-9956-ffa450edef68
2002-08-26 06:00:32 +00:00
Daniel Rall 9d31e575bd Added action item for exception package tests.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136994 13f79535-47bb-0310-9956-ffa450edef68
2002-08-26 05:59:42 +00:00
Stephen Colebourne c82320c015 Remove StringUtils constructors issue comment
Add todo list


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136993 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 22:18:24 +00:00
Stephen Colebourne f56215806c Add extra system property constants
Add java version methods


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136992 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 22:17:53 +00:00
Daniel Rall 54161dd497 NestableError suggested by Stephen C. Basically a clone of
NestableException.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136991 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 19:18:48 +00:00
Daniel Rall 1f075abae4 Leveraged NestableDelegate.getMessage(String).
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136990 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 19:17:31 +00:00
Daniel Rall 33457071e9 Renamed "cause" private field to "nestable" to better reflect what it
is.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136989 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 19:09:38 +00:00
Daniel Rall 241e24c4d6 getMessage(String): Corrected grammar in JavaDoc.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136988 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 19:02:49 +00:00
Steven Caswell e4125727e7 removed testing of deprecated methods getLength() and indexOfThrowable(int, Class)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136987 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 13:21:24 +00:00
Steven Caswell 1962432bfe removed deprecated methods getLength() and indexOfThrowable(int, Class)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136986 13f79535-47bb-0310-9956-ffa450edef68
2002-08-25 13:20:59 +00:00
Daniel Rall b34534b9d7 ExceptionUtils.getThrowables(Throwable): Switched from concrete
ArrayList local reference to List.

ExceptionUtils.getStackTrace(Throwable): New method for extracting the
text of a stack trace.

ExceptionUtils.getStackFrames(Throwable): Splits an exception's stace
trace into frames.

ExceptionUtils.getStackFrames(String): Splits a stace trace into frames.

NestableDelegate printStackTrace(): Delegate to
printStackTrace(PrintStream) using System.err rather than duplicating
its impl.

NestableDelegate printStackTrace(PrintWriter): Used new name
getStackFrames() method name.

NestableDelegate getStackFrames(Throwable): Renamed decompose() to
this and delegated to ExceptionUtils.getStackFrames(String) for half
of impl.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136985 13f79535-47bb-0310-9956-ffa450edef68
2002-08-24 19:18:50 +00:00
Stephen Colebourne c838670a6f Constrctor made public to enable those who use the class as a Bean
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136984 13f79535-47bb-0310-9956-ffa450edef68
2002-08-23 08:00:26 +00:00
Stephen Colebourne 155943d345 Initial version of SystemUtils for system constants
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136983 13f79535-47bb-0310-9956-ffa450edef68
2002-08-22 22:11:25 +00:00
Daniel Rall 9805a42454 Corrected wording in KNOWN ISSUES section.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136982 13f79535-47bb-0310-9956-ffa450edef68
2002-08-22 20:44:03 +00:00
Daniel Rall a79ebffcb3 Corrected the anchor name for the KNOWN ISSUES section.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136981 13f79535-47bb-0310-9956-ffa450edef68
2002-08-22 20:43:25 +00:00
Daniel Rall 470f6a96a4 Added a KNOWN ISSUES section.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136980 13f79535-47bb-0310-9956-ffa450edef68
2002-08-22 20:42:52 +00:00
Daniel Rall d659fc0d2a Applied squashing of impl of getThrowableCount(Throwable) to
getThrowables(Throwable).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136979 13f79535-47bb-0310-9956-ffa450edef68
2002-08-22 00:04:42 +00:00
Daniel Rall 3ad9e1fcc8 Even shorter impl of getThrowableCount(Throwable) which returns zero
when passed a null argument.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136978 13f79535-47bb-0310-9956-ffa450edef68
2002-08-22 00:03:41 +00:00
Daniel Rall e0800963cc testGetThrowableCount(): New method to get
ExceptionUtils.getThrowableCount() with null argument.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136977 13f79535-47bb-0310-9956-ffa450edef68
2002-08-22 00:00:09 +00:00
Daniel Rall 90b54cc01b o Improved getThrowableCount(Throwable) to return zero when passed a
null argument.

o Added @param JavaDoc for methods added during last commit.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136976 13f79535-47bb-0310-9956-ffa450edef68
2002-08-21 23:57:00 +00:00
Daniel Rall c5a3bf5fc1 Moved the implementations of getThrowableCount(), getThrowables(),
indexOfThrowable(Class), and indexOfThrowable(Class, int) methods to
ExceptionUtils, as suggested by Stephen Colebourne
<scolebourne@btopenworld.com>.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136975 13f79535-47bb-0310-9956-ffa450edef68
2002-08-21 23:52:02 +00:00
Daniel Rall d2b4104bc2 Added the getThrowableCount(Throwable), getThrowables(Throwable),
indexOfThrowable(Throwable, Class), and indexOfThrowable(Throwable,
Class, int) methods factored out of NestableDelegate, as suggested by
Stephen Colebourne <scolebourne@btopenworld.com>.  Added a TODO for
the remaining methods he suggested moving.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136974 13f79535-47bb-0310-9956-ffa450edef68
2002-08-21 23:51:22 +00:00
Daniel Rall 0b3f9dcadc Broke long lines; no functional change.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136973 13f79535-47bb-0310-9956-ffa450edef68
2002-08-21 07:31:54 +00:00
Daniel Rall 10c9649135 o Changed type of "cause" instance field from Nestable to Throwable.
Since implementation of Throwable is already required, this doesn't
change the interface, but does simplify the internals.

o Simplified code in getThrowableCount() method by removing extraneous
null check and extra reference.

o Implemented suggestion by Joachim.Sauer@tp-soft.com to use
ExceptionUtils where Nestable.getCause() was previously called.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136972 13f79535-47bb-0310-9956-ffa450edef68
2002-08-21 07:22:47 +00:00
Daniel Rall 13fecb8398 getCauseUsingWellKnownTypes(Throwable): Collapsed checks for
instanceof NestableException and NestableRuntimeException into single
check for Nestable interface.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136971 13f79535-47bb-0310-9956-ffa450edef68
2002-08-21 07:13:50 +00:00
Stephen Colebourne 3e5b0bd6a0 Change HashCodeUtils to HashCodeBuilder
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136970 13f79535-47bb-0310-9956-ffa450edef68
2002-08-15 22:37:30 +00:00
Daniel Rall da49474963 CAUSE_METHOD_PARAMS: Updated JavaDoc for recent API enchancements.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136969 13f79535-47bb-0310-9956-ffa450edef68
2002-08-14 23:16:55 +00:00
Daniel Rall 7004cc6250 CAUSE_METHOD_NAMES: Updated JavaDoc for last commit.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136968 13f79535-47bb-0310-9956-ffa450edef68
2002-08-14 23:15:17 +00:00
Daniel Rall 99ba8f14d5 CAUSE_METHOD_NAMES: Repurposed CAUSE_METHOD_NAME to be a list of
method names which may yield a wrapped exception.

getCause(Throwable): Now just wraps getCause(Throwable, String[]),
passing in CAUSE_METHOD_NAMES as its list of method names.

getCause(Throwable, String[]): Refactored code extracted from
getCause(Throwable) which looks at a list of method names, plus a
"detail" field.

getCauseUsingMethodName(): Swapped parameter order for consistency.

getCauseUsingFieldName(): New method which introspects fields instead
of methods.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136967 13f79535-47bb-0310-9956-ffa450edef68
2002-08-14 23:08:28 +00:00
Daniel Rall 6fdd16815a getCause(Throwable): Refactored into two methods which are called
internally.  This will allow more cause method names to be added with
ease.

getCauseUsingWellKnownTypes(Throwable): Extracted from getCause().

getCauseUsingMethodName(String, Throwable): Extracted from getCause().


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136966 13f79535-47bb-0310-9956-ffa450edef68
2002-08-14 21:05:19 +00:00
Henri Yandell f7c60dc9f6 Checked back in for consideration in 1.0
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136965 13f79535-47bb-0310-9956-ffa450edef68
2002-08-14 04:51:28 +00:00
Daniel Rall f740ef8893 getCause(Throwable): Added detection of SQLException and its
getNextException() method pointed out by Costin M., Paul Jack, and
Nicola Ken Barozzi.  They've also suggested some more general patterns
which we're discussing the addition of on the
commons-dev@jakarta.apache.org list.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136964 13f79535-47bb-0310-9956-ffa450edef68
2002-08-13 19:58:49 +00:00
Daniel Rall 72200fffeb getCause(Throwable): Adjusted JavaDoc of method to note the return
type of the getCause() method it checks for.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136963 13f79535-47bb-0310-9956-ffa450edef68
2002-08-13 18:19:06 +00:00
Daniel Rall d5525cc4c0 getCause(Throwable): Perform a softer check on the return type of the
argument's getCause() method, doing isAssignableFrom() instead of a
hard memory address comparison.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136962 13f79535-47bb-0310-9956-ffa450edef68
2002-08-13 18:17:39 +00:00
Daniel Rall 6053ce341f Added a utility for examining Throwable objects, as proposed by Costin
<costinm@covalent.net> and Henri Yandell <bayard@apache.org>.  Comes complete
with a full suite of tests for initial functionality.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@136961 13f79535-47bb-0310-9956-ffa450edef68
2002-08-13 18:05:58 +00:00