762641dcdb
Update event tests to JUnit Jupiter
...
Upgrade the tests in the event package to use JUnit Jupiter as
part of the effort to remove the dependency on the Vintage Engine.
While most of these changes are drop-in replacements with no functional
benefit, it is worth noting the tests that test thrown excetpions.
Prior to this patch, this package tested for exceptions in two ways,
neither of which are supported in JUnit Jupiter:
1. With the "expected" argument of the org.junit.Test annotation.
2. With the org.junit.rules.ExpectedException @Rule
Both of these usages were replaced with calls to
org.junit.jupiter.api.Assertions#assertThrows.
2018-10-06 15:05:16 +03:00
dd761382d3
Update concurrent tests to JUnit Jupiter
...
Upgrade the tests in the concurrent package to use JUnit Jupiter as
part of the effort to remove the dependency on the Vintage Engine.
While most of these changes are drop-in replacements with no functional
benefit, there are some non-obvious changes worth mentioning.
Unlike org.junit.Test, org.junit.jupiter.api.Test does not have an
"expected" argument. Instead, an explicit call to
org.junit.jupiter.api.Assertions.assertThrows is used. This call allows
the test to pinpoint the exact statement that is expected to throw the
exception and allows making the tests a bit stricter by preventing
false-positives that could occur if the setup code would throw the
expected exception instead of the statement that was supposed to throw
it.
Another notable change was performed in MemoizerTest.
JUnit Jupiter does not support JUnit 4's runners, and EasyMock has no
equivalent @Extension, so a setup method was added and the mock was
explicitly initialized.
It's also worth noting this is a minimal patch for migrating the
package's tests to Jupiter. There are several tests that can be made
made more elegant with Jupiter's new features, but that work is left
for subsequent patches.
2018-10-06 13:08:06 +03:00
4d5c5a8afd
Replace FindBugs with SpotBugs: Fix source assembly
2018-10-06 10:10:06 +02:00
729adb624d
Update builder tests to JUnit Jupiter
...
Upgrade the tests in the builder package to use JUnit Jupiter as part of
the effort to remove the dependency on the Vintage Engine.
While most of these changes are drop-in replacements with no functional
benefit, it is worth mentioning the change to how expected exceptions
are tested.
Unlike org.junit.Test, org.junit.jupiter.api.Test does not have an
"expected" argument. Instead, an explicit call to
org.junit.jupiter.api.Assertions.assertThrows is used. This call allows
the test to pinpoint the exact statement that is expected to throw the
expcetion and allows making the tests a bit stricter by preventing
false-positives that could occur if the setup code would throw the
expected exception instead of the statement that was supposed to throw
it.
2018-10-06 10:02:58 +02:00
ba7ca7998f
StringUtils: trivial formatting change.
...
This replaces <code> with {@code} primarily as a way to test
INFRA-17094.
2018-10-05 19:47:58 -07:00
69e843890c
(fix) download page pointed to lang3 in uri
2018-09-23 12:17:28 -04:00
ec6a15696f
Adding TODO to index.xml for 3.9 release
2018-09-23 12:04:37 -04:00
9e79655f67
RELEASE-NOTES: fix template 3.9+ targets java 8
2018-09-22 17:48:13 -04:00
83329ef669
(fix) RELEASE-NOTES.txt on master to look like 3.8.1 dist
2018-09-22 17:45:29 -04:00
77f875110a
Tagging commons-lang3-3.8.1 from RC1
...
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEtuc9hOpPzEcWYIclP6rSzV7LsxQFAlumrW8ACgkQP6rSzV7L
sxQgcA//dWX1C1n526Z34UgI5OSGxE+pT3L6Imny33gDRbEdUuBAtX7nsU04OEpB
YGZuwAvaZ6CVgcEha43T0t6qD5mMb+btNTauqY116PRhEqSIDLJBgapZNcKLj1gA
sR1SXY87VCQHcWO/tjUtL2yC+Js++KwowFX1If9MpByV46PqTr7e/FKrzYB2ocsD
BaDCgQTcJWoLb6XHXlsSUrGO92AeDS8O2oa+6eIDstH0qzC4vKKFhpGGGRhI0SrP
99rwzpBfNljxe3oVDIU+JIjAuNvepb1+WrtOTbwu2GEz0PMS4KkvB9cvBeyGJeM+
cQXccZ34VU2Ony9TNDUfJEwdeoWbZWw8ib4ijThhufIPmiOU2QpHhhcQ2K8iK8CJ
lCnDLQDtjZHpo5308nEW4EuGi31uzRZePDNubrQcHpqjdmVcrs93jOJuK8K8zIpn
DG3ly1E6fItVILFIhUzXyFJ20qPtSmhQmjNPuX3/4b3Pmx1MDc/b0u3mxDjc/ADq
OWFcT5f2N//StnR58ZSDqw4vdOo0l5EyhSr70nMnMfk3p1XsbU1IOb3lNZouXjWr
T6Ckwyz2CWo+wAS9U72EvRzaim/SQz+2E8sscu1gLwE067YFmY9lPGGFpFliJO6Y
NwAkKq2uR+aemvWok5GmwDPastv7U59gJDJCLZ7SrTlHNpIyh6E=
=Hha5
-----END PGP SIGNATURE-----
Updates for 3.8.1 release
2018-09-22 17:31:24 -04:00
eb5b11a25c
Prepare 3.8.1 release
2018-09-19 11:09:49 -04:00
ae9b31285e
LANG-1419: Restore BundleSymbolicName for OSGi
2018-09-19 10:51:19 -04:00
c3b38a3ba1
Merge branch 'nested-validate-test'
2018-09-06 22:02:03 +02:00
89f3d989e0
Convert util class convention tests to @Nested test
2018-09-06 20:21:18 +02:00
0b14928ee4
Convert tests for Validate.isAssignable overloads to @Nested test
2018-09-06 20:19:14 +02:00
3e58ab33b9
Convert tests for Validate.isInstanceOf overloads to @Nested test
2018-09-06 20:16:47 +02:00
5445f22747
Convert tests for Validate.exclusiveBetween overloads to @Nested test
2018-09-06 20:08:24 +02:00
eabf1aaa25
Convert tests for Validate.inclusiveBetween overloads to @Nested test
2018-09-06 19:50:59 +02:00
6e9f406aac
Convert tests for Validate.finite overloads to @Nested test
2018-09-06 19:38:45 +02:00
4077b57f6d
Convert tests for Validate.notNaN overloads to @Nested test
2018-09-06 19:29:01 +02:00
8912be8a88
Convert tests for Validate.matchesPattern overloads to @Nested test
2018-09-06 18:14:59 +02:00
f6f8e5dbed
Convert tests for Validate.validIndex overloads to @Nested test
2018-09-06 15:41:44 +02:00
74c24ad194
Move constructor test to top
2018-09-06 15:18:34 +02:00
ad97f20202
Convert tests for Validate.noNullElements overloads to @Nested test
2018-09-06 15:17:13 +02:00
c0779f42c7
Convert tests for Validate.notBlank overloads to @Nested test
2018-09-06 14:59:59 +02:00
d784612d0d
Convert tests for Validate.notEmpty overloads to @Nested test
2018-09-06 14:30:29 +02:00
d3f2a89ba2
Convert tests for Validate.notNull overloads to @Nested test
2018-09-06 10:16:26 +02:00
7e440785d9
Use @ParameterizedTest to iterate over available locales
2018-09-05 15:58:27 +02:00
aad2db8b12
Convert tests for Validate.isTrue overloads to @Nested test
2018-09-05 14:26:25 +02:00
bce28f99f3
JUnit 5 tests do not need to be public
2018-09-05 13:50:12 +02:00
65a7b5d3b9
LANG-1416: Add changes.xml entry
2018-09-04 16:15:27 +02:00
2bcf86d8af
LANG-1416: Update ValidateTest to JUnit 5 API
2018-09-04 15:08:37 +02:00
54f8d3c02a
LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
2018-09-04 11:16:55 +02:00
3ee9cc8400
Add missing spaces
2018-08-26 18:18:10 +02:00
bff752134b
Use build in methods for comparing numerical values
2018-08-26 17:32:02 +02:00
9fb4f47f35
Identical catch blocks can be combined
2018-08-26 17:25:29 +02:00
f013141f60
Explicit type parameters can be removed
2018-08-24 15:37:52 +02:00
33bd834964
Convert JavaDoc license headers to block comments
2018-08-23 19:06:59 +02:00
88b951a227
Merge branch 'LANG-1415'
2018-08-23 18:39:39 +02:00
b4609c81e4
LANG-1415: Update Java Language requirement to 1.8
2018-08-23 08:25:27 +02:00
ce178d8e87
(fix) Add missing @Test annotation
2018-08-22 04:07:44 -07:00
d1e72ebede
LANG-1411: Add changes.xml entry and @since tags.
...
This fixes #342 from GitHub. Thanks to Alexander Tsvetkov.
2018-08-20 19:01:46 +02:00
44e32205a6
Merge branch 'LANG-1411'
2018-08-20 18:59:21 +02:00
c2bd8be862
(changes) add 3.9 area
2018-08-20 08:54:02 -04:00
baa410493b
(site) fix RELEASE-NOTES-3.8.txt java 5.0 -> 7.0
2018-08-20 08:47:32 -04:00
2a11642511
LANG-1411: Add empty checks to ObjectUtils
2018-08-17 09:02:46 +03:00
9801e2fb9f
Add RELEASE-NOTES-3.8.txt to the site
2018-08-15 21:32:37 -04:00
6a02b5337b
(fix) typographical error in JIRA number LANG-1290 -> LANG-1390
2018-08-15 21:16:41 -04:00
a1ac807dab
Update release date to RC build date
2018-08-15 08:21:45 -04:00
14e7f8db27
Preparing 3.8
2018-08-14 22:08:20 -04:00
4f4e2b064e
LANG-1408: add final to method params
2018-08-14 15:53:09 -04:00
b31877a460
LANG-1408: Rounding utilities for converting to BigDecimal
2018-08-14 15:48:19 -04:00
08aa21f921
LANG-1408: add toDouble(BigDecimal), toDouble(BigDecimal, double)
2018-08-14 10:44:30 -04:00
1deca6672d
LANG-1402: thanks Mark
2018-08-09 15:53:50 -04:00
0bca64d75e
Merge branch 'LANG-1402' of https://github.com/MarkDacek/commons-lang
2018-08-09 15:15:38 -04:00
3dbc944812
clarified Javadoc
2018-08-08 21:47:43 -04:00
a36c903d4f
[LANG-1405] Remove checks for java versions below the minimum supported
...
one. Closes #338 .
2018-07-27 17:20:48 -06:00
2cc5243808
LANG-1401: Typo in JavaDoc for lastIndexOf
...
Add changes.xml entry (actual fix was done in 69a8ef3189
2018-07-27 19:38:57 +02:00
0db3d81c93
Do not link to deprecated commons-text classes.
2018-07-26 23:31:40 +02:00
fa66bd94e0
Prepare for release 3.8.
2018-07-16 07:58:27 -06:00
3a3cec01d5
Prepare for release 3.8.
2018-07-16 07:54:20 -06:00
0020780ddd
Prepare for release 3.8.
2018-07-15 23:00:39 -06:00
2cad60b6c2
removed ArrayUtils.get
2018-07-14 15:42:14 -04:00
1cec9a6fe5
Raw Types
2018-07-13 15:05:35 +01:00
ec2ec77492
LANG-1402: more comment proofreading
2018-07-08 19:35:13 -04:00
96f3ab8410
LANG-1402: comment proofread
2018-07-08 19:20:48 -04:00
7721302ae5
LANG-1402: refactored to return default value on negative index
2018-07-08 19:11:19 -04:00
625fbccaa9
LANG-1402: Fixed comment
2018-07-08 19:06:48 -04:00
2521d9619f
refactored to Generics and added isArrayIndexValid
2018-07-08 16:15:54 -04:00
9379d0d36a
LANG-1402: added get methods to ArrayUtils
2018-07-07 13:04:19 -04:00
f56931c176
LANG-1380: FastDateParser too strict on abbreviated short month symbols
2018-07-02 20:39:24 -07:00
ae6a24dd43
replaces primitive comparison with x.compare() where x is a wrapper class of the primitive
2018-06-25 22:26:08 +02:00
4aa4291ffc
removes redundant '+' sign
2018-06-25 22:05:44 +02:00
77febcfa8d
flips the order of conditional expressions and 'if' statements whose conditions were negated
2018-06-25 21:21:02 +02:00
b610707cd0
removes unnecessary class reference of static method calls which are declared in the same class
2018-06-20 14:28:10 +03:00
214cc7fd59
replaces 'size() == 0' and 'length() == 0' with 'isEmpty()'
2018-06-20 13:05:02 +03:00
96260205dc
deletes redundant 'new' expression in constant array creation
2018-06-20 12:44:10 +03:00
e767af7e7e
removes unchecked exceptions declared in 'throws' clause
2018-06-20 09:03:40 +03:00
8e8b8e05e4
The the patrol.
2018-06-16 15:46:28 -06:00
d9f1b897a2
Fraction#getFraction: Replace "the the" with "the" in javadoc
2018-06-16 23:12:03 +02:00
89cd538eaf
LANG-1392: Methods for getting first non empty or non blank value
...
Improve javadoc
2018-06-08 19:34:32 +02:00
672cd146f2
LANG-1392: add changes.xml entry
2018-06-08 18:12:51 +02:00
152e5d48ea
LANG-1392: Methods for getting first non empty or non blank value ( closes #325 )
2018-06-08 18:10:23 +02:00
9ea0063bc9
(doc) Fix typos in classes of tuple package
2018-06-08 15:12:46 +03:00
6850d88880
Fix javadoc errors reported by Java 11.
2018-05-28 10:55:30 +02:00
b933f55e58
StringUtils: fix checkstyle violation
2018-05-27 22:17:47 +02:00
ae7bef343f
[LANG-1238] Fix typo.
2018-05-22 10:30:29 -06:00
2bb197d3d4
[LANG-1290] StringUtils.join() with support for List<?> with
...
configurable start/end indices. Fix XML.
2018-05-22 10:27:24 -06:00
81ee0d062c
Extract method.
2018-05-22 09:00:55 -06:00
f4a262df52
[LANG-1290] StringUtils.join() with support for List<?> with
...
configurable start/end indices. Extract constant.
2018-05-22 08:57:50 -06:00
96cb498f9b
[LANG-1290] StringUtils.join() with support for List<?> with
...
configurable start/end indices. Reuse constant.
2018-05-22 08:55:54 -06:00
a5391bb34c
Format nit.
2018-05-22 08:46:07 -06:00
9de7e1a1b4
[LANG-1290] StringUtils.join() with support for List<?> with
...
configurable start/end indices.
2018-05-22 08:41:35 -06:00
87937b2e71
[LANG-1290] StringUtils.join() with support for List<?> with
...
configurable start/end indices.
2018-05-22 08:40:55 -06:00
09ef69c5b5
[LANG-1397] WordUtils.wrap throws StringIndexOutOfBoundsException when
...
wrapLength is Integer.MAX_VALUE.
2018-05-18 11:44:37 -06:00
bd4066eba8
[LANG-1238] Add RegexUtils class instead of overloadinh methods in
...
StringUtils that take a regex to take precompiled Pattern. Use 120 chars
per line.
2018-05-17 17:18:45 -06:00
54acb6e10f
[LANG-1238] Add RegexUtils class instead of overloadinh methods in
...
StringUtils that take a regex to take precompiled Pattern. Sort methods.
2018-05-17 17:16:08 -06:00
bcc4f82a7a
[LANG-1238] Add RegexUtils class instead of overloadinh methods in
...
StringUtils that take a regex to take precompiled Pattern. Sort methods.
2018-05-17 17:15:19 -06:00
44b6d2ead5
[LANG-1238] Add RegexUtils class instead of overloadinh methods in
...
StringUtils that take a regex to take precompiled Pattern. Javadoc
tweaks.
2018-05-17 17:14:36 -06:00
7129c43b08
[LANG-1238] Add RegexUtils class instead of overloadinh methods in
...
StringUtils that take a regex to take precompiled Pattern.
2018-05-17 17:12:46 -06:00
5d4916933d
Fix broken XML.
2018-05-17 15:15:28 -06:00
5fa073a5ca
Typo: 'JavaDoc' -> 'Javadoc'.
2018-05-15 12:58:01 -06:00
3fadfdd69f
LANG-1396 - JsonToStringStyle does not escape string names
2018-05-10 13:08:07 +01:00
e7d16c2762
LANG-1395 - JsonToStringStyle does not escape double quote in a string
...
value
2018-05-09 18:28:19 +01:00
362dd935f8
Javadoc correction to agree with code
2018-05-09 09:47:25 +01:00
69a8ef3189
(doc) remove invalid example of `lastIndexOf` ( closes #327 )
...
- `StringUtils.lastIndexOf("aabaabaa", "ba", 2) = -1` is invalid; moreover, example below is applied to the same arguments, but gets another (correct) result
2018-04-29 09:37:57 +02:00
38cf0c68d5
[LANG-1391] Improve Javadoc for StringUtils.isAnyEmpty(null).
2018-04-26 12:07:11 -04:00
58a8f12b44
[LANG-1394] org.apache.commons.lang3.SystemUtils should not write to
...
System.err.
2018-04-22 10:45:43 -06:00
7c441e87cf
[LANG-1393] Add API SystemUtils.String getEnvironmentVariable(final
...
String name, final String defaultValue). Fix @since tag.
2018-04-20 10:15:32 -06:00
efba54d35f
[LANG-1393] Add API SystemUtils.String getEnvironmentVariable(final
...
String name, final String defaultValue).
2018-04-20 08:55:32 -06:00
8e3ec1722b
[LANG-1391] Improve Javadoc for StringUtils.isAnyEmpty(null).
2018-04-18 12:26:02 -06:00
e51bd89201
SerializatoinUtilsTest assertArraysEquals ( closes #321 )
...
Utilize assertArraysEquals to compare arrays instead of boiler plate
implementing it with a for loop.
This change both makes the test code cleaner and improves the output
in case of an assertion failure by showing all the differences between
the two arrays instead of stopping at the first.
2018-04-04 09:32:29 +02:00
1415c9a2a6
SerializationUtilsTest expected exceptions
...
Use the expected argument of the @Test annotation instead of
boiler-plate implementing this behavior with a try-catch-fail
construct in order to clean up the code and make it more obvious to
the reader.
2018-04-04 09:32:22 +02:00
aff0fae2ec
SerializationUtilsTest identity assertions
...
Replaced calls to assertTrue with a != condition with calls to
assertNotSame calls.
This change retains the functionality, but will produce a more
detailed error message in case the assertion fails.
It also (arguably) makes the test code more straight-forward.
2018-04-04 09:32:22 +02:00
9901bf98e4
Some reflection tests must account for classes files being instrumented
...
by Jacoco.
2018-03-29 13:27:45 -06:00
17f9d22f33
Some reflection tests must account for classes files being instrumented
...
by Jacoco.
2018-03-29 13:26:59 -06:00
56b7ae44f9
Update test for Java 11 EA.
2018-03-29 11:52:05 -06:00
06be0be267
Next release will be this year one can only hope.
2018-03-29 08:59:37 -06:00
8b62c114cf
[LANG-1385] NumberUtils.createNumber() throws
...
StringIndexOutOfBoundsException instead of NumberFormatException.
2018-03-10 18:16:24 -07:00
9c886bd4a1
Predictable randomness in shuffle tests. Closes #317 from Allon
...
Murienik's PR https://github.com/apache/commons-lang/pull/317
2018-03-09 15:06:03 -07:00
1a8d276278
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-lang
2018-03-08 16:29:05 +01:00
53bb395988
Track changes.
2018-03-08 16:28:17 +01:00
357fe13788
Redundant specification of type arguments.
2018-03-08 08:19:25 -07:00
50ce8c44e1
LANG-1384: Version "11" is available.
2018-03-08 13:54:31 +01:00
cb686673a7
LANG-1384: Fix NPE when version >= 11
...
The fix is likely to be insufficient if the version naming scheme changes.
2018-03-08 13:17:00 +01:00
bb3fe2a379
another formatting nit, one or the other is already null
2018-02-14 13:01:51 -05:00
2c0429aabd
formatting nit, one or the other is already null
2018-02-14 12:56:44 -05:00
2e9f3a8014
LANG-1356: Add bypass option for classes to recursive and reflective EqualsBuilder
...
Patch supplied by Yathos UG
2018-02-11 20:43:05 +01:00
2ce4049407
LANG-1060: NumberUtils.isNumber assumes number starting with Zero is octal
...
Add additional tests (closes #314 )
2018-02-11 14:55:21 +01:00
60412131f3
LANG-1364: ExceptionUtils#getRootCause(Throwable t) should return t if no lower level cause exists
...
This makes the behavior of getRootCause consistent with getRootCauseMessage and getRootCauseStackTrace.
2018-02-11 14:19:56 +01:00
3a4ac35798
harmonize since javadoc tags content (remove "(Commons )Lang")
2018-02-11 14:08:40 +01:00
7eb47fd85e
CloneFailedException: remove "@since upcoming" from constructors javadoc, because these constructors were added in the same version as the class itself (3.0)
2018-02-11 14:03:33 +01:00
6684a76317
add changes.xml entry for "LANG-1060: NumberUtils.isNumber assumes number starting with Zero"
2018-02-11 12:09:19 +01:00
c8e61afdb8
LANG-1060: NumberUtils.isNumber assumes number starting with Zero is octal ( closes #313 )
2018-02-11 12:08:33 +01:00
c3b1fefbad
NumberUtils#isCreatable: remove java 6 only code, as commons-lang requires at java 7+ now
2018-02-11 11:49:44 +01:00
f50ec5e608
LANG-1375: add changes.xml entry
2018-01-20 17:02:55 +13:00
d575057852
LANG-1375: defaultString(str) reuses defaultString(str, defaultStr)
2018-01-20 13:12:33 +11:00
e72654ed5a
SystemDefaultsSwitch: fix javadoc code example
2018-01-14 11:24:59 +01:00
e843239cf9
LANG-1372: Add ToStringSummary annotation
...
add changes.xml entry
2018-01-12 18:31:10 +01:00
f5ebb9a649
LANG-1372: Add ToStringSummary annotation ( closes #281 )
2018-01-12 18:28:27 +01:00
63f11e9dc1
LANG-1352: EnumUtils.getEnumIgnoreCase and isValidEnumIgnoreCase methods added
...
add since javadoc tags and changes.xml entry
2018-01-12 17:59:09 +01:00
0b70b01a9f
LANG-1352: EnumUtils.getEnumIgnoreCase and isValidEnumIgnoreCase methods added ( closes #286 )
2018-01-12 17:58:38 +01:00
c614fbcc79
LANG-1374: fix logic in isJsonArray method of JsonToStringStyle
2018-01-04 22:15:08 +13:00
f5a9effebd
Don't use single letter variable names.
2017-12-21 09:01:21 -07:00
5fb74a6618
Rename parameter 't' to 'thread'.
2017-12-21 08:57:29 -07:00
6dfc3e6403
Don't need internal ivar name for a boolean to carry a "Flag" postfix.
2017-12-21 08:47:30 -07:00
49a876cb1c
Don't need internal ivar name for a boolean to carry a "Flag" postfix.
2017-12-21 08:46:30 -07:00
4661422633
LANG-1371: Fix TypeUtils.parameterize to work correctly with narrower-typed varargs array
...
add changes.xml entry
2017-12-20 17:20:54 +01:00
d8ec011d77
LANG-1371: Fix TypeUtils.parameterize to work correctly with narrower-typed varargs array ( closes #307 )
2017-12-20 17:18:08 +01:00
bfb43d3fe2
StringUtils#getDigits : Fix a small mistake in javadoc description. ( closes #310 )
2017-12-20 16:58:07 +01:00
Allon Mureinik
pascalschumacher
Eitan Adler
Rob Tompkins
Benedikt Ritter
Alexander Tsvetkov
Rob Tompkins
MarkDacek
Gary Gregory
Gary Gregory
Sebb
Chas Honton
Igor Curdvanovschi
Jeff Nelson
amseager
Jochen Schalanda
Takanobu Asanuma
Oleg Chubaryov
Roman Golyshev
Allon Mureinik
Gilles Sadowski
Rob Tompkins
Piotr Kosmala
Bruno P. Kinoshita
Jerry Zhao
Sergio Ozaki
Ruslan Sibgatullin
Dmitry Ovchinnikov
nbarban