Commit Graph

5253 Commits

Author SHA1 Message Date
Andrii 914844e1b2 EnumUtilsTest: fix spaces between enum constants (closes #241) 2017-02-22 23:22:31 +01:00
Allon Mureinik 8767cd4f1a Fix FastDateParser#getStrategy(char, int, Calendar) javadoc (closes #242)
The javadoc refers to a formatField parameter, which the method doesn't
have.
Reading the description and the method's code, this documentation
clearly refers to the f parameter.

This patch fixes the javadoc and aligns it with the method's parameters.
2017-02-22 23:16:03 +01:00
pascalschumacher 4bd982d1a1 LANG-1312: LocaleUtils#toLocale does not support language followed by UN M.49 numeric-3 area code (closes #239) 2017-02-21 21:13:45 +01:00
Allon Mureinik a6443e146f Remove redundant semicolons from enums (closes #240)
While enums allow ending the member list in a semicolon(;), it's
redundant. Some enums in the codebase use a semicolon in the end, and
some do not.

This patch standardizes the codebase's enum and cleans up the code by
removing these semicolons.
2017-02-21 19:58:49 +01:00
Allon Mureinik a64153a371 Validate's String.format without arguments (closes #238)
While calling String.format("some string") without any additional
arguments is not technically wrong, it's redundant, as it just
returns the same string.

Removing these calls and just using the string instead both cleans up
the code and offers a (very slight) performance gain.
2017-02-20 23:18:50 +01:00
Tobias Gesellchen 954ade4c1a (doc) Use the full alphabet for the well-known example text.
This change adds the missing `s` character.

Signed-off-by: Tobias Gesellchen <tobias@gesellix.de>
2017-02-18 14:49:42 +01:00
pascalschumacher 1661e5519c LANG-1311: TypeUtils.toString() doesn't handle primitive and Object arrays correctly
apply patch by Aaron Digulla
2017-02-17 18:32:32 +01:00
Sebb 30c85ad053 Use StringBuilders instead of StringBuffers
(A couple of instances were overlooked)
This fixes #236
2017-02-16 18:59:01 +00:00
Allon Mureinik ce1bd5785d Remove redundant casts (closes #235)
Remove redundant casts throughout the codebase to make it cleaner and easier to read.
2017-02-14 23:10:56 +01:00
pascalschumacher 5bdf0a938a ObjectUtilsTest#testIdentityToStringAppendable: fail test if IOException is thrown 2017-02-14 22:59:12 +01:00
pascalschumacher aaeb4c621a ObjectUtilsTest: remove commented-out code 2017-02-14 22:51:45 +01:00
Bruno P. Kinoshita b715d18f09 Merge branch 'pr/228'
This closes #228 thanks @andyklimczak
2017-02-12 10:34:31 +13:00
Bruno P. Kinoshita 21810dc920 Merge branch 'pr/234'
This closes #234 thanks @mureinik
2017-02-12 10:28:26 +13:00
Allon Mureinik 07811434b7 ObjectUtilsTest: collapse empty catch blocks
This patch employs Java 7's syntax to catch multiple exceptions in
the same block with the | operator to make ObjectUtilsTest's code
cleaner and easier to read.
2017-02-11 21:35:16 +02:00
Sebastian Kürten 04a2a4b456 Fix a few broken @literal tags (closes #233)
The Javadoc of SystemDefaultsSwitch contains some broken @literal tags.
Instead of {@literal @} to insert a '@' into the HTML, {@literal@}
without the space is used, which does not work.
2017-02-05 12:46:43 +01:00
Sebastian Kürten ebcef2d16a Fix a number of Javadoc typos (closes #232) 2017-02-03 20:00:04 +01:00
peleghila ab25f67348 Fix copy-paste error in CharUtilsTest#testIsAsciiPrintable_char (closes #230)
Line 238 has copy paste error from testIsAscii_char
2017-02-01 20:03:48 +01:00
stonio 857e0de492 Update RELEASE-NOTES.txt fix typo "vom" (closes #229)
Replace `vom` by `from`.
2017-01-26 18:56:51 +01:00
Andy Klimczak 00bf35cdd9 Increase test coverage
CharRangeTest -> 100%
RandomUtilsTest -> 100%
StringEscapeUtilsTest -> 100%
StringUtils -> 99%
2017-01-21 02:50:50 -05:00
pascalschumacher 86a082e8be MultilineRecursiveToStringStyle: made private field indent static 2017-01-20 18:48:13 +01:00
pascalschumacher bd7788b384 JsonToStringStyle: improve private constant name and remove wrong comment 2017-01-20 18:46:34 +01:00
pascalschumacher 044367419d JsonToStringStyle: private field FIELD_NAME_PREFIX can be static 2017-01-20 18:39:16 +01:00
pascalschumacher 928e74f73f LANG-1295: ArrayUtils.toArray(T... items) has unsafe use of varargs
remove SafeVarargs annotation
2017-01-20 17:49:11 +01:00
pascalschumacher 7e60537820 LANG-1296: ArrayUtils.addAll() has unsafe use of varargs
remove SafeVarargs annotation
2017-01-20 17:47:20 +01:00
pascalschumacher d0e2bfc466 deprecate SystemUtils#LINE_SEPARATOR in favor of java.lang.System#lineSeparator 2017-01-20 17:41:03 +01:00
Bruno P. Kinoshita aab4018d8f Merge branch 'pr/227'
This closes #227

Thanks to Andrii (@Abrasha)!
2017-01-08 20:00:34 +13:00
Andrii e8d861359a + AbstractExceptionTest
+ CircuitBreakingExceptionTest
+ CloneFailedExceptionTest
+ cover specific cases
2017-01-05 21:53:01 +02:00
duncan 021e4dfb50 Ignore eclipse-cs generated file
The checkstyle plugin for Eclipse creates a .checkstyle file, which
should never be checked in to git. Added to .gitignore.
2016-12-22 15:46:08 +00:00
pascalschumacher 7cf5e01c2a remove commons-io test dependency 2016-12-20 10:01:04 +01:00
pascalschumacher c636539836 ExtendedMessageFormatTest: remove code for java versions below 1.4 2016-12-18 17:49:27 +01:00
pascalschumacher cc2d70e2ed add changes.xml entry for LANG-1301: Moving apache-rat-plugin configuration into pluginManagement 2016-12-18 16:18:49 +01:00
pascalschumacher 5738b2943c run rat check before cobertura on travis to make it more visible in case it fails 2016-12-18 16:01:50 +01:00
pascalschumacher 15f01c99c1 run rat check on travis 2016-12-18 15:56:25 +01:00
pascalschumacher 6cfee3d0e5 move apache-rat configuration from site to plugin-management sections, so that it also applies when "mvn apache-rat:check" is run
thanks to Karl Heinz Marbaise for the patch
2016-12-18 15:48:26 +01:00
duncan 363cbf7908 Improve test coverage of utility method. 2016-12-18 10:49:25 +00:00
duncan 600eb9eb99 LANG-1299 - Add method for converting string to an array of code points 2016-12-18 09:53:26 +00:00
duncan 855a523855 Corrected Javadoc @link tag. 2016-12-18 08:47:21 +00:00
duncan 657704627b Suppress warning about vararg usage. 2016-12-18 08:32:39 +00:00
Gary Gregory 8c7687b9ff [LANG-1297] SystemUtils.getHostName() API. Get test passing on Jenkins. 2016-12-14 15:31:53 -08:00
Gary Gregory a9f350eb94 [LANG-1297] SystemUtils.getHostName() API. Javadoc. 2016-12-14 14:28:40 -08:00
Gary Gregory bd5cc81ed7 [LANG-1297] SystemUtils.getHostName() API. 2016-12-14 14:22:34 -08:00
duncan cdfb2aa1e1 Improve description of alphabetic and alphanumeric. 2016-12-14 20:46:10 +00:00
duncan 7f7fa03eac Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-lang.git 2016-12-14 06:27:30 +00:00
duncan f643b4fa93 Fix for LANG-1286: RandomStringUtils random method can overflow... 2016-12-14 06:27:04 +00:00
Martin 35c27d025b Fix javadoc in isAnyNotBlank 2016-12-12 23:39:55 +01:00
duncan f13d18cff3 Javadoc change to address LANG-872.
Javadocs for append(Object[],Object[]) updated to indicate it only
compares the contents of the arrays, not the type of the arrays.
2016-12-12 15:25:18 +00:00
duncan 31fcd3bd8b Removed accidental commit of failing test case. 2016-12-12 15:14:58 +00:00
duncan 5556118ad1 Squashed deprecation warnings in test code. 2016-12-12 15:11:39 +00:00
duncan 795fe5d869 Added new vararg methods to insert values into an array at an index.
This implements LANG-660. This commit also deprecates the add() methods
that inserted a single value into an array at an index.
2016-12-12 14:00:19 +00:00
duncan 0136218fa3 Fixed typo in Javadoc. 2016-12-01 19:54:48 +00:00