Commit Graph

17 Commits

Author SHA1 Message Date
Allon Mureinik be31b6eb24 Fix typo stateme->statement
This closes #288
2017-09-21 22:48:03 +12:00
Allon Mureinik 466244ce3d Clean up findbugs exclusions for old XYZRange classes (closes #287)
Commit 56e830a removed all the old XYZRange classes from
org.apache.lang3.math, and left only the generic Range<T> class.

This patch removes the left-over findbugs exclusions for those
classes.
2017-09-20 22:10:16 +02:00
Allon Mureinik 8069e1c1ce Exclude SF_SWITCH_NO_DEFAULT on FastDatePrinter
FastDatePrinter#appendFullDigits uses a switch case without break
statements.

SF_SWITCH_NO_DEFAULT unfortunately cannot recognize this pattern, and
leave us with no choice but to suppress it.
2017-04-19 18:24:57 +02:00
Allon Mureinik 4d343ccc11 Exclude SF_SWITCH_FALLTHROUGH on FastDatePrinter
FastDatePrinter#appendFullDigits uses a switch statement that
intentionally falls through the cases.
This patch adds a FindBugs suppression for it.
2017-04-19 18:24:57 +02:00
Allon Mureinik c40dcf6598 Exclude SF_SWITCH_NO_DEFAULT on FastDateParser
FastDateParser#simpleQuote uses a switch case that actually has a
default branch in it, but doesn't use break statements.

SF_SWITCH_NO_DEFAULT unfortunately cannot recognize this pattern, and
leave us with no choice but to suppress it.
2017-04-19 18:24:57 +02:00
Allon Mureinik 3304965840 FindBugs exclude filter for StringUtils
Exclude ES_COMPARING_PARAMETER_STRING_WITH_EQ FindBugs warnings from
StringUtils methods compare(String, String, boolean) and
compareIgnoreCase(String, String, boolean).

The usages of the == operator seem to be intentional optimizations
similar to the usage in indexOfDifference. If this reasoning is ever
overruled, this suppression should be removed.
2017-04-19 18:24:57 +02:00
Benedikt Ritter 9106f4ed5a Define Findbugs exlucde for internally used map key class
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1671628 13f79535-47bb-0310-9956-ffa450edef68
2015-04-06 18:16:37 +00:00
Benedikt Ritter d27df61ab5 Make usage of default charset explicit and remove FindBugs exclusion. Kudos to Sebb for spotting this.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1536835 13f79535-47bb-0310-9956-ffa450edef68
2013-10-29 18:16:29 +00:00
Benedikt Ritter c650b17f50 If using more than one method name, the method elements have to be wrapped in an Or element
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1536490 13f79535-47bb-0310-9956-ffa450edef68
2013-10-28 19:14:11 +00:00
Benedikt Ritter 8b0cc5d9c4 Add exclusions where FindBugs seems to be unable to figure out that we acutally have a default statement
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1536487 13f79535-47bb-0310-9956-ffa450edef68
2013-10-28 19:06:16 +00:00
Benedikt Ritter b35b6c5762 Add FindBugs exclusion for replacement of deprecated method
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1535124 13f79535-47bb-0310-9956-ffa450edef68
2013-10-23 19:15:54 +00:00
Benedikt Ritter c62447ce10 Add FindBugs exclusion for toString(byte[], String)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1531445 13f79535-47bb-0310-9956-ffa450edef68
2013-10-11 22:04:50 +00:00
Luc Maisonobe 67704d8e76 filtered out false positive findbugs warnings
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1090828 13f79535-47bb-0310-9956-ffa450edef68
2011-04-10 16:53:39 +00:00
Henri Yandell fdbdd0174a lang -> lang3 (LANG-563)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@889228 13f79535-47bb-0310-9956-ffa450edef68
2009-12-10 12:09:00 +00:00
Henri Yandell cbc1dc8c5a Hooking up findbugs exclude file and updating the exception cases
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775427 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 08:16:29 +00:00
Sebastian Bazley c957e2394e Two more false positives
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755447 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 23:51:21 +00:00
Sebastian Bazley c57a47f9cc Start collecting Findbugs false positives
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755389 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 20:52:42 +00:00