5884 Commits

Author SHA1 Message Date
Allon Mureinik
a4adb41259 Use assertThrows in FunctionsTest (closes #404)
Use JUnit Jupiter's elegant assertThrows method instead of the
boilerplate pattern of try-fail-catch to assert an exception was
thrown.
2019-02-09 12:44:06 +01:00
Eitan Adler
6b7a848010 [ToStringBuilderTest] clean up after some old issues
- Remove code to handle old JDK 6 bugs
- Fix a mis-ordered assertEquals
- Remove a deprecated call to Character's constructor
2019-02-09 02:08:32 -08:00
Allon Mureinik
bfa50b3edf Clean up floating point assertions (closes #402)
JUnit Jupiter 5.4.0 supports deltas of 0 when asserting double and
float equalities.
This patch utilizes these new assertEquals methods and removes the
hack of using assertTrue with an == statement that was needed in older
JUnit versions.
2019-02-08 19:54:17 +01:00
Allon Mureinik
2273b6e44e Upgrade JUnit depedency to 5.4.0 (closes #402)
Upgrade the JUnit dependency to the latest available 5.4.0.

Note that JUnit simplified its artifacts, and now it contains a
single, simple org.junit:junit-jupiter artifact.
2019-02-08 19:53:20 +01:00
pascalschumacher
17bbe77262 Skip javadoc on Java 11 to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module." 2019-02-08 19:50:44 +01:00
pascalschumacher
43badd4dfa Merge remote-tracking branch 'origin/pr/403' 2019-02-08 19:41:40 +01:00
Allon Mureinik
fc6a392b7c Fix javadoc errors in Functions.java 2019-02-08 20:08:56 +02:00
Allon Mureinik
f12cfc8d4e FunctionsTest whitespaces
Use four spaces instead of a tab as per the projcet's Checkstyle
rules.
2019-02-08 19:39:01 +02:00
Allon Mureinik
19a5a09b09 FunctionsTest whitespace after comma
Add a space after the comma as per the project's Checkstyle rules
2019-02-08 19:37:38 +02:00
Allon Mureinik
5e315d1ac9 FunctionsTest method references
Use method references instead of lambda expression to clean up the
code and comply to the project's Checkstyle rules.
2019-02-08 19:36:29 +02:00
Allon Mureinik
76a243c587 FunctionTest redundant constructor modifier
Remove redundant public modifiers from inner classes constructors as
per the project's Checkstyle rules.
2019-02-08 19:34:40 +02:00
Allon Mureinik
95926eb5d9 FunctionsTest imports
Clean up FunctionsTest's imports as per the project's Checkstyle
rules.
2019-02-08 19:32:39 +02:00
Allon Mureinik
c5eadb1c6d Functions.java whitspaces
Replace tabs with four spaces, as per the project's Checkstyle rules.
2019-02-08 19:30:35 +02:00
Allon Mureinik
962e529984 Add spaces after commas in Functions.java
Add spaces after commas as per the project's Checkstyle rules.
2019-02-08 19:29:06 +02:00
Allon Mureinik
028c9ec70c Remove unused generic argument from Functions#tryWithResources 2019-02-08 19:25:27 +02:00
Allon Mureinik
b08c92e75d Fix Javadoc issues in Functions 2019-02-08 19:23:40 +02:00
Allon Mureinik
f7fae53aec Functions' interfaces modifiers
Remove the redundant public modifier from the inner interfaces in
Functions, as per the Checkstyle policy of the project.
2019-02-08 18:18:40 +02:00
Allon Mureinik
1c48eb0d8b Add license to FunctionsTest.java
Add a license header to FunctionsTest.java to make the rat maven task
pass.
2019-02-08 17:47:29 +02:00
Benedikt Ritter
ef1480a505
Add missing Apache license header 2019-02-08 16:42:31 +01:00
Jochen Wiedmann (jwi)
2ebc17ba3f Added Functions.tryWithResources. 2019-01-29 11:42:07 +01:00
Jochen Wiedmann (jwi)
11d9eb47a4 Adding the Functions class as a helper for dealing with Java 8 Lambdas. 2019-01-23 14:59:25 +01:00
Bruno P. Kinoshita
b00e65686e Fix checkstyle issues in new test code 2019-01-08 20:01:56 +13:00
Bruno P. Kinoshita
104cc28105 Merge branch 'pr-379'
This closes pr #379

Thanks to @apirom9
2019-01-08 19:48:34 +13:00
Apirom Na Nakorn
bf77678673 add test use ImmutablePair class with java.util.HashMap and java.util.TreeMap 2019-01-08 19:48:22 +13:00
pascalschumacher
f7c62b29c9 Update spotbugs-maven-plugin to version 3.1.10 2019-01-05 22:51:18 +01:00
pascalschumacher
ef18f3ea26 Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on. (closes #396) 2019-01-05 22:13:24 +01:00
RahulNagekar
cee7cc6b64 Refactoring junits of JsonToStringStyle 2018-12-21 01:05:50 +05:30
RahulNagekar
92e63fb3c8 Adding junits for JsonToStringStyle
Signed-off-by: RahulNagekar <rahul.nagekar1@gmail.com>
2018-12-21 00:42:34 +05:30
pascalschumacher
e0a5a4b5b6 Update to JaCoCo 0.8.2 with works Java 11+. 2018-12-20 14:48:34 +01:00
pascalschumacher
a48d045709 LANG-1427: Add SystemUtils.isJavaVersionAtMost(JavaVersion)
Fix checkstyle violations.
2018-12-20 14:26:28 +01:00
Gary Gregory
e21cb463c0 Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-lang.git 2018-12-10 17:48:30 -07:00
Gary Gregory
a410aab651 [LANG-1427] Add API
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JavaVersion)
2018-12-10 17:48:06 -07:00
RahulNagekar
c368955343 Add additional tests for StandardToStringStyle (closes #390) 2018-12-02 19:59:59 +01:00
pascalschumacher
37ba8d3981 Update to JUnit version 5.3.2 2018-12-02 14:11:09 +01:00
pascalschumacher
aae1a0a681 Travis: Stop building with Java 9 and 10, as these are superseded by Java 11 and not supported anymore. 2018-11-24 12:47:38 +01:00
pascalschumacher
60b8f18e46 Update Spotbugs Maven Plugin to version 3.1.8 2018-11-20 21:38:15 +01:00
pascalschumacher
5cdac9cfd5 Make whitespace use around generic tokens consistent and add a checkstyle rule to enforce it. 2018-11-19 22:05:18 +01:00
pascalschumacher
07f537120f Make whitespace use before tokens consistent and add a checkstyle rule to enforce it. 2018-11-19 22:05:11 +01:00
pascalschumacher
89cbfa54b0 Make whitespace use after tokens consistent and add a checkstyle rule to enforce it. 2018-11-19 22:04:35 +01:00
Bruno P. Kinoshita
c4d0dbcb56 Merge branch 'pr-380'
This closes #380 thanks to @oorijsonar
2018-11-03 13:50:48 +13:00
Uri
e1618fa232 fix javadoc typo 2018-11-02 16:48:04 -07:00
pascalschumacher
a668a47981 Update JUnit Pioneer to version 0.3.0 2018-11-02 21:05:14 +01:00
pascalschumacher
5ccbfeb86f Update maven-spotbugs-plugin to version 3.1.7 2018-11-02 21:01:51 +01:00
Gary Gregory
0fcd4ce92a Update EasyMock from 3.6 to 4.0 to fix testing on Java 11. 2018-10-28 09:11:14 -06:00
pascalschumacher
97ade3f6e3 Use surefire plugin version from parent POM. 2018-10-26 19:51:07 +02:00
pascalschumacher
b278ac8c39 Remove unused test code 2018-10-26 19:49:58 +02:00
pascalschumacher
5afe35c024 LANG-1422: Add null-safe StringUtils.valueOf(char[]) to delegate to String.valueOf(char[])
Fix checkstyle violations
2018-10-26 19:48:28 +02:00
Gary Gregory
c70e05ae41 [LANG-1422] Add null-safe StringUtils.valueOf(char[]) to delegate to
String.valueOf(char[])
2018-10-25 08:52:48 -06:00
pascalschumacher
b60ca26a23 Travis: Remove Oracle JDK 10 because it is no longer available 2018-10-17 08:55:05 +02:00
Allon Mureinik
3609993fb5 Clean up assertions (closes #376)
Use built-in assertion methods provides by
org.junit.jupiter.api.Assertions instead of reimplementing the same
logic with assertTrue and assertFalse.

Note that JUnit Jupiter 5.3.1 does not support deltas of 0 for
assertEquals(double, double, double) and
assertEquals(float, float, float), so these usages of assertTrue were
left untouched, and will be addressed when JUnit Jupiter 5.4, that
addresses this isssue, will be available (see
https://github.com/junit-team/junit5/pull/1613 for details).
2018-10-13 21:10:54 +02:00