Commit Graph

25 Commits

Author SHA1 Message Date
pascalschumacher 5cdac9cfd5 Make whitespace use around generic tokens consistent and add a checkstyle rule to enforce it. 2018-11-19 22:05:18 +01:00
pascalschumacher 07f537120f Make whitespace use before tokens consistent and add a checkstyle rule to enforce it. 2018-11-19 22:05:11 +01:00
pascalschumacher 89cbfa54b0 Make whitespace use after tokens consistent and add a checkstyle rule to enforce it. 2018-11-19 22:04:35 +01:00
Oliver Siegmar 67830fe249 make checkstyle config more portable (no maven coupling) 2017-09-09 08:51:49 +02:00
Benedikt Ritter 309b34f057
Make sure placement of curly braces is consistent 2017-06-06 22:14:47 +02:00
Benedikt Ritter 3a818ed6a8
Prevent redundant modifiers 2017-06-06 16:11:45 +02:00
Benedikt Ritter 8a8b8ec8d2
Make sure modifiers are in JLS order 2017-06-06 15:26:38 +02:00
Benedikt Ritter d0650d1a2f
Make sure no illegal imports (e.g. sun.*) are used 2017-06-06 15:15:39 +02:00
Benedikt Ritter 1da8ccdbfe
Make sure lines in files don't have trailing white spaces and remove all trailing white spaces 2017-06-06 15:12:06 +02:00
Benedikt Ritter fa91c1b286
Make sure files end with a new line 2017-06-06 15:05:02 +02:00
Benedikt Ritter f21c32a059
Don't allow package-info.html 2017-06-06 15:02:09 +02:00
Allon Mureinik c121f03d5c Upgrade maven-checkstyle-plugin to 2.17
This patch upgrades maven-checkstyle-plugin to the latest available
version, 2.17.

This is done in order to consume a fix for checkstyle wrongfully
reporting an error if the @return javadoc tag was used in an
annotation type, as it is in Guarded (line 36).

Note that checkstyle has removed the RedundantThrows check (see
discussion at https://github.com/checkstyle/checkstyle/issues/473),
so it was removed from the project's checkstyle.xml configuration.
2017-03-12 17:41:50 +01:00
Allon Mureinik 1f8479a84b Apply JavaDoc checkstyle only to public methods
The defacto style of the project requires Javadoc for public methods
only, but the checkstyle Javadoc check defaults to requiring them even
for private methods, generating 46 errors.

This patch sets the checkstyle Javadoc check's scope to public to clean
up the checkstyle report so it can be enabled in the CI.

If we wish to reset the check to a laxer scope, the aforementioned
errors should be fixed first.
2017-03-12 17:41:49 +01:00
Bruno P. Kinoshita ee19f8247c Fix checkstyle xml by closing module tag 2017-03-09 22:03:56 +13:00
Allon Mureinik e5ed4ffe5d Checkstyle for long literals (closes #249)
PR #248 corrected all the long literals to use the upper case L
notation.
This patch finishes the job as per the discussion there, and adds a
checktysle check to ensure no code that introduces long literals with
lowercase l are introduced.
2017-03-05 13:05:47 +01:00
Benedikt Ritter 881c5fa3d2 Remove empty lines 2015-10-17 11:00:02 +02:00
Gary D. Gregory ec502d9839 Update Maven plugins:
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1164313 13f79535-47bb-0310-9956-ffa450edef68
2011-09-02 00:36:44 +00:00
Phil Steitz a164864059 Dropped line length check.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1090933 13f79535-47bb-0310-9956-ffa450edef68
2011-04-11 04:23:33 +00:00
Niall Pemberton 790140111d Upgrade reporting plugin versions and fix issues upgrading maven-checkstyle-plugin from version 2.3 to 2.6
maven-checkstyle-plugin 2.4 onwards uses Checkstyle 5.0 (upgraded from Checkstyle 4.4). Checkstyle 5.0 is not 100% backwardly compatible with release 4.4 and the following changes need to be made to make it work. See the Release Notes for details of incompatible changes and fixes here:
    http://checkstyle.sourceforge.net/releasenotes.html



git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1005380 13f79535-47bb-0310-9956-ffa450edef68
2010-10-07 09:23:59 +00:00
Henri Yandell a5a4f9067a Fixing the ASF copyright and placing it in the NOTICE file
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@437554 13f79535-47bb-0310-9956-ffa450edef68
2006-08-28 06:21:41 +00:00
Gary D. Gregory 513d128773 Change "Copyright ....-2005" to "Copyright ....-2006"
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@437238 13f79535-47bb-0310-9956-ffa450edef68
2006-08-26 21:54:21 +00:00
Gary D. Gregory 5e18fd65ff Updated copyright statements for 2005.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@161244 13f79535-47bb-0310-9956-ffa450edef68
2005-04-14 06:16:36 +00:00
Gary D. Gregory 73c82134a1 Make this work with the current release of Maven, 1.0-rc2.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137832 13f79535-47bb-0310-9956-ffa450edef68
2004-03-25 15:10:31 +00:00
Gary D. Gregory f58370a13f Apply Apache License Version 2.0 by following the instructions at http://www.apache.org/dev/apply-license.html.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137801 13f79535-47bb-0310-9956-ffa450edef68
2004-02-18 23:13:37 +00:00
Phil Steitz 3c712f6fbb replacement for checkstyle.properties
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@137649 13f79535-47bb-0310-9956-ffa450edef68
2003-08-22 05:01:03 +00:00