Commit Graph

2219 Commits

Author SHA1 Message Date
Henri Yandell 226801cebc Removing unused imports
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775425 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 07:27:40 +00:00
Henri Yandell 5e4deef918 Couple more reports - CPD and JavaNCSS because... why not?
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775422 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 07:06:17 +00:00
Henri Yandell 373624c4f0 Removing unused import
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775420 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 06:32:52 +00:00
Henri Yandell bb7775388f Fixing javadoc, unused import
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775411 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 03:46:27 +00:00
Henri Yandell e9b32bccfa Fixing javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775410 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 03:44:06 +00:00
Henri Yandell 7c7fea8957 Commiting my variant patch from LANG-336 to Henrik Maryn's genericizing code
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775048 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 07:34:17 +00:00
Henri Yandell ed49378250 Genericizing per LANG-336. Removed two lines in the test that were trying to build a to string up to a class that was not in the hierarchy. The compiler now protects against this.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@775045 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 07:33:02 +00:00
Henri Yandell 7a75f11d58 Start of changes file - LANG-484
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772557 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 09:00:26 +00:00
Henri Yandell a60f59ac93 Type doesn't need to be ArrayList, and updating for loops
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772553 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 08:42:01 +00:00
Henri Yandell 7d744b2267 Genericizing excludeFieldList variable and updating for loop to foreach - LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772551 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 08:41:42 +00:00
Henri Yandell ca3a3baa65 Genericizing excludeFieldList variablle - LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772548 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 08:31:48 +00:00
Henri Yandell bab78e92bb Type doesn't need tobe ArrayList
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772544 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 08:28:13 +00:00
Henri Yandell 97631fd612 Adding generics - LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772541 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 08:12:25 +00:00
Henri Yandell a373714575 Updating to java 5 foreach - LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772540 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 08:11:38 +00:00
Henri Yandell 3d2c545acb Updating to java 5 foreach - LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@772539 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 08:10:59 +00:00
Henri Yandell 73ac4a0289 Applying Hendrik Maryns' generics changes for Entities + Validate from LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@770891 13f79535-47bb-0310-9956-ffa450edef68
2009-05-02 05:20:35 +00:00
Henri Yandell 8b7956d27f Applying a set of updates for new Java features from Hendrik Maryns in LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@770105 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 08:08:48 +00:00
Henri Yandell f89a50b528 Simplifying for loop
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@770101 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 07:50:19 +00:00
Henri Yandell c58bbaaa4b Applying Hendrik Maryns' generics changes for Mutable classes from LANG-336
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@770100 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 07:40:02 +00:00
Henri Yandell 0904ecd4fa Removing NumberUtils.compare(float,float) and NumberUtils.compare(double,double). These are now foud in Float and Double respectively. Keeping the unit tests, but pointing to the JDK methods as a regression. LANG-492
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@770078 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 06:03:16 +00:00
Henri Yandell 574493d175 Improving getPackageName(Class) to be class.getPackage().getName(). This method then becomes one of the null-protection only methods... which are imo struggling for justification
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@763561 13f79535-47bb-0310-9956-ffa450edef68
2009-04-09 08:38:53 +00:00
Henri Yandell 9adc537013 Removing BooleanUtils.toBooleanObject(boolean) as JDK 1.4 provides Boolean.valueOf(boolean) - even if we ignore autoboxing. LANG-492
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@763559 13f79535-47bb-0310-9956-ffa450edef68
2009-04-09 08:34:47 +00:00
Sebastian Bazley 07c1324202 Generic fix
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@756852 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 01:00:21 +00:00
Sebastian Bazley 6cf9814780 ObjectUtils.max(null,null) requires casts to agree with signature; likewise min
Also use actual Date objects rather than generic Comparable.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@756844 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 00:17:43 +00:00
Sebastian Bazley 50bc6d35b0 Revert JCIP depend to compile+optional now fix has been added for OSGI bundling
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@756817 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 23:54:37 +00:00
Niall Pemberton d080d78f3a Add instruction to not export the "net.jcip.annotations" - this causes the maven-bundle-plugin to output an "Ignore-Package" statement which I assume will have no negative impact
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@756756 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 20:53:38 +00:00
Sebastian Bazley b9e3bc72d5 LANG-495 - add generics for max and min
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@756634 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 17:10:39 +00:00
Sebastian Bazley b9ad25bcfc Change JCIP dependency scope to "provided" to prevent transitive dependencies
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@756531 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 15:30:40 +00:00
Sebastian Bazley b8a8046723 Test min and max are reflexive; test both nulls
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755579 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 12:33:03 +00:00
Sebastian Bazley 6349c0d097 Generics
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755573 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 12:05:47 +00:00
Sebastian Bazley c957e2394e Two more false positives
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755447 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 23:51:21 +00:00
Sebastian Bazley e8512544ed LANG-369 - must use fixed object as lock target
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755391 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 20:54:52 +00:00
Sebastian Bazley c57a47f9cc Start collecting Findbugs false positives
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755389 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 20:52:42 +00:00
Sebastian Bazley 86d0d0e216 Ensure calculation is performed as a long
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755387 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 20:51:58 +00:00
Sebastian Bazley dc3d41bac5 Attempt to stop annotation jar becoming transitive dependency
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755357 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 19:15:32 +00:00
Sebastian Bazley 8338eb2544 Specify encoding to use; Use better JUnit; Add JCIP annotation depend
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@755269 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 14:40:26 +00:00
Sebastian Bazley 654fb75d80 Genericize some more classes
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754810 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 03:35:20 +00:00
Sebastian Bazley 950def5b6f Genericize some more classes
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754808 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 02:11:38 +00:00
Sebastian Bazley 9aa057fea0 Add test with empty string array
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754806 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 02:11:08 +00:00
Sebastian Bazley e0914986c4 Byte.valueOf() is definitely faster than new Byte()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754805 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 02:08:49 +00:00
Sebastian Bazley 909dd44949 Byte.valueOf() is definitely faster than new Byte()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754804 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 02:06:18 +00:00
Henri Yandell 64dfea8d86 Fixing javadoc to not reference removed method
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754782 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 22:36:07 +00:00
Sebastian Bazley f3a2199a83 Genericize
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754686 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 16:27:34 +00:00
Sebastian Bazley c06b74202d Genericize; remove invalid Javadoc reference
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754682 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 16:11:01 +00:00
Sebastian Bazley ebfe3a9c1d Genericize; add final qualifier to private var
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754678 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 15:27:48 +00:00
Sebastian Bazley d85758d688 LANG-438 - replace links to Javadoc that was deleted with the deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754677 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 15:06:03 +00:00
Sebastian Bazley 524e74451b Don't expose static arrays to potential writes, even for testing
Add package protected read method instead

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754653 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 11:18:30 +00:00
Henri Yandell 9aaab6cabb This should bring code coverage to 100% for MutableBoolean
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754611 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 03:43:40 +00:00
Henri Yandell f4a99655f0 Bringing the code coverage to 100% :) Constructor wasn't being tested.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754610 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 03:41:15 +00:00
Sebastian Bazley 8a51b94300 Generify LocaleUtils and its Test class
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754603 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 02:50:18 +00:00