diff --git a/src/main/java/org/apache/commons/math/analysis/solvers/BaseSecantSolver.java b/src/main/java/org/apache/commons/math/analysis/solvers/BaseSecantSolver.java index 9dfc6da25..d446869dd 100644 --- a/src/main/java/org/apache/commons/math/analysis/solvers/BaseSecantSolver.java +++ b/src/main/java/org/apache/commons/math/analysis/solvers/BaseSecantSolver.java @@ -25,7 +25,7 @@ import org.apache.commons.math.exception.MathInternalError; * Base class for all bracketing Secant-based methods for root-finding * (approximating a zero of a univariate real function). * - *

Implementation of the {@link RegulaFalsiSolver Regula Falsi}, and + *

Implementation of the {@link RegulaFalsiSolver Regula Falsi} and * {@link IllinoisSolver Illinois} methods is based on the * following article: M. Dowell and P. Jarratt, * A modified regula falsi method for computing the root of an @@ -38,8 +38,8 @@ import org.apache.commons.math.exception.MathInternalError; * BIT Numerical Mathematics, volume 12, number 4, pages 503-508, Springer, * 1972.

* - *

The {@link SecantSolver secant} method is not a - * bracketing method so it is not implemented here. It has a separate + *

The {@link SecantSolver Secant} method is not a + * bracketing method, so it is not implemented here. It has a separate * implementation.

* * @since 3.0 diff --git a/src/main/java/org/apache/commons/math/analysis/solvers/BracketedUnivariateRealSolver.java b/src/main/java/org/apache/commons/math/analysis/solvers/BracketedUnivariateRealSolver.java index 0a186359f..0376b93a4 100644 --- a/src/main/java/org/apache/commons/math/analysis/solvers/BracketedUnivariateRealSolver.java +++ b/src/main/java/org/apache/commons/math/analysis/solvers/BracketedUnivariateRealSolver.java @@ -57,9 +57,9 @@ public interface BracketedUnivariateRealSolver 0 && fHi < 0) || (fLo < 0 && fHi > 0); + return (fLo >= 0 && fHi <= 0) || (fLo <= 0 && fHi >= 0); } /** @@ -354,8 +356,8 @@ public class UnivariateRealSolverUtils { } /** - * Check that the endpoints specify an interval and the function takes - * opposite signs at the endpoints. + * Check that the endpoints specify an interval and the end points + * bracket a root. * * @param function Function. * @param lower Lower endpoint. diff --git a/src/site/xdoc/userguide/analysis.xml b/src/site/xdoc/userguide/analysis.xml index 5d7aeeb46..daecf80b0 100644 --- a/src/site/xdoc/userguide/analysis.xml +++ b/src/site/xdoc/userguide/analysis.xml @@ -158,7 +158,7 @@ return bogus values. There will not necessarily be an indication that the computed root is way off the true value. Secondly, the root finding problem itself may be inherently ill-conditioned. There is a - "domain of indeterminacy", the interval for which the function has + "domain of indeterminacy", the interval for which the function has near zero absolute values around the true root, which may be large. Even worse, small problems like roundoff error may cause the function value to "numerically oscillate" between negative and positive values. @@ -178,7 +178,7 @@ accuracy. Using a solver object, roots of functions are easily found using the solve methods. These methods takes a maximum iteration count maxEval, a function f, - and either two domain values, min and max or a + and either two domain values, min and max, or a startValue as parameters. If the maximal number of iterations count is exceeded, non-convergence is assumed and a ConvergenceException exception is thrown. A suggested value is 100, which should be plenty, given that a @@ -187,7 +187,7 @@ ill-conditioned problems is to be solved, this number can be decreased in order to avoid wasting time. bracketed + href="../apidocs/org/apache/commons/math/analysis/solvers/BracketedUnivariateRealSolver.html">Bracketed solvers also take an allowedSolutions enum parameter to specify which side of the final convergence interval should be