From 2114da384abce47f4b12784711156a7d74d24bf1 Mon Sep 17 00:00:00 2001 From: Luc Maisonobe Date: Mon, 2 Nov 2015 15:23:30 +0100 Subject: [PATCH] Fixed checkstyle warnings. These warnings correspond to redundant modifiers (public, static, ...). They are identified by recent versions of checkstyle, in particular the one shipped with Eclipse. They are not detected by our maven-checkstyle-plugin yet because it is not the latest one and still depends on an older version of checkstyle. --- .../differentiation/DerivativeStructure.java | 2 +- .../BicubicInterpolatingFunction.java | 2 +- .../BicubicSplineInterpolatingFunction.java | 5 ++--- .../interpolation/InterpolatingMicrosphere.java | 5 ++--- .../TricubicInterpolatingFunction.java | 2 +- .../TricubicSplineInterpolatingFunction.java | 2 +- .../analysis/polynomials/PolynomialsUtils.java | 2 +- .../math3/exception/util/LocalizedFormats.java | 2 +- .../commons/math3/fitting/CurveFitter.java | 2 +- .../leastsquares/GaussNewtonOptimizer.java | 2 +- .../geometry/euclidean/oned/IntervalsSet.java | 2 +- .../euclidean/threed/OutlineExtractor.java | 2 +- .../euclidean/threed/PolyhedronsSet.java | 6 +++--- .../euclidean/threed/SphericalCoordinates.java | 2 +- .../math3/geometry/euclidean/twod/Line.java | 4 ++-- .../geometry/euclidean/twod/NestedLoops.java | 2 +- .../geometry/euclidean/twod/PolygonsSet.java | 14 +++++++------- .../partitioning/BoundaryProjector.java | 2 +- .../partitioning/BoundarySizeVisitor.java | 2 +- .../geometry/partitioning/Characterization.java | 2 +- .../geometry/partitioning/InsideFinder.java | 2 +- .../math3/geometry/partitioning/Region.java | 2 +- .../geometry/partitioning/RegionFactory.java | 4 ++-- .../geometry/partitioning/SubHyperplane.java | 2 +- .../partitioning/utilities/AVLTree.java | 2 +- .../math3/geometry/spherical/oned/ArcsSet.java | 2 +- .../math3/geometry/spherical/twod/Circle.java | 2 +- .../geometry/spherical/twod/EdgesBuilder.java | 2 +- .../spherical/twod/PropertiesComputer.java | 4 ++-- .../math3/linear/BiDiagonalTransformer.java | 2 +- .../math3/linear/HessenbergTransformer.java | 2 +- .../commons/math3/linear/MatrixUtils.java | 4 ++-- .../commons/math3/linear/SchurTransformer.java | 2 +- .../org/apache/commons/math3/linear/SymmLQ.java | 2 +- .../math3/linear/TriDiagonalTransformer.java | 2 +- .../ml/clustering/KMeansPlusPlusClusterer.java | 2 +- .../commons/math3/ml/neuralnet/MapUtils.java | 3 +-- .../math3/ode/ExpandableStatefulODE.java | 2 +- .../commons/math3/ode/JacobianMatrices.java | 4 ++-- .../commons/math3/ode/MultistepIntegrator.java | 4 ++-- .../math3/ode/ParameterConfiguration.java | 2 +- .../math3/ode/ParameterJacobianWrapper.java | 6 +++--- .../commons/math3/ode/ParameterizedWrapper.java | 2 +- .../commons/math3/ode/events/EventHandler.java | 2 +- .../commons/math3/ode/events/EventState.java | 2 +- .../ode/nonstiff/AdamsMoultonIntegrator.java | 2 +- .../ClassicalRungeKuttaStepInterpolator.java | 4 ++-- .../DormandPrince54StepInterpolator.java | 4 ++-- .../DormandPrince853StepInterpolator.java | 4 ++-- .../ode/nonstiff/EulerStepInterpolator.java | 4 ++-- .../ode/nonstiff/GillStepInterpolator.java | 4 ++-- .../GraggBulirschStoerStepInterpolator.java | 17 ++++++++--------- .../nonstiff/HighamHall54StepInterpolator.java | 4 ++-- .../ode/nonstiff/LutherStepInterpolator.java | 4 ++-- .../ode/nonstiff/MidpointStepInterpolator.java | 4 ++-- .../nonstiff/RungeKuttaStepInterpolator.java | 2 +- .../nonstiff/ThreeEighthesStepInterpolator.java | 4 ++-- .../ode/sampling/StepNormalizerBounds.java | 2 +- .../commons/math3/optim/PointValuePair.java | 2 +- .../math3/optim/PointVectorValuePair.java | 2 +- .../math3/optim/linear/Relationship.java | 2 +- .../MultivariateFunctionMappingAdapter.java | 6 +++--- .../NonLinearConjugateGradientOptimizer.java | 2 +- .../scalar/noderiv/CMAESOptimizer.java | 4 ++-- .../math3/optimization/PointValuePair.java | 2 +- .../optimization/PointVectorValuePair.java | 2 +- .../optimization/direct/CMAESOptimizer.java | 2 +- .../MultivariateFunctionMappingAdapter.java | 8 ++++---- .../math3/optimization/fitting/CurveFitter.java | 4 ++-- .../NonLinearConjugateGradientOptimizer.java | 2 +- .../math3/optimization/linear/Relationship.java | 2 +- .../math3/random/EmpiricalDistribution.java | 4 ++-- .../clustering/KMeansPlusPlusClusterer.java | 2 +- .../StorelessBivariateCovariance.java | 4 ++-- .../descriptive/AggregateSummaryStatistics.java | 2 +- .../stat/descriptive/moment/FirstMoment.java | 4 ++-- .../stat/descriptive/moment/FourthMoment.java | 4 ++-- .../stat/descriptive/moment/ThirdMoment.java | 4 ++-- .../descriptive/rank/PSquarePercentile.java | 2 +- .../math3/stat/descriptive/rank/Percentile.java | 4 ++-- .../math3/stat/ranking/NaturalRanking.java | 2 +- .../math3/transform/FastFourierTransformer.java | 3 +-- .../apache/commons/math3/util/Combinations.java | 9 ++++----- .../org/apache/commons/math3/util/FastMath.java | 6 +++--- .../apache/commons/math3/util/MathArrays.java | 6 +++--- .../math3/util/ResizableDoubleArray.java | 2 +- 86 files changed, 140 insertions(+), 146 deletions(-) diff --git a/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java b/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java index 7c45d185c..c625931a6 100644 --- a/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java +++ b/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java @@ -1177,7 +1177,7 @@ public class DerivativeStructure implements RealFieldElement { /** * @param f function to fit. */ - public TheoreticalValuesFunction(final ParametricUnivariateFunction f) { + TheoreticalValuesFunction(final ParametricUnivariateFunction f) { this.f = f; } diff --git a/src/main/java/org/apache/commons/math3/fitting/leastsquares/GaussNewtonOptimizer.java b/src/main/java/org/apache/commons/math3/fitting/leastsquares/GaussNewtonOptimizer.java index bc4503c32..dc758c1bb 100644 --- a/src/main/java/org/apache/commons/math3/fitting/leastsquares/GaussNewtonOptimizer.java +++ b/src/main/java/org/apache/commons/math3/fitting/leastsquares/GaussNewtonOptimizer.java @@ -50,7 +50,7 @@ public class GaussNewtonOptimizer implements LeastSquaresOptimizer { /** The decomposition algorithm to use to solve the normal equations. */ //TODO move to linear package and expand options? - public static enum Decomposition { + public enum Decomposition { /** * Solve by forming the normal equations (JTJx=JTr) and * using the {@link LUDecomposition}. diff --git a/src/main/java/org/apache/commons/math3/geometry/euclidean/oned/IntervalsSet.java b/src/main/java/org/apache/commons/math3/geometry/euclidean/oned/IntervalsSet.java index 383ea9fff..5ce7edb12 100644 --- a/src/main/java/org/apache/commons/math3/geometry/euclidean/oned/IntervalsSet.java +++ b/src/main/java/org/apache/commons/math3/geometry/euclidean/oned/IntervalsSet.java @@ -589,7 +589,7 @@ public class IntervalsSet extends AbstractRegion imple /** Simple constructor. */ - public SubIntervalsIterator() { + SubIntervalsIterator() { current = getFirstIntervalBoundary(); diff --git a/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/OutlineExtractor.java b/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/OutlineExtractor.java index 328018b8b..0f8af88c7 100644 --- a/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/OutlineExtractor.java +++ b/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/OutlineExtractor.java @@ -130,7 +130,7 @@ public class OutlineExtractor { /** Simple constructor. * @param tolerance tolerance below which points are considered identical */ - public BoundaryProjector(final double tolerance) { + BoundaryProjector(final double tolerance) { this.projected = new PolygonsSet(new BSPTree(Boolean.FALSE), tolerance); this.tolerance = tolerance; } diff --git a/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/PolyhedronsSet.java b/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/PolyhedronsSet.java index 7116c110f..f190e22aa 100644 --- a/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/PolyhedronsSet.java +++ b/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/PolyhedronsSet.java @@ -443,7 +443,7 @@ public class PolyhedronsSet extends AbstractRegion { private class FacetsContributionVisitor implements BSPTreeVisitor { /** Simple constructor. */ - public FacetsContributionVisitor() { + FacetsContributionVisitor() { setSize(0); setBarycenter((Point) new Vector3D(0, 0, 0)); } @@ -626,7 +626,7 @@ public class PolyhedronsSet extends AbstractRegion { * @param center center point of the rotation * @param rotation vectorial rotation */ - public RotationTransform(final Vector3D center, final Rotation rotation) { + RotationTransform(final Vector3D center, final Rotation rotation) { this.center = center; this.rotation = rotation; } @@ -697,7 +697,7 @@ public class PolyhedronsSet extends AbstractRegion { /** Build a translation transform. * @param translation translation vector */ - public TranslationTransform(final Vector3D translation) { + TranslationTransform(final Vector3D translation) { this.translation = translation; } diff --git a/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/SphericalCoordinates.java b/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/SphericalCoordinates.java index 23d818e28..016e0a0e7 100644 --- a/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/SphericalCoordinates.java +++ b/src/main/java/org/apache/commons/math3/geometry/euclidean/threed/SphericalCoordinates.java @@ -377,7 +377,7 @@ public class SphericalCoordinates implements Serializable { * @param y ordinate * @param z height */ - public DataTransferObject(final double x, final double y, final double z) { + DataTransferObject(final double x, final double y, final double z) { this.x = x; this.y = y; this.z = z; diff --git a/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/Line.java b/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/Line.java index b5587ad7c..e367278e1 100644 --- a/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/Line.java +++ b/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/Line.java @@ -514,8 +514,8 @@ public class Line implements Hyperplane, Embedding(); this.tolerance = tolerance; } diff --git a/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/PolygonsSet.java b/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/PolygonsSet.java index 46268f550..61fae9f97 100644 --- a/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/PolygonsSet.java +++ b/src/main/java/org/apache/commons/math3/geometry/euclidean/twod/PolygonsSet.java @@ -426,7 +426,7 @@ public class PolygonsSet extends AbstractRegion { /** Build a non-processed vertex not owned by any node yet. * @param location vertex location */ - public Vertex(final Vector2D location) { + Vertex(final Vector2D location) { this.location = location; this.incoming = null; this.outgoing = null; @@ -528,7 +528,7 @@ public class PolygonsSet extends AbstractRegion { * @param end end vertex * @param line line supporting the edge */ - public Edge(final Vertex start, final Vertex end, final Line line) { + Edge(final Vertex start, final Vertex end, final Line line) { this.start = start; this.end = end; @@ -971,10 +971,10 @@ public class PolygonsSet extends AbstractRegion { * @param startNode node whose intersection with current node defines start point * @param endNode node whose intersection with current node defines end point */ - public ConnectableSegment(final Vector2D start, final Vector2D end, final Line line, - final BSPTree node, - final BSPTree startNode, - final BSPTree endNode) { + ConnectableSegment(final Vector2D start, final Vector2D end, final Line line, + final BSPTree node, + final BSPTree startNode, + final BSPTree endNode) { super(start, end, line); this.node = node; this.startNode = startNode; @@ -1061,7 +1061,7 @@ public class PolygonsSet extends AbstractRegion { /** Simple constructor. * @param tolerance tolerance for close nodes connection */ - public SegmentsBuilder(final double tolerance) { + SegmentsBuilder(final double tolerance) { this.tolerance = tolerance; this.segments = new ArrayList(); } diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundaryProjector.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundaryProjector.java index 9f660bf1e..4fbf4b949 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundaryProjector.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundaryProjector.java @@ -46,7 +46,7 @@ class BoundaryProjector implements BSPTreeVisi /** Simple constructor. * @param original original point */ - public BoundaryProjector(final Point original) { + BoundaryProjector(final Point original) { this.original = original; this.projected = null; this.leaf = null; diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundarySizeVisitor.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundarySizeVisitor.java index e29083ac0..054838bd5 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundarySizeVisitor.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/BoundarySizeVisitor.java @@ -29,7 +29,7 @@ class BoundarySizeVisitor implements BSPTreeVisitor { /** Simple constructor. */ - public BoundarySizeVisitor() { + BoundarySizeVisitor() { boundarySize = 0; } diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/Characterization.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/Characterization.java index ca43be67b..f8ec2f9bc 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/Characterization.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/Characterization.java @@ -53,7 +53,7 @@ class Characterization { * @param node current BSP tree node * @param sub sub-hyperplane to characterize */ - public Characterization(final BSPTree node, final SubHyperplane sub) { + Characterization(final BSPTree node, final SubHyperplane sub) { outsideTouching = null; insideTouching = null; outsideSplitters = new NodesSet(); diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/InsideFinder.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/InsideFinder.java index 82a6d9e95..b1db90aa3 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/InsideFinder.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/InsideFinder.java @@ -37,7 +37,7 @@ class InsideFinder { /** Simple constructor. * @param region region on which to operate */ - public InsideFinder(final Region region) { + InsideFinder(final Region region) { this.region = region; plusFound = false; minusFound = false; diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/Region.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/Region.java index f7bc3aaa8..9ff3946a4 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/Region.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/Region.java @@ -53,7 +53,7 @@ import org.apache.commons.math3.geometry.Point; public interface Region { /** Enumerate for the location of a point with respect to the region. */ - public static enum Location { + enum Location { /** Code for points inside the partition. */ INSIDE, diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/RegionFactory.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/RegionFactory.java index 0f46848f5..86605be12 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/RegionFactory.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/RegionFactory.java @@ -295,7 +295,7 @@ public class RegionFactory { * @param region1 region to subtract from * @param region2 region to subtract */ - public DifferenceMerger(final Region region1, final Region region2) { + DifferenceMerger(final Region region1, final Region region2) { this.region1 = region1.copySelf(); this.region2 = region2.copySelf(); } @@ -358,7 +358,7 @@ public class RegionFactory { /** Simple constructor. * @param inside inside/outside indicator to use for ambiguous nodes */ - public VanishingToLeaf(final boolean inside) { + VanishingToLeaf(final boolean inside) { this.inside = inside; } diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/SubHyperplane.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/SubHyperplane.java index 9b6625bb0..2069f6ff2 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/SubHyperplane.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/SubHyperplane.java @@ -94,7 +94,7 @@ public interface SubHyperplane { /** Class holding the results of the {@link #split split} method. * @param Type of the embedding space. */ - public static class SplitSubHyperplane { + class SplitSubHyperplane { /** Part of the sub-hyperplane on the plus side of the splitting hyperplane. */ private final SubHyperplane plus; diff --git a/src/main/java/org/apache/commons/math3/geometry/partitioning/utilities/AVLTree.java b/src/main/java/org/apache/commons/math3/geometry/partitioning/utilities/AVLTree.java index 9412421d3..00c9d3e08 100644 --- a/src/main/java/org/apache/commons/math3/geometry/partitioning/utilities/AVLTree.java +++ b/src/main/java/org/apache/commons/math3/geometry/partitioning/utilities/AVLTree.java @@ -201,7 +201,7 @@ public class AVLTree> { } /** Enum for tree skew factor. */ - private static enum Skew { + private enum Skew { /** Code for left high trees. */ LEFT_HIGH, diff --git a/src/main/java/org/apache/commons/math3/geometry/spherical/oned/ArcsSet.java b/src/main/java/org/apache/commons/math3/geometry/spherical/oned/ArcsSet.java index c0ca6c10d..0a00aa789 100644 --- a/src/main/java/org/apache/commons/math3/geometry/spherical/oned/ArcsSet.java +++ b/src/main/java/org/apache/commons/math3/geometry/spherical/oned/ArcsSet.java @@ -598,7 +598,7 @@ public class ArcsSet extends AbstractRegion implements Itera /** Simple constructor. */ - public SubArcsIterator() { + SubArcsIterator() { firstStart = getFirstArcStart(); current = firstStart; diff --git a/src/main/java/org/apache/commons/math3/geometry/spherical/twod/Circle.java b/src/main/java/org/apache/commons/math3/geometry/spherical/twod/Circle.java index d6d47de0f..a34db6d7e 100644 --- a/src/main/java/org/apache/commons/math3/geometry/spherical/twod/Circle.java +++ b/src/main/java/org/apache/commons/math3/geometry/spherical/twod/Circle.java @@ -295,7 +295,7 @@ public class Circle implements Hyperplane, Embedding { * @param root tree root * @param tolerance below which points are consider to be identical */ - public EdgesBuilder(final BSPTree root, final double tolerance) { + EdgesBuilder(final BSPTree root, final double tolerance) { this.root = root; this.tolerance = tolerance; this.edgeToNode = new IdentityHashMap>(); diff --git a/src/main/java/org/apache/commons/math3/geometry/spherical/twod/PropertiesComputer.java b/src/main/java/org/apache/commons/math3/geometry/spherical/twod/PropertiesComputer.java index 9d15b112f..593180f7a 100644 --- a/src/main/java/org/apache/commons/math3/geometry/spherical/twod/PropertiesComputer.java +++ b/src/main/java/org/apache/commons/math3/geometry/spherical/twod/PropertiesComputer.java @@ -44,9 +44,9 @@ class PropertiesComputer implements BSPTreeVisitor { private final List convexCellsInsidePoints; /** Simple constructor. - * @param tolerance below which points are consider to be identical + * @param tolerance below which points are consider to be identical */ - public PropertiesComputer(final double tolerance) { + PropertiesComputer(final double tolerance) { this.tolerance = tolerance; this.summedArea = 0; this.summedBarycenter = Vector3D.ZERO; diff --git a/src/main/java/org/apache/commons/math3/linear/BiDiagonalTransformer.java b/src/main/java/org/apache/commons/math3/linear/BiDiagonalTransformer.java index cfbcb6831..4a450e1f1 100644 --- a/src/main/java/org/apache/commons/math3/linear/BiDiagonalTransformer.java +++ b/src/main/java/org/apache/commons/math3/linear/BiDiagonalTransformer.java @@ -58,7 +58,7 @@ class BiDiagonalTransformer { * Build the transformation to bi-diagonal shape of a matrix. * @param matrix the matrix to transform. */ - public BiDiagonalTransformer(RealMatrix matrix) { + BiDiagonalTransformer(RealMatrix matrix) { final int m = matrix.getRowDimension(); final int n = matrix.getColumnDimension(); diff --git a/src/main/java/org/apache/commons/math3/linear/HessenbergTransformer.java b/src/main/java/org/apache/commons/math3/linear/HessenbergTransformer.java index 8fefc0976..d1caa4620 100644 --- a/src/main/java/org/apache/commons/math3/linear/HessenbergTransformer.java +++ b/src/main/java/org/apache/commons/math3/linear/HessenbergTransformer.java @@ -56,7 +56,7 @@ class HessenbergTransformer { * @param matrix matrix to transform * @throws NonSquareMatrixException if the matrix is not square */ - public HessenbergTransformer(final RealMatrix matrix) { + HessenbergTransformer(final RealMatrix matrix) { if (!matrix.isSquare()) { throw new NonSquareMatrixException(matrix.getRowDimension(), matrix.getColumnDimension()); diff --git a/src/main/java/org/apache/commons/math3/linear/MatrixUtils.java b/src/main/java/org/apache/commons/math3/linear/MatrixUtils.java index 23c11e09c..08bcfc981 100644 --- a/src/main/java/org/apache/commons/math3/linear/MatrixUtils.java +++ b/src/main/java/org/apache/commons/math3/linear/MatrixUtils.java @@ -625,7 +625,7 @@ public class MatrixUtils { /** Converted array. */ private double[][] data; /** Simple constructor. */ - public FractionMatrixConverter() { + FractionMatrixConverter() { super(Fraction.ZERO); } @@ -670,7 +670,7 @@ public class MatrixUtils { /** Converted array. */ private double[][] data; /** Simple constructor. */ - public BigFractionMatrixConverter() { + BigFractionMatrixConverter() { super(BigFraction.ZERO); } diff --git a/src/main/java/org/apache/commons/math3/linear/SchurTransformer.java b/src/main/java/org/apache/commons/math3/linear/SchurTransformer.java index cd54ca434..6cdf876a5 100644 --- a/src/main/java/org/apache/commons/math3/linear/SchurTransformer.java +++ b/src/main/java/org/apache/commons/math3/linear/SchurTransformer.java @@ -65,7 +65,7 @@ class SchurTransformer { * @param matrix matrix to transform * @throws NonSquareMatrixException if the matrix is not square */ - public SchurTransformer(final RealMatrix matrix) { + SchurTransformer(final RealMatrix matrix) { if (!matrix.isSquare()) { throw new NonSquareMatrixException(matrix.getRowDimension(), matrix.getColumnDimension()); diff --git a/src/main/java/org/apache/commons/math3/linear/SymmLQ.java b/src/main/java/org/apache/commons/math3/linear/SymmLQ.java index e529a6a21..03a4bedd1 100644 --- a/src/main/java/org/apache/commons/math3/linear/SymmLQ.java +++ b/src/main/java/org/apache/commons/math3/linear/SymmLQ.java @@ -380,7 +380,7 @@ public class SymmLQ * @param check {@code true} if self-adjointedness of both matrix and * preconditioner should be checked */ - public State(final RealLinearOperator a, + State(final RealLinearOperator a, final RealLinearOperator m, final RealVector b, final boolean goodb, diff --git a/src/main/java/org/apache/commons/math3/linear/TriDiagonalTransformer.java b/src/main/java/org/apache/commons/math3/linear/TriDiagonalTransformer.java index 9d2f9863b..c79f9defc 100644 --- a/src/main/java/org/apache/commons/math3/linear/TriDiagonalTransformer.java +++ b/src/main/java/org/apache/commons/math3/linear/TriDiagonalTransformer.java @@ -58,7 +58,7 @@ class TriDiagonalTransformer { * @param matrix Symmetrical matrix to transform. * @throws NonSquareMatrixException if the matrix is not square. */ - public TriDiagonalTransformer(RealMatrix matrix) { + TriDiagonalTransformer(RealMatrix matrix) { if (!matrix.isSquare()) { throw new NonSquareMatrixException(matrix.getRowDimension(), matrix.getColumnDimension()); diff --git a/src/main/java/org/apache/commons/math3/ml/clustering/KMeansPlusPlusClusterer.java b/src/main/java/org/apache/commons/math3/ml/clustering/KMeansPlusPlusClusterer.java index 2e68c2d1f..2e57fac0d 100644 --- a/src/main/java/org/apache/commons/math3/ml/clustering/KMeansPlusPlusClusterer.java +++ b/src/main/java/org/apache/commons/math3/ml/clustering/KMeansPlusPlusClusterer.java @@ -42,7 +42,7 @@ import org.apache.commons.math3.util.MathUtils; public class KMeansPlusPlusClusterer extends Clusterer { /** Strategies to use for replacing an empty cluster. */ - public static enum EmptyClusterStrategy { + public enum EmptyClusterStrategy { /** Split the cluster with largest distance variance. */ LARGEST_VARIANCE, diff --git a/src/main/java/org/apache/commons/math3/ml/neuralnet/MapUtils.java b/src/main/java/org/apache/commons/math3/ml/neuralnet/MapUtils.java index f5ecf0232..83036c212 100644 --- a/src/main/java/org/apache/commons/math3/ml/neuralnet/MapUtils.java +++ b/src/main/java/org/apache/commons/math3/ml/neuralnet/MapUtils.java @@ -301,8 +301,7 @@ public class MapUtils { * @param neuron Neuron. * @param value Value. */ - public PairNeuronDouble(Neuron neuron, - double value) { + PairNeuronDouble(Neuron neuron, double value) { this.neuron = neuron; this.value = value; } diff --git a/src/main/java/org/apache/commons/math3/ode/ExpandableStatefulODE.java b/src/main/java/org/apache/commons/math3/ode/ExpandableStatefulODE.java index dc7d4a9ba..72d3dcb01 100644 --- a/src/main/java/org/apache/commons/math3/ode/ExpandableStatefulODE.java +++ b/src/main/java/org/apache/commons/math3/ode/ExpandableStatefulODE.java @@ -317,7 +317,7 @@ public class ExpandableStatefulODE { * @param equation secondary differential equation * @param firstIndex index to use for the first element in the complete arrays */ - public SecondaryComponent(final SecondaryEquations equation, final int firstIndex) { + SecondaryComponent(final SecondaryEquations equation, final int firstIndex) { final int n = equation.getDimension(); this.equation = equation; mapper = new EquationsMapper(firstIndex, n); diff --git a/src/main/java/org/apache/commons/math3/ode/JacobianMatrices.java b/src/main/java/org/apache/commons/math3/ode/JacobianMatrices.java index 0ce552d69..3710a6b2c 100644 --- a/src/main/java/org/apache/commons/math3/ode/JacobianMatrices.java +++ b/src/main/java/org/apache/commons/math3/ode/JacobianMatrices.java @@ -431,8 +431,8 @@ public class JacobianMatrices { * @exception DimensionMismatchException if there is a dimension mismatch between * the steps array {@code hY} and the equation dimension */ - public MainStateJacobianWrapper(final FirstOrderDifferentialEquations ode, - final double[] hY) + MainStateJacobianWrapper(final FirstOrderDifferentialEquations ode, + final double[] hY) throws DimensionMismatchException { this.ode = ode; this.hY = hY.clone(); diff --git a/src/main/java/org/apache/commons/math3/ode/MultistepIntegrator.java b/src/main/java/org/apache/commons/math3/ode/MultistepIntegrator.java index 0fad1a295..17baed799 100644 --- a/src/main/java/org/apache/commons/math3/ode/MultistepIntegrator.java +++ b/src/main/java/org/apache/commons/math3/ode/MultistepIntegrator.java @@ -355,7 +355,7 @@ public abstract class MultistepIntegrator extends AdaptiveStepsizeIntegrator { * @param nSteps number of steps of the multistep method (excluding the one being computed) * @param n problem dimension */ - public NordsieckInitializer(final int nSteps, final int n) { + NordsieckInitializer(final int nSteps, final int n) { this.count = 0; this.t = new double[nSteps]; this.y = new double[nSteps][n]; @@ -438,7 +438,7 @@ public abstract class MultistepIntegrator extends AdaptiveStepsizeIntegrator { private static final long serialVersionUID = -1914085471038046418L; /** Simple constructor. */ - public InitializationCompletedMarkerException() { + InitializationCompletedMarkerException() { super((Throwable) null); } diff --git a/src/main/java/org/apache/commons/math3/ode/ParameterConfiguration.java b/src/main/java/org/apache/commons/math3/ode/ParameterConfiguration.java index 7af2cd550..bca7e681b 100644 --- a/src/main/java/org/apache/commons/math3/ode/ParameterConfiguration.java +++ b/src/main/java/org/apache/commons/math3/ode/ParameterConfiguration.java @@ -38,7 +38,7 @@ class ParameterConfiguration implements Serializable { * @param parameterName parameter name * @param hP parameter step */ - public ParameterConfiguration(final String parameterName, final double hP) { + ParameterConfiguration(final String parameterName, final double hP) { this.parameterName = parameterName; this.hP = hP; } diff --git a/src/main/java/org/apache/commons/math3/ode/ParameterJacobianWrapper.java b/src/main/java/org/apache/commons/math3/ode/ParameterJacobianWrapper.java index 40fcd97ce..1d3936f34 100644 --- a/src/main/java/org/apache/commons/math3/ode/ParameterJacobianWrapper.java +++ b/src/main/java/org/apache/commons/math3/ode/ParameterJacobianWrapper.java @@ -46,9 +46,9 @@ class ParameterJacobianWrapper implements ParameterJacobianProvider { * @param paramsAndSteps parameters and steps to compute the Jacobians df/dp * @see JacobianMatrices#setParameterStep(String, double) */ - public ParameterJacobianWrapper(final FirstOrderDifferentialEquations fode, - final ParameterizedODE pode, - final ParameterConfiguration[] paramsAndSteps) { + ParameterJacobianWrapper(final FirstOrderDifferentialEquations fode, + final ParameterizedODE pode, + final ParameterConfiguration[] paramsAndSteps) { this.fode = fode; this.pode = pode; this.hParam = new HashMap(); diff --git a/src/main/java/org/apache/commons/math3/ode/ParameterizedWrapper.java b/src/main/java/org/apache/commons/math3/ode/ParameterizedWrapper.java index 1a0bad6d6..74c8e9963 100644 --- a/src/main/java/org/apache/commons/math3/ode/ParameterizedWrapper.java +++ b/src/main/java/org/apache/commons/math3/ode/ParameterizedWrapper.java @@ -35,7 +35,7 @@ class ParameterizedWrapper implements ParameterizedODE { /** Simple constructor. * @param ode original first order differential equations */ - public ParameterizedWrapper(final FirstOrderDifferentialEquations ode) { + ParameterizedWrapper(final FirstOrderDifferentialEquations ode) { this.fode = ode; } diff --git a/src/main/java/org/apache/commons/math3/ode/events/EventHandler.java b/src/main/java/org/apache/commons/math3/ode/events/EventHandler.java index 8fb39a423..58533bc05 100644 --- a/src/main/java/org/apache/commons/math3/ode/events/EventHandler.java +++ b/src/main/java/org/apache/commons/math3/ode/events/EventHandler.java @@ -50,7 +50,7 @@ package org.apache.commons.math3.ode.events; public interface EventHandler { /** Enumerate for actions to be performed when an event occurs. */ - public enum Action { + enum Action { /** Stop indicator. *

This value should be used as the return value of the {@link diff --git a/src/main/java/org/apache/commons/math3/ode/events/EventState.java b/src/main/java/org/apache/commons/math3/ode/events/EventState.java index cf64f36ff..b838654ea 100644 --- a/src/main/java/org/apache/commons/math3/ode/events/EventState.java +++ b/src/main/java/org/apache/commons/math3/ode/events/EventState.java @@ -414,7 +414,7 @@ public class EventState { /** Simple constructor. * @param exception exception to wrap */ - public LocalMaxCountExceededException(final MaxCountExceededException exception) { + LocalMaxCountExceededException(final MaxCountExceededException exception) { wrapped = exception; } diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/AdamsMoultonIntegrator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/AdamsMoultonIntegrator.java index c019fabe7..c12c19b7d 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/AdamsMoultonIntegrator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/AdamsMoultonIntegrator.java @@ -367,7 +367,7 @@ public class AdamsMoultonIntegrator extends AdamsIntegrator { * @param scaled current scaled first derivative * @param state state to correct (will be overwritten after visit) */ - public Corrector(final double[] previous, final double[] scaled, final double[] state) { + Corrector(final double[] previous, final double[] scaled, final double[] state) { this.previous = previous; this.scaled = scaled; this.after = state; diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java index ba9b11fc8..5825cc4ba 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java @@ -68,7 +68,7 @@ class ClassicalRungeKuttaStepInterpolator * interpolators by cloning an uninitialized model and latter initializing * the copy. */ - public ClassicalRungeKuttaStepInterpolator() { + ClassicalRungeKuttaStepInterpolator() { } /** Copy constructor. @@ -76,7 +76,7 @@ class ClassicalRungeKuttaStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public ClassicalRungeKuttaStepInterpolator(final ClassicalRungeKuttaStepInterpolator interpolator) { + ClassicalRungeKuttaStepInterpolator(final ClassicalRungeKuttaStepInterpolator interpolator) { super(interpolator); } diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince54StepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince54StepInterpolator.java index a01358443..b62dc0c63 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince54StepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince54StepInterpolator.java @@ -97,7 +97,7 @@ class DormandPrince54StepInterpolator * prototyping design pattern to create the step interpolators by * cloning an uninitialized model and latter initializing the copy. */ - public DormandPrince54StepInterpolator() { + DormandPrince54StepInterpolator() { super(); v1 = null; v2 = null; @@ -111,7 +111,7 @@ class DormandPrince54StepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public DormandPrince54StepInterpolator(final DormandPrince54StepInterpolator interpolator) { + DormandPrince54StepInterpolator(final DormandPrince54StepInterpolator interpolator) { super(interpolator); diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince853StepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince853StepInterpolator.java index 3ff3a850f..443d1068f 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince853StepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/DormandPrince853StepInterpolator.java @@ -227,7 +227,7 @@ class DormandPrince853StepInterpolator * prototyping design pattern to create the step interpolators by * cloning an uninitialized model and latter initializing the copy. */ - public DormandPrince853StepInterpolator() { + DormandPrince853StepInterpolator() { super(); yDotKLast = null; v = null; @@ -239,7 +239,7 @@ class DormandPrince853StepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public DormandPrince853StepInterpolator(final DormandPrince853StepInterpolator interpolator) { + DormandPrince853StepInterpolator(final DormandPrince853StepInterpolator interpolator) { super(interpolator); diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/EulerStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/EulerStepInterpolator.java index 3c45780ee..7a5063d38 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/EulerStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/EulerStepInterpolator.java @@ -59,7 +59,7 @@ class EulerStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public EulerStepInterpolator() { + EulerStepInterpolator() { } /** Copy constructor. @@ -67,7 +67,7 @@ class EulerStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public EulerStepInterpolator(final EulerStepInterpolator interpolator) { + EulerStepInterpolator(final EulerStepInterpolator interpolator) { super(interpolator); } diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/GillStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/GillStepInterpolator.java index 49081f544..85d8fffa6 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/GillStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/GillStepInterpolator.java @@ -75,7 +75,7 @@ class GillStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public GillStepInterpolator() { + GillStepInterpolator() { } /** Copy constructor. @@ -83,7 +83,7 @@ class GillStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public GillStepInterpolator(final GillStepInterpolator interpolator) { + GillStepInterpolator(final GillStepInterpolator interpolator) { super(interpolator); } diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/GraggBulirschStoerStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/GraggBulirschStoerStepInterpolator.java index c1d61b3a7..b70f89612 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/GraggBulirschStoerStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/GraggBulirschStoerStepInterpolator.java @@ -107,7 +107,7 @@ class GraggBulirschStoerStepInterpolator * This constructor should not be used directly, it is only intended * for the serialization process. */ - public GraggBulirschStoerStepInterpolator() { + GraggBulirschStoerStepInterpolator() { y0Dot = null; y1 = null; y1Dot = null; @@ -129,12 +129,12 @@ class GraggBulirschStoerStepInterpolator * @param primaryMapper equations mapper for the primary equations set * @param secondaryMappers equations mappers for the secondary equations sets */ - public GraggBulirschStoerStepInterpolator(final double[] y, final double[] y0Dot, - final double[] y1, final double[] y1Dot, - final double[][] yMidDots, - final boolean forward, - final EquationsMapper primaryMapper, - final EquationsMapper[] secondaryMappers) { + GraggBulirschStoerStepInterpolator(final double[] y, final double[] y0Dot, + final double[] y1, final double[] y1Dot, + final double[][] yMidDots, + final boolean forward, + final EquationsMapper primaryMapper, + final EquationsMapper[] secondaryMappers) { super(y, forward, primaryMapper, secondaryMappers); this.y0Dot = y0Dot; @@ -151,8 +151,7 @@ class GraggBulirschStoerStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public GraggBulirschStoerStepInterpolator - (final GraggBulirschStoerStepInterpolator interpolator) { + GraggBulirschStoerStepInterpolator(final GraggBulirschStoerStepInterpolator interpolator) { super(interpolator); diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/HighamHall54StepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/HighamHall54StepInterpolator.java index cecbafbc4..36acb42b4 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/HighamHall54StepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/HighamHall54StepInterpolator.java @@ -45,7 +45,7 @@ class HighamHall54StepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public HighamHall54StepInterpolator() { + HighamHall54StepInterpolator() { super(); } @@ -54,7 +54,7 @@ class HighamHall54StepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public HighamHall54StepInterpolator(final HighamHall54StepInterpolator interpolator) { + HighamHall54StepInterpolator(final HighamHall54StepInterpolator interpolator) { super(interpolator); } diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/LutherStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/LutherStepInterpolator.java index 6f54b704d..86f22af13 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/LutherStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/LutherStepInterpolator.java @@ -51,7 +51,7 @@ class LutherStepInterpolator extends RungeKuttaStepInterpolator { * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public LutherStepInterpolator() { + LutherStepInterpolator() { } /** Copy constructor. @@ -59,7 +59,7 @@ class LutherStepInterpolator extends RungeKuttaStepInterpolator { * copy: its arrays are separated from the original arrays of the * instance */ - public LutherStepInterpolator(final LutherStepInterpolator interpolator) { + LutherStepInterpolator(final LutherStepInterpolator interpolator) { super(interpolator); } diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/MidpointStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/MidpointStepInterpolator.java index 7346f7ab8..ac3cddb71 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/MidpointStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/MidpointStepInterpolator.java @@ -61,7 +61,7 @@ class MidpointStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public MidpointStepInterpolator() { + MidpointStepInterpolator() { } /** Copy constructor. @@ -69,7 +69,7 @@ class MidpointStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public MidpointStepInterpolator(final MidpointStepInterpolator interpolator) { + MidpointStepInterpolator(final MidpointStepInterpolator interpolator) { super(interpolator); } diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/RungeKuttaStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/RungeKuttaStepInterpolator.java index c15c590eb..1ae7cb993 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/RungeKuttaStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/RungeKuttaStepInterpolator.java @@ -79,7 +79,7 @@ abstract class RungeKuttaStepInterpolator * @param interpolator interpolator to copy from. */ - public RungeKuttaStepInterpolator(final RungeKuttaStepInterpolator interpolator) { + RungeKuttaStepInterpolator(final RungeKuttaStepInterpolator interpolator) { super(interpolator); diff --git a/src/main/java/org/apache/commons/math3/ode/nonstiff/ThreeEighthesStepInterpolator.java b/src/main/java/org/apache/commons/math3/ode/nonstiff/ThreeEighthesStepInterpolator.java index 0f263d1d9..55d27517e 100644 --- a/src/main/java/org/apache/commons/math3/ode/nonstiff/ThreeEighthesStepInterpolator.java +++ b/src/main/java/org/apache/commons/math3/ode/nonstiff/ThreeEighthesStepInterpolator.java @@ -71,7 +71,7 @@ class ThreeEighthesStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public ThreeEighthesStepInterpolator() { + ThreeEighthesStepInterpolator() { } /** Copy constructor. @@ -79,7 +79,7 @@ class ThreeEighthesStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public ThreeEighthesStepInterpolator(final ThreeEighthesStepInterpolator interpolator) { + ThreeEighthesStepInterpolator(final ThreeEighthesStepInterpolator interpolator) { super(interpolator); } diff --git a/src/main/java/org/apache/commons/math3/ode/sampling/StepNormalizerBounds.java b/src/main/java/org/apache/commons/math3/ode/sampling/StepNormalizerBounds.java index ff1ee2c1c..0ccc58a3e 100644 --- a/src/main/java/org/apache/commons/math3/ode/sampling/StepNormalizerBounds.java +++ b/src/main/java/org/apache/commons/math3/ode/sampling/StepNormalizerBounds.java @@ -56,7 +56,7 @@ public enum StepNormalizerBounds { * @param last Whether the last point should be passed to the * underlying fixed step size step handler. */ - private StepNormalizerBounds(final boolean first, final boolean last) { + StepNormalizerBounds(final boolean first, final boolean last) { this.first = first; this.last = last; } diff --git a/src/main/java/org/apache/commons/math3/optim/PointValuePair.java b/src/main/java/org/apache/commons/math3/optim/PointValuePair.java index 0f27a52ba..c466fc7dc 100644 --- a/src/main/java/org/apache/commons/math3/optim/PointValuePair.java +++ b/src/main/java/org/apache/commons/math3/optim/PointValuePair.java @@ -106,7 +106,7 @@ public class PointValuePair extends Pair implements Serializab * @param point Point coordinates. * @param value Value of the objective function at the point. */ - public DataTransferObject(final double[] point, final double value) { + DataTransferObject(final double[] point, final double value) { this.point = point.clone(); this.value = value; } diff --git a/src/main/java/org/apache/commons/math3/optim/PointVectorValuePair.java b/src/main/java/org/apache/commons/math3/optim/PointVectorValuePair.java index 0dd70f41a..478e3509a 100644 --- a/src/main/java/org/apache/commons/math3/optim/PointVectorValuePair.java +++ b/src/main/java/org/apache/commons/math3/optim/PointVectorValuePair.java @@ -131,7 +131,7 @@ public class PointVectorValuePair extends Pair implements Se * @param point Point coordinates. * @param value Value of the objective function at the point. */ - public DataTransferObject(final double[] point, final double[] value) { + DataTransferObject(final double[] point, final double[] value) { this.point = point.clone(); this.value = value.clone(); } diff --git a/src/main/java/org/apache/commons/math3/optim/linear/Relationship.java b/src/main/java/org/apache/commons/math3/optim/linear/Relationship.java index 58612c7e2..5e28a5835 100644 --- a/src/main/java/org/apache/commons/math3/optim/linear/Relationship.java +++ b/src/main/java/org/apache/commons/math3/optim/linear/Relationship.java @@ -37,7 +37,7 @@ public enum Relationship { * * @param stringValue Display string for the relationship. */ - private Relationship(String stringValue) { + Relationship(String stringValue) { this.stringValue = stringValue; } diff --git a/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java b/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java index 80daace26..3c5127cfd 100644 --- a/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java +++ b/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java @@ -222,7 +222,7 @@ public class MultivariateFunctionMappingAdapter * * @param lower lower bound */ - public LowerBoundMapper(final double lower) { + LowerBoundMapper(final double lower) { this.lower = lower; } @@ -247,7 +247,7 @@ public class MultivariateFunctionMappingAdapter /** Simple constructor. * @param upper upper bound */ - public UpperBoundMapper(final double upper) { + UpperBoundMapper(final double upper) { this.upper = upper; } @@ -276,7 +276,7 @@ public class MultivariateFunctionMappingAdapter * @param lower lower bound * @param upper upper bound */ - public LowerUpperBoundMapper(final double lower, final double upper) { + LowerUpperBoundMapper(final double lower, final double upper) { boundingFunction = new Sigmoid(lower, upper); unboundingFunction = new Logit(lower, upper); } diff --git a/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java b/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java index 3e6fa895e..90741225a 100644 --- a/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java +++ b/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java @@ -70,7 +70,7 @@ public class NonLinearConjugateGradientOptimizer * * @since 2.0 */ - public static enum Formula { + public enum Formula { /** Fletcher-Reeves formula. */ FLETCHER_REEVES, /** Polak-Ribière formula. */ diff --git a/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java b/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java index 82cc748cc..13566be96 100644 --- a/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java +++ b/src/main/java/org/apache/commons/math3/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java @@ -911,7 +911,7 @@ public class CMAESOptimizer * @param value Function value. * @param penalty Out-of-bounds penalty. */ - public ValuePenaltyPair(final double value, final double penalty) { + ValuePenaltyPair(final double value, final double penalty) { this.value = value; this.penalty = penalty; } @@ -931,7 +931,7 @@ public class CMAESOptimizer /** Simple constructor. */ - public FitnessFunction() { + FitnessFunction() { isRepairMode = true; } diff --git a/src/main/java/org/apache/commons/math3/optimization/PointValuePair.java b/src/main/java/org/apache/commons/math3/optimization/PointValuePair.java index 7db9261b3..a338e6902 100644 --- a/src/main/java/org/apache/commons/math3/optimization/PointValuePair.java +++ b/src/main/java/org/apache/commons/math3/optimization/PointValuePair.java @@ -111,7 +111,7 @@ public class PointValuePair extends Pair implements Serializab * @param point Point coordinates. * @param value Value of the objective function at the point. */ - public DataTransferObject(final double[] point, final double value) { + DataTransferObject(final double[] point, final double value) { this.point = point.clone(); this.value = value; } diff --git a/src/main/java/org/apache/commons/math3/optimization/PointVectorValuePair.java b/src/main/java/org/apache/commons/math3/optimization/PointVectorValuePair.java index 4c1884d54..4cacf970d 100644 --- a/src/main/java/org/apache/commons/math3/optimization/PointVectorValuePair.java +++ b/src/main/java/org/apache/commons/math3/optimization/PointVectorValuePair.java @@ -136,7 +136,7 @@ public class PointVectorValuePair extends Pair implements Se * @param point Point coordinates. * @param value Value of the objective function at the point. */ - public DataTransferObject(final double[] point, final double[] value) { + DataTransferObject(final double[] point, final double[] value) { this.point = point.clone(); this.value = value.clone(); } diff --git a/src/main/java/org/apache/commons/math3/optimization/direct/CMAESOptimizer.java b/src/main/java/org/apache/commons/math3/optimization/direct/CMAESOptimizer.java index 661b5694e..388a6f7d0 100644 --- a/src/main/java/org/apache/commons/math3/optimization/direct/CMAESOptimizer.java +++ b/src/main/java/org/apache/commons/math3/optimization/direct/CMAESOptimizer.java @@ -1013,7 +1013,7 @@ public class CMAESOptimizer /** Simple constructor. */ - public FitnessFunction() { + FitnessFunction() { valueRange = 1; isRepairMode = true; } diff --git a/src/main/java/org/apache/commons/math3/optimization/direct/MultivariateFunctionMappingAdapter.java b/src/main/java/org/apache/commons/math3/optimization/direct/MultivariateFunctionMappingAdapter.java index 334138b20..32f2a2ce4 100644 --- a/src/main/java/org/apache/commons/math3/optimization/direct/MultivariateFunctionMappingAdapter.java +++ b/src/main/java/org/apache/commons/math3/optimization/direct/MultivariateFunctionMappingAdapter.java @@ -203,7 +203,7 @@ public class MultivariateFunctionMappingAdapter implements MultivariateFunction /** Simple constructor. */ - public NoBoundsMapper() { + NoBoundsMapper() { } /** {@inheritDoc} */ @@ -227,7 +227,7 @@ public class MultivariateFunctionMappingAdapter implements MultivariateFunction /** Simple constructor. * @param lower lower bound */ - public LowerBoundMapper(final double lower) { + LowerBoundMapper(final double lower) { this.lower = lower; } @@ -252,7 +252,7 @@ public class MultivariateFunctionMappingAdapter implements MultivariateFunction /** Simple constructor. * @param upper upper bound */ - public UpperBoundMapper(final double upper) { + UpperBoundMapper(final double upper) { this.upper = upper; } @@ -281,7 +281,7 @@ public class MultivariateFunctionMappingAdapter implements MultivariateFunction * @param lower lower bound * @param upper upper bound */ - public LowerUpperBoundMapper(final double lower, final double upper) { + LowerUpperBoundMapper(final double lower, final double upper) { boundingFunction = new Sigmoid(lower, upper); unboundingFunction = new Logit(lower, upper); } diff --git a/src/main/java/org/apache/commons/math3/optimization/fitting/CurveFitter.java b/src/main/java/org/apache/commons/math3/optimization/fitting/CurveFitter.java index ad1e0259c..dce5bc797 100644 --- a/src/main/java/org/apache/commons/math3/optimization/fitting/CurveFitter.java +++ b/src/main/java/org/apache/commons/math3/optimization/fitting/CurveFitter.java @@ -207,7 +207,7 @@ public class CurveFitter { /** Simple constructor. * @param f function to fit. */ - public OldTheoreticalValuesFunction(final ParametricUnivariateFunction f) { + OldTheoreticalValuesFunction(final ParametricUnivariateFunction f) { this.f = f; } @@ -249,7 +249,7 @@ public class CurveFitter { /** Simple constructor. * @param f function to fit. */ - public TheoreticalValuesFunction(final ParametricUnivariateFunction f) { + TheoreticalValuesFunction(final ParametricUnivariateFunction f) { this.f = f; } diff --git a/src/main/java/org/apache/commons/math3/optimization/general/NonLinearConjugateGradientOptimizer.java b/src/main/java/org/apache/commons/math3/optimization/general/NonLinearConjugateGradientOptimizer.java index c076d118b..ee16472e9 100644 --- a/src/main/java/org/apache/commons/math3/optimization/general/NonLinearConjugateGradientOptimizer.java +++ b/src/main/java/org/apache/commons/math3/optimization/general/NonLinearConjugateGradientOptimizer.java @@ -284,7 +284,7 @@ public class NonLinearConjugateGradientOptimizer /** Simple constructor. * @param searchDirection search direction */ - public LineSearchFunction(final double[] searchDirection) { + LineSearchFunction(final double[] searchDirection) { this.searchDirection = searchDirection; } diff --git a/src/main/java/org/apache/commons/math3/optimization/linear/Relationship.java b/src/main/java/org/apache/commons/math3/optimization/linear/Relationship.java index 0da755f21..3b1adc0ef 100644 --- a/src/main/java/org/apache/commons/math3/optimization/linear/Relationship.java +++ b/src/main/java/org/apache/commons/math3/optimization/linear/Relationship.java @@ -40,7 +40,7 @@ public enum Relationship { /** Simple constructor. * @param stringValue display string for the relationship */ - private Relationship(String stringValue) { + Relationship(String stringValue) { this.stringValue = stringValue; } diff --git a/src/main/java/org/apache/commons/math3/random/EmpiricalDistribution.java b/src/main/java/org/apache/commons/math3/random/EmpiricalDistribution.java index 74b1bddfd..06b0a9b73 100644 --- a/src/main/java/org/apache/commons/math3/random/EmpiricalDistribution.java +++ b/src/main/java/org/apache/commons/math3/random/EmpiricalDistribution.java @@ -349,7 +349,7 @@ public class EmpiricalDistribution extends AbstractRealDistribution { * * @param in BufferedReader input stream */ - public StreamDataAdapter(BufferedReader in){ + StreamDataAdapter(BufferedReader in){ super(); inputStream = in; } @@ -398,7 +398,7 @@ public class EmpiricalDistribution extends AbstractRealDistribution { * @param in double[] array holding the data * @throws NullArgumentException if in is null */ - public ArrayDataAdapter(double[] in) throws NullArgumentException { + ArrayDataAdapter(double[] in) throws NullArgumentException { super(); MathUtils.checkNotNull(in); inputArray = in; diff --git a/src/main/java/org/apache/commons/math3/stat/clustering/KMeansPlusPlusClusterer.java b/src/main/java/org/apache/commons/math3/stat/clustering/KMeansPlusPlusClusterer.java index ace584e63..07cec0955 100644 --- a/src/main/java/org/apache/commons/math3/stat/clustering/KMeansPlusPlusClusterer.java +++ b/src/main/java/org/apache/commons/math3/stat/clustering/KMeansPlusPlusClusterer.java @@ -42,7 +42,7 @@ import org.apache.commons.math3.util.MathUtils; public class KMeansPlusPlusClusterer> { /** Strategies to use for replacing an empty cluster. */ - public static enum EmptyClusterStrategy { + public enum EmptyClusterStrategy { /** Split the cluster with largest distance variance. */ LARGEST_VARIANCE, diff --git a/src/main/java/org/apache/commons/math3/stat/correlation/StorelessBivariateCovariance.java b/src/main/java/org/apache/commons/math3/stat/correlation/StorelessBivariateCovariance.java index 20722a6df..1a798d2f6 100644 --- a/src/main/java/org/apache/commons/math3/stat/correlation/StorelessBivariateCovariance.java +++ b/src/main/java/org/apache/commons/math3/stat/correlation/StorelessBivariateCovariance.java @@ -56,7 +56,7 @@ class StorelessBivariateCovariance { * Create an empty {@link StorelessBivariateCovariance} instance with * bias correction. */ - public StorelessBivariateCovariance() { + StorelessBivariateCovariance() { this(true); } @@ -67,7 +67,7 @@ class StorelessBivariateCovariance { * for bias, i.e. n-1 in the denominator, otherwise there is no bias correction, * i.e. n in the denominator. */ - public StorelessBivariateCovariance(final boolean biasCorrection) { + StorelessBivariateCovariance(final boolean biasCorrection) { meanX = meanY = 0.0; n = 0; covarianceNumerator = 0.0; diff --git a/src/main/java/org/apache/commons/math3/stat/descriptive/AggregateSummaryStatistics.java b/src/main/java/org/apache/commons/math3/stat/descriptive/AggregateSummaryStatistics.java index b1ccce53c..6ab3c3378 100644 --- a/src/main/java/org/apache/commons/math3/stat/descriptive/AggregateSummaryStatistics.java +++ b/src/main/java/org/apache/commons/math3/stat/descriptive/AggregateSummaryStatistics.java @@ -372,7 +372,7 @@ public class AggregateSummaryStatistics implements StatisticalSummary, * @param aggregateStatistics a {@code SummaryStatistics} into which * values added to this statistics object should be aggregated */ - public AggregatingSummaryStatistics(SummaryStatistics aggregateStatistics) { + AggregatingSummaryStatistics(SummaryStatistics aggregateStatistics) { this.aggregateStatistics = aggregateStatistics; } diff --git a/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FirstMoment.java b/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FirstMoment.java index 5f2b95af3..c153724c4 100644 --- a/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FirstMoment.java +++ b/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FirstMoment.java @@ -77,7 +77,7 @@ class FirstMoment extends AbstractStorelessUnivariateStatistic /** * Create a FirstMoment instance */ - public FirstMoment() { + FirstMoment() { n = 0; m1 = Double.NaN; dev = Double.NaN; @@ -91,7 +91,7 @@ class FirstMoment extends AbstractStorelessUnivariateStatistic * @param original the {@code FirstMoment} instance to copy * @throws NullArgumentException if original is null */ - public FirstMoment(FirstMoment original) throws NullArgumentException { + FirstMoment(FirstMoment original) throws NullArgumentException { super(); copy(original, this); } diff --git a/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FourthMoment.java b/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FourthMoment.java index cf9d8efca..0c199d899 100644 --- a/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FourthMoment.java +++ b/src/main/java/org/apache/commons/math3/stat/descriptive/moment/FourthMoment.java @@ -65,7 +65,7 @@ class FourthMoment extends ThirdMoment implements Serializable{ /** * Create a FourthMoment instance */ - public FourthMoment() { + FourthMoment() { super(); m4 = Double.NaN; } @@ -77,7 +77,7 @@ class FourthMoment extends ThirdMoment implements Serializable{ * @param original the {@code FourthMoment} instance to copy * @throws NullArgumentException if original is null */ - public FourthMoment(FourthMoment original) throws NullArgumentException { + FourthMoment(FourthMoment original) throws NullArgumentException { super(); copy(original, this); } diff --git a/src/main/java/org/apache/commons/math3/stat/descriptive/moment/ThirdMoment.java b/src/main/java/org/apache/commons/math3/stat/descriptive/moment/ThirdMoment.java index 2c5331dce..43a9ca1c2 100644 --- a/src/main/java/org/apache/commons/math3/stat/descriptive/moment/ThirdMoment.java +++ b/src/main/java/org/apache/commons/math3/stat/descriptive/moment/ThirdMoment.java @@ -66,7 +66,7 @@ class ThirdMoment extends SecondMoment implements Serializable { /** * Create a FourthMoment instance */ - public ThirdMoment() { + ThirdMoment() { super(); m3 = Double.NaN; nDevSq = Double.NaN; @@ -79,7 +79,7 @@ class ThirdMoment extends SecondMoment implements Serializable { * @param original the {@code ThirdMoment} instance to copy * @throws NullArgumentException if orginal is null */ - public ThirdMoment(ThirdMoment original) throws NullArgumentException { + ThirdMoment(ThirdMoment original) throws NullArgumentException { copy(original, this); } diff --git a/src/main/java/org/apache/commons/math3/stat/descriptive/rank/PSquarePercentile.java b/src/main/java/org/apache/commons/math3/stat/descriptive/rank/PSquarePercentile.java index 3c8219561..1a51d3b8c 100644 --- a/src/main/java/org/apache/commons/math3/stat/descriptive/rank/PSquarePercentile.java +++ b/src/main/java/org/apache/commons/math3/stat/descriptive/rank/PSquarePercentile.java @@ -899,7 +899,7 @@ public class PSquarePercentile extends AbstractStorelessUnivariateStatistic * * @param fixedCapacity the capacity to be fixed for this list */ - public FixedCapacityList(final int fixedCapacity) { + FixedCapacityList(final int fixedCapacity) { super(fixedCapacity); this.capacity = fixedCapacity; } diff --git a/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Percentile.java b/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Percentile.java index 69628f2fc..5f528c2ef 100644 --- a/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Percentile.java +++ b/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Percentile.java @@ -710,7 +710,7 @@ public class Percentile extends AbstractUnivariateStatistic implements Serializa * * */ - public static enum EstimationType { + public enum EstimationType { /** * This is the default type used in the {@link Percentile}.This method * has the following formulae for index and estimates
@@ -969,7 +969,7 @@ public class Percentile extends AbstractUnivariateStatistic implements Serializa * * @param type name of estimation type as per wikipedia */ - private EstimationType(final String type) { + EstimationType(final String type) { this.name = type; } diff --git a/src/main/java/org/apache/commons/math3/stat/ranking/NaturalRanking.java b/src/main/java/org/apache/commons/math3/stat/ranking/NaturalRanking.java index feaa5108c..6107c46be 100644 --- a/src/main/java/org/apache/commons/math3/stat/ranking/NaturalRanking.java +++ b/src/main/java/org/apache/commons/math3/stat/ranking/NaturalRanking.java @@ -437,7 +437,7 @@ public class NaturalRanking implements RankingAlgorithm { * @param value the value of the pair * @param position the original position */ - public IntDoublePair(double value, int position) { + IntDoublePair(double value, int position) { this.value = value; this.position = position; } diff --git a/src/main/java/org/apache/commons/math3/transform/FastFourierTransformer.java b/src/main/java/org/apache/commons/math3/transform/FastFourierTransformer.java index ca62c19a9..d40b9ac5b 100644 --- a/src/main/java/org/apache/commons/math3/transform/FastFourierTransformer.java +++ b/src/main/java/org/apache/commons/math3/transform/FastFourierTransformer.java @@ -516,8 +516,7 @@ public class FastFourierTransformer implements Serializable { * @param multiDimensionalComplexArray array containing the matrix * elements */ - public MultiDimensionalComplexMatrix( - Object multiDimensionalComplexArray) { + MultiDimensionalComplexMatrix(Object multiDimensionalComplexArray) { this.multiDimensionalComplexArray = multiDimensionalComplexArray; diff --git a/src/main/java/org/apache/commons/math3/util/Combinations.java b/src/main/java/org/apache/commons/math3/util/Combinations.java index f0a0fc388..c7c9c3b73 100644 --- a/src/main/java/org/apache/commons/math3/util/Combinations.java +++ b/src/main/java/org/apache/commons/math3/util/Combinations.java @@ -44,7 +44,7 @@ public class Combinations implements Iterable { * Describes the type of iteration performed by the * {@link #iterator() iterator}. */ - private static enum IterationOrder { + private enum IterationOrder { /** Lexicographic order. */ LEXICOGRAPHIC } @@ -203,7 +203,7 @@ public class Combinations implements Iterable { * @param n size of the set from which subsets are enumerated * @param k size of the subsets to enumerate */ - public LexicographicIterator(int n, int k) { + LexicographicIterator(int n, int k) { this.k = k; c = new int[k + 3]; if (k == 0 || k >= n) { @@ -297,7 +297,7 @@ public class Combinations implements Iterable { * Create a singleton iterator providing the given array. * @param singleton array returned by the iterator */ - public SingletonIterator(final int[] singleton) { + SingletonIterator(final int[] singleton) { this.singleton = singleton; } /** @return True until next is called the first time, then false */ @@ -336,8 +336,7 @@ public class Combinations implements Iterable { * @param n Size of the set from which subsets are selected. * @param k Size of the subsets to be enumerated. */ - public LexicographicComparator(int n, - int k) { + LexicographicComparator(int n, int k) { this.n = n; this.k = k; } diff --git a/src/main/java/org/apache/commons/math3/util/FastMath.java b/src/main/java/org/apache/commons/math3/util/FastMath.java index 27d8ee5b4..25419d168 100644 --- a/src/main/java/org/apache/commons/math3/util/FastMath.java +++ b/src/main/java/org/apache/commons/math3/util/FastMath.java @@ -1654,7 +1654,7 @@ public class FastMath { /** Simple constructor. * @param x number to split */ - public Split(final double x) { + Split(final double x) { full = x; high = Double.longBitsToDouble(Double.doubleToRawLongBits(x) & ((-1L) << 27)); low = x - high; @@ -1664,7 +1664,7 @@ public class FastMath { * @param high high order bits * @param low low order bits */ - public Split(final double high, final double low) { + Split(final double high, final double low) { this(high == 0.0 ? (low == 0.0 && Double.doubleToRawLongBits(high) == Long.MIN_VALUE /* negative zero */ ? -0.0 : low) : high + low, high, low); } @@ -1673,7 +1673,7 @@ public class FastMath { * @param high high order bits * @param low low order bits */ - public Split(final double full, final double high, final double low) { + Split(final double full, final double high, final double low) { this.full = full; this.high = high; this.low = low; diff --git a/src/main/java/org/apache/commons/math3/util/MathArrays.java b/src/main/java/org/apache/commons/math3/util/MathArrays.java index 45f9273c4..9bb01b4bb 100644 --- a/src/main/java/org/apache/commons/math3/util/MathArrays.java +++ b/src/main/java/org/apache/commons/math3/util/MathArrays.java @@ -312,7 +312,7 @@ public class MathArrays { /** * Specification of ordering direction. */ - public static enum OrderDirection { + public enum OrderDirection { /** Constant for increasing direction. */ INCREASING, /** Constant for decreasing direction. */ @@ -757,7 +757,7 @@ public class MathArrays { * @param key Key. * @param value Value. */ - public PairDoubleInteger(double key, int value) { + PairDoubleInteger(double key, int value) { this.key = key; this.value = value; } @@ -1555,7 +1555,7 @@ public class MathArrays { * Specification for indicating that some operation applies * before or after a given index. */ - public static enum Position { + public enum Position { /** Designates the beginning of the array (near index 0). */ HEAD, /** Designates the end of the array. */ diff --git a/src/main/java/org/apache/commons/math3/util/ResizableDoubleArray.java b/src/main/java/org/apache/commons/math3/util/ResizableDoubleArray.java index dae2b3b64..d49f6a82f 100644 --- a/src/main/java/org/apache/commons/math3/util/ResizableDoubleArray.java +++ b/src/main/java/org/apache/commons/math3/util/ResizableDoubleArray.java @@ -149,7 +149,7 @@ public class ResizableDoubleArray implements DoubleArray, Serializable { * Specification of expansion algorithm. * @since 3.1 */ - public static enum ExpansionMode { + public enum ExpansionMode { /** Multiplicative expansion mode. */ MULTIPLICATIVE, /** Additive expansion mode. */