Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MATH-925 

Added "final" keyword.
Removed degenerate case (matrix with no data).
Used constructor chaining.


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/math/trunk@1427276 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Gilles Sadowski 2013-01-01 01:41:09 +00:00
parent a9dfc11f1d
commit 216497d772
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/main/java/org/apache/commons/math3/linear/DiagonalMatrix.java
View File

@ -36,12 +36,7 @@ public class DiagonalMatrix extends AbstractRealMatrix
/** Serializable version identifier. */
private static final long serialVersionUID = 20121229L;
/** Entries of the diagonal. */
private double[] data;
/**
* Creates a matrix with no data.
*/
public DiagonalMatrix() {}
private final double[] data;
/**
* Creates a matrix with the supplied dimension.
@ -64,16 +59,17 @@ public class DiagonalMatrix extends AbstractRealMatrix
* @param d Data for the new matrix.
*/
public DiagonalMatrix(final double[] d) {
data = d.clone();
this(d, true);
}
/**
* Creates a matrix using the input array as the underlying data.
* <br/>
* If an array is built specially in order to be embedded in a
* RealMatrix and not used directly, the {@code copyArray} may be
* set to {@code false}. This will prevent the copying and improve
* performance as no new array will be built and no data will be copied.
* If an array is created specially in order to be embedded in a
* this instance and not used directly, the {@code copyArray} may be
* set to {@code false}.
* This will prevent the copying and improve performance as no new
* array will be built and no data will be copied.
*
* @param d Data for new matrix.
* @param copyArray if {@code true}, the input array will be copied,