Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MATH-1543: Avoid exception swallowing. 

Closes #149.
This commit is contained in:
XenoAmess 2020-06-07 18:28:03 +08:00 committed by Gilles Sadowski
parent d8ad317f94
commit 5b020dba27
1 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/main/java/org/apache/commons/math4/linear/ArrayFieldVector.java
View File

@ -1050,23 +1050,21 @@ public class ArrayFieldVector<T extends FieldElement<T>> implements FieldVector<
return false;
}
try {
@SuppressWarnings("unchecked") // May fail, but we ignore ClassCastException
FieldVector<T> rhs = (FieldVector<T>) other;
if (data.length != rhs.getDimension()) {
return false;
}
for (int i = 0; i < data.length; ++i) {
if (!data[i].equals(rhs.getEntry(i))) {
return false;
}
}
return true;
} catch (ClassCastException ex) {
// ignore exception
if (!(other instanceof FieldVector)) {
return false;
}
FieldVector rhs = (FieldVector) other;
if (data.length != rhs.getDimension()) {
return false;
}
for (int i = 0; i < data.length; ++i) {
if (!data[i].equals(rhs.getEntry(i))) {
return false;
}
}
return true;
}
/**