From 6e1e402ed69f00fbd236241368184082765b291e Mon Sep 17 00:00:00 2001
From: Alex Herbert <aherbert@apache.org>
Date: Thu, 19 Aug 2021 00:09:46 +0100
Subject: [PATCH] Remove plugin checks from default goal

These plugins already run using executions:

apache-rat:check (validate)
checkstyle:check (verify)

Added to verify using executions:

pmd:check
spotbugs:check
---
 pom.xml | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 4100484fe..da6ee151d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -274,7 +274,7 @@
 
   <build>
     <!--  TODO: Add binary compatibility check when released. -->
-    <defaultGoal>clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check javadoc:javadoc</defaultGoal>
+    <defaultGoal>clean verify javadoc:javadoc</defaultGoal>
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
@@ -354,6 +354,14 @@
           <effort>Default</effort>
           <excludeFilterFile>${math.parent.dir}/src/main/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile>
         </configuration>
+        <executions>
+          <execution>
+            <phase>verify</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
       </plugin>
       <plugin>
         <artifactId>maven-pmd-plugin</artifactId>
@@ -384,10 +392,19 @@
             <excludeRoot>target/generated-sources</excludeRoot>
           </excludeRoots>
         </configuration>
+        <executions>
+          <execution>
+            <phase>verify</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
       </plugin>
       <plugin>
         <groupId>org.apache.rat</groupId>
         <artifactId>apache-rat-plugin</artifactId>
+        <!-- Note: commons-parent binds the check goal to the validate phase -->
         <configuration>
         <!--
           Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check