Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use asserNotNull(var) instead of if (var != null) and avoid subsequent NPE warnings 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/math/trunk@1200365 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sebastian Bazley 2011-11-10 15:07:47 +00:00
parent f2c22d1d36
commit 7774fb6ffb
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/test/java/org/apache/commons/math/stat/regression/MillerUpdatingRegressionTest.java
View File

@ -16,6 +16,8 @@
*/
package org.apache.commons.math.stat.regression;
import junit.framework.Assert;
import org.apache.commons.math.linear.RealMatrix;
import org.apache.commons.math.stat.correlation.PearsonsCorrelation;
import org.apache.commons.math.TestUtils;
@ -178,9 +180,7 @@ public class MillerUpdatingRegressionTest {
instance.addObservations(x, y);
try {
RegressionResults result = instance.regress();
if (result == null) {
fail("The test case is a prototype.");
}
Assert.assertNotNull("The test case is a prototype.", result);
TestUtils.assertEquals(
new double[]{9.5169, 0.8827, 0.4540, -1.6275},
result.getParameterEstimates(), 1e-4);
@ -212,9 +212,7 @@ public class MillerUpdatingRegressionTest {
instance.addObservations(x, y);
try {
RegressionResults result = instance.regress();
if (result == null) {
fail("The test case is a prototype.");
}
Assert.assertNotNull("The test case is a prototype.", result);
TestUtils.assertEquals(
new double[]{9.5169, 0.8827, 0.4540, -1.6275},
result.getParameterEstimates(), 1e-4);
@ -783,15 +781,11 @@ public class MillerUpdatingRegressionTest {
instance.addObservations(x, y);
RegressionResults result = instance.regress();
if (result == null) {
fail("Could not estimate initial regression");
}
Assert.assertNotNull("Could not estimate initial regression", result);
instance2.addObservations(x2, y);
RegressionResults resultRedundant = instance2.regress();
if (resultRedundant == null) {
fail("Could not estimate redundant regression");
}
Assert.assertNotNull("Could not estimate redundant regression", resultRedundant);
double[] beta = result.getParameterEstimates();
double[] betar = resultRedundant.getParameterEstimates();
double[] se = result.getStdErrorOfEstimates();
@ -849,15 +843,11 @@ public class MillerUpdatingRegressionTest {
instance.addObservations(x, y);
RegressionResults result = instance.regress();
if (result == null) {
fail("Could not estimate initial regression");
}
Assert.assertNotNull("Could not estimate initial regression", result);
instance2.addObservations(x2, y);
RegressionResults resultRedundant = instance2.regress();
if (resultRedundant == null) {
fail("Could not estimate redundant regression");
}
Assert.assertNotNull("Could not estimate redundant regression", resultRedundant);
double[] beta = result.getParameterEstimates();
double[] betar = resultRedundant.getParameterEstimates();
double[] se = result.getStdErrorOfEstimates();