From 81841e834f2a10b7c292737f71c71a8aa43dd95e Mon Sep 17 00:00:00 2001
From: Luc Maisonobe <luc@apache.org>
Date: Fri, 29 Mar 2013 15:49:22 +0000
Subject: [PATCH] Fixe findbugs false positive.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/math/trunk@1462505 13f79535-47bb-0310-9956-ffa450edef68
---
 findbugs-exclude-filter.xml | 38 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
index 25a7e10f7..a6afaedb7 100644
--- a/findbugs-exclude-filter.xml
+++ b/findbugs-exclude-filter.xml
@@ -72,7 +72,15 @@
     <Method name="findEigenVectors" params="double[][]" returns="void" />
     <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
   </Match>
-
+  <Match>
+    <Or>
+      <Class name="org.apache.commons.math3.optim.nonlinear.scalar.noderiv.BOBYQAOptimizer" />
+      <Class name="org.apache.commons.math3.optimization.direct.BOBYQAOptimizer" />
+    </Or>
+    <Method name="altmov" params="int,double" returns="double[]" />
+    <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
+  </Match>
+  
   <!-- The following equality test is intentional and needed for semantic purposes -->
   <Match>
     <Or>
@@ -115,6 +123,34 @@
     <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
   </Match>
 
+  <!-- The following switch fall-through are due to conversion from FORTRAN goto,
+       which are handled by a state integer representing the target labels of the goto.
+       In the original code, this is sequential and fall-through is expected
+   -->
+  <Match>
+    <Or>
+      <Class name="org.apache.commons.math3.optim.nonlinear.scalar.noderiv.BOBYQAOptimizer" />
+      <Class name="org.apache.commons.math3.optimization.direct.BOBYQAOptimizer" />
+    </Or>
+    <Or>
+      <Method name="bobyqb" params="double[],double[]" returns="double" />
+      <Method name="trsbox" />
+      </Or>
+    <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+  </Match>
+  
+  <!-- Spurious: The fields are deprecated and not used anymore
+       (to be removed in 4.0)
+    -->
+  <Match>
+    <Class name="org.apache.commons.math3.optimization.general.AbstractLeastSquaresOptimizer" />
+    <Or>
+      <Field name="weightedResidualJacobian" />
+      <Field name="weightedResiduals" />
+      </Or>
+    <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
+  </Match>
+
   <!-- Spurious: Findbugs confused by final local variables -->
   <Match>
     <Class name="org.apache.commons.math3.util.FastMath" />