Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MATH-1309 

Constructors should not call overridable methods, even indirectly.
This commit is contained in:
Gilles 2015-12-31 01:31:24 +01:00
parent d1123894d3
commit 8f6bedeb72
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/apache/commons/math4/random/AbstractWell.java
View File

@ -134,7 +134,7 @@ public abstract class AbstractWell
*/
private void setSeedInternal(final int[] seed) {
if (seed == null) {
setSeed(System.currentTimeMillis() + System.identityHashCode(this));
setSeedInternal(System.currentTimeMillis() + System.identityHashCode(this));
return;
}

6
src/main/java/org/apache/commons/math4/random/ISAACRandom.java
View File

@ -131,7 +131,7 @@ public class ISAACRandom
* @param seed Seed.
*/
private void setSeedInternal(int seed) {
setSeed(new int[]{seed});
setSeedInternal(new int[] { seed });
}
/**
@ -140,7 +140,7 @@ public class ISAACRandom
* @param seed Seed.
*/
private void setSeedInternal(long seed) {
setSeed(new int[]{(int) (seed >>> 32), (int) (seed & 0xffffffffL)});
setSeedInternal(new int[] { (int) (seed >>> 32), (int) (seed & 0xffffffffL) });
}
/**
@ -150,7 +150,7 @@ public class ISAACRandom
*/
private void setSeedInternal(int[] seed) {
if (seed == null) {
setSeed(System.currentTimeMillis() + System.identityHashCode(this));
setSeedInternal(System.currentTimeMillis() + System.identityHashCode(this));
return;
}
final int seedLen = seed.length;