Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix a bug that sometimes Binomial test return probability greater than 1

This commit is contained in:
Kexin Xie 2017-05-07 09:47:14 -07:00 committed by Bruno P. Kinoshita
parent 53ec46ba27
commit 9df5e9419d
2 changed files with 53 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/apache/commons/math4/stat/inference/BinomialTest.java
View File

@ -135,7 +135,11 @@ public class BinomialTest {
double pHigh = distribution.probability(criticalValueHigh); double pHigh = distribution.probability(criticalValueHigh);
if (pLow == pHigh) { if (pLow == pHigh) {
pTotal += 2 * pLow; if (criticalValueLow == criticalValueHigh) {
pTotal += pLow;
} else {
pTotal += 2 * pLow;
}
criticalValueLow++; criticalValueLow++;
criticalValueHigh--; criticalValueHigh--;
} else if (pLow < pHigh) { } else if (pLow < pHigh) {

48
src/test/java/org/apache/commons/math4/stat/inference/BinomialTestTest.java
View File

@ -42,6 +42,54 @@ public class BinomialTestTest {
trials, successes, probability, AlternativeHypothesis.GREATER_THAN), 1E-4); trials, successes, probability, AlternativeHypothesis.GREATER_THAN), 1E-4);
Assert.assertEquals(0.982, testStatistic.binomialTest( Assert.assertEquals(0.982, testStatistic.binomialTest(
trials, successes, probability, AlternativeHypothesis.LESS_THAN), 1E-4); trials, successes, probability, AlternativeHypothesis.LESS_THAN), 1E-4);
// for special boundary conditions
Assert.assertEquals(1, testStatistic.binomialTest(
3, 3, 1, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(1, testStatistic.binomialTest(
3, 3, 0.9, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(1, testStatistic.binomialTest(
3, 3, 0.8, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.559, testStatistic.binomialTest(
3, 3, 0.7, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.28, testStatistic.binomialTest(
3, 3, 0.6, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.25, testStatistic.binomialTest(
3, 3, 0.5, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.064, testStatistic.binomialTest(
3, 3, 0.4, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.027, testStatistic.binomialTest(
3, 3, 0.3, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.008, testStatistic.binomialTest(
3, 3, 0.2, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.001, testStatistic.binomialTest(
3, 3, 0.1, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0, testStatistic.binomialTest(
3, 3, 0.0, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0, testStatistic.binomialTest(
3, 0, 1, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.001, testStatistic.binomialTest(
3, 0, 0.9, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.008, testStatistic.binomialTest(
3, 0, 0.8, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.027, testStatistic.binomialTest(
3, 0, 0.7, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.064, testStatistic.binomialTest(
3, 0, 0.6, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.25, testStatistic.binomialTest(
3, 0, 0.5, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.28, testStatistic.binomialTest(
3, 0, 0.4, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(0.559, testStatistic.binomialTest(
3, 0, 0.3, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(1, testStatistic.binomialTest(
3, 0, 0.2, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(1, testStatistic.binomialTest(
3, 0, 0.1, AlternativeHypothesis.TWO_SIDED), 1E-4);
Assert.assertEquals(1, testStatistic.binomialTest(
3, 0, 0.0, AlternativeHypothesis.TWO_SIDED), 1E-4);
} }
@Test @Test