Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify null checks.

This commit is contained in:
Gilles Sadowski 2021-08-14 16:18:36 +02:00
parent 8804071ac7
commit a0cd950a7c
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/SimplexOptimizer.java
View File

@ -21,6 +21,7 @@ import java.util.List;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.Collections;
import java.util.Objects;
import java.util.function.UnaryOperator;
import java.util.function.IntSupplier;
import java.util.concurrent.CopyOnWriteArrayList;
@ -159,9 +160,7 @@ public class SimplexOptimizer extends MultivariateOptimizer {
* @param cb Callback.
*/
public void addObserver(Observer cb) {
if (cb == null) {
throw new NullPointerException("Callback");
}
Objects.requireNonNull(cb, "Callback");
callbacks.add(cb);
}
@ -338,12 +337,9 @@ public class SimplexOptimizer extends MultivariateOptimizer {
* was passed to the {@link #optimize(OptimizationData[]) optimize} method.
*/
private void checkParameters() {
if (updateRule == null) {
throw new NullPointerException("No update rule");
}
if (initialSimplex == null) {
throw new NullPointerException("No initial simplex");
}
Objects.requireNonNull(updateRule, "Update rule");
Objects.requireNonNull(initialSimplex, "Initial simplex");
if (getLowerBound() != null ||
getUpperBound() != null) {
throw new MathUnsupportedOperationException(LocalizedFormats.CONSTRAINT);