Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MATH-1565: Add unit tests. 

Thanks to Randy Strauss.
This commit is contained in:
Gilles Sadowski 2020-12-11 19:35:02 +01:00
parent 323f6d7153
commit a2c3868fb8
2 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/changes/changes.xml
View File

@ -54,7 +54,7 @@ If the output is not quite correct, check for invisible trailing spaces!
</release> </release>
<release version="4.0" date="XXXX-XX-XX" description=""> <release version="4.0" date="XXXX-XX-XX" description="">
<action dev="erans" type="fix" issue="MATH-1565"> <action dev="erans" type="fix" issue="MATH-1565" due-to="Randy Strauss">
Add context to "OutOfRangeException". Add context to "OutOfRangeException".
</action> </action>
<action dev="erans" type="update" issue="MATH-1562" due-to="Frank Ulbricht"> <action dev="erans" type="update" issue="MATH-1562" due-to="Frank Ulbricht">

40
src/test/java/org/apache/commons/math4/linear/MatrixUtilsTest.java
View File

@ -22,6 +22,7 @@ import org.apache.commons.math4.TestUtils;
import org.apache.commons.math4.exception.MathIllegalArgumentException; import org.apache.commons.math4.exception.MathIllegalArgumentException;
import org.apache.commons.math4.exception.NotStrictlyPositiveException; import org.apache.commons.math4.exception.NotStrictlyPositiveException;
import org.apache.commons.math4.exception.NullArgumentException; import org.apache.commons.math4.exception.NullArgumentException;
import org.apache.commons.math4.exception.OutOfRangeException;
import org.apache.commons.math4.dfp.Dfp; import org.apache.commons.math4.dfp.Dfp;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Test; import org.junit.Test;
@ -445,4 +446,43 @@ public final class MatrixUtilsTest {
MatrixUtils.createRealIdentityMatrix(testData.length), result, 1e-12); MatrixUtils.createRealIdentityMatrix(testData.length), result, 1e-12);
} }
@Test
public void testCheckMatrixRowIndexError() {
try {
AnyMatrix m = MatrixUtils.createRealMatrix(new double[][] {{9,9}, {9,9}, {9,9}});
MatrixUtils.checkRowIndex(m, 4);
Assert.fail("expected an OutOfRangeException");
} catch (OutOfRangeException e) {
String s = e.getMessage();
int topIx = s.indexOf('2');
int botIx = s.indexOf('0');
int rowIx = s.indexOf('4');
if (topIx < 0 || botIx < 0 || rowIx < 0) {
Assert.fail("expected a message like index 4 is not in 0..3, not: " + s);
}
} catch (Exception e) {
Assert.fail("expected an OutOfRange exception, not: " +
e.getClass().getName() + ": " + e.getMessage());
}
}
@Test
public void testCheckMatrixColIndexError() {
try {
AnyMatrix m = MatrixUtils.createRealMatrix(new double[][] {{9,9}, {9,9}, {9,9}});
MatrixUtils.checkColumnIndex(m, 4);
Assert.fail("expected an OutOfRangeException");
} catch (OutOfRangeException e) {
String s = e.getMessage();
int topIx = s.indexOf('1');
int botIx = s.indexOf('0');
int rowIx = s.indexOf('4');
if (topIx < 0 || botIx < 0 || rowIx < 0) {
Assert.fail("expected a message like index 4 is not in 0..3, not: " + s);
}
} catch (Exception e) {
Assert.fail("expected an OutOfRange exception, not: " +
e.getClass().getName() + ": " + e.getMessage());
}
}
} }