From bb02fad3e3663062e563c29302375279fcd0cb45 Mon Sep 17 00:00:00 2001 From: Gilles Sadowski Date: Wed, 28 Oct 2020 03:21:33 +0100 Subject: [PATCH] Avoid redundant computations. --- src/main/java/org/apache/commons/math4/util/MathArrays.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/math4/util/MathArrays.java b/src/main/java/org/apache/commons/math4/util/MathArrays.java index a7488e239..864dbcf4f 100644 --- a/src/main/java/org/apache/commons/math4/util/MathArrays.java +++ b/src/main/java/org/apache/commons/math4/util/MathArrays.java @@ -912,11 +912,12 @@ public class MathArrays { if (sum == 0) { throw new MathArithmeticException(LocalizedFormats.ARRAY_SUMS_TO_ZERO); } + final double scale = normalizedSum / sum; for (int i = 0; i < len; i++) { if (Double.isNaN(values[i])) { out[i] = Double.NaN; } else { - out[i] = values[i] * normalizedSum / sum; + out[i] = values[i] * scale; } } return out;