Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Changed FractionFormat to extend NumberFormat. JIRA: MATH-189 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/math/trunk@737572 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Phil Steitz 2009-01-25 19:28:21 +00:00
parent e375464b76
commit bf9c5b292e
3 changed files with 44 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
src/java/org/apache/commons/math/fraction/FractionFormat.java
View File

@ -19,7 +19,6 @@ package org.apache.commons.math.fraction;
import java.io.Serializable;
import java.text.FieldPosition;
import java.text.Format;
import java.text.NumberFormat;
import java.text.ParseException;
import java.text.ParsePosition;
@ -36,7 +35,7 @@ import org.apache.commons.math.MathRuntimeException;
* @since 1.1
* @version $Revision$ $Date$
*/
public class FractionFormat extends Format implements Serializable {
public class FractionFormat extends NumberFormat implements Serializable {
/** Serializable version identifier */
private static final long serialVersionUID = -6337346779577272306L;
@ -183,7 +182,7 @@ public class FractionFormat extends Format implements Serializable {
}
/**
* Formats a object to produce a string. <code>obj</code> must be either a
* Formats an object and appends the result to a StringBuffer. <code>obj</code> must be either a
* {@link Fraction} object or a {@link Number} object. Any other type of
* object will result in an {@link IllegalArgumentException} being thrown.
*
@ -310,17 +309,6 @@ public class FractionFormat extends Format implements Serializable {
return new Fraction(num.intValue(), den.intValue());
}
/**
* Parses a string to produce a object.
* @param source the string to parse
* @param pos input/ouput parsing parameter.
* @return the parsed object.
* @see java.text.Format#parseObject(java.lang.String, java.text.ParsePosition)
*/
public Object parseObject(String source, ParsePosition pos) {
return parse(source, pos);
}
/**
* Modify the denominator format.
@ -388,4 +376,34 @@ public class FractionFormat extends Format implements Serializable {
return ret;
}
/**
* Formats a double value as a fraction and appends the result to a StringBuffer.
*
* @param value the double value to format
* @param buffer StringBuffer to append to
* @param position On input: an alignment field, if desired. On output: the
* offsets of the alignment field
* @return a reference to the appended buffer
* @see {@link #format(Object, StringBuffer, FieldPosition)}
*/
public StringBuffer format(double value, StringBuffer buffer,
FieldPosition position) {
return format(Double.valueOf(value), buffer, position);
}
/**
* Formats a long value as a fraction and appends the result to a StringBuffer.
*
* @param value the long value to format
* @param buffer StringBuffer to append to
* @param position On input: an alignment field, if desired. On output: the
* offsets of the alignment field
* @return a reference to the appended buffer
* @see {@link #format(Object, StringBuffer, FieldPosition)}
*/
public StringBuffer format(long value, StringBuffer buffer, FieldPosition position) {
return format(Long.valueOf(value), buffer, position);
}
}

5
src/site/xdoc/changes.xml
View File

@ -38,7 +38,10 @@ The <action> type attribute can be add,update,fix,remove.
<title>Commons Math Release Notes</title>
</properties>
<body>
<release version="2.0" date="TBD" description="TBD">
<release version="2.0" date="TBD" description="TBD">
<action dev="psteitz" type="update" issue="MATH-189">
Changed FractionFormat to extend NumberFormat.
</action>
<action dev="psteitz" type="update" issue="MATH-242" due-to="Christian Semrau">
Forced symmetry in binomialCoefficientLog and added test cases for MathUtils.
</action>

8
src/test/org/apache/commons/math/fraction/FractionFormatTest.java
View File

@ -289,4 +289,12 @@ public class FractionFormatTest extends TestCase {
assertEquals(nf, format.getWholeFormat());
format.setWholeFormat(old);
}
public void testLongFormat() {
assertEquals("10 / 1", improperFormat.format(10l));
}
public void testDoubleFormat() {
assertEquals("355 / 113", improperFormat.format(Math.PI));
}
}