Apache
/
commons-math
mirror of https://github.com/apache/commons-math.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix findbugs warning, use strict comparison for negative values. 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/math/trunk@1369597 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Thomas Neidhart 2012-08-05 14:11:27 +00:00
parent efb3e07afe
commit c2811e767d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/org/apache/commons/math3/linear/SchurTransformer.java
View File

@ -43,6 +43,9 @@ import org.apache.commons.math3.util.Precision;
* @since 3.1
*/
class SchurTransformer {
/** Maximum allowed iterations for convergence of the transformation. */
private static final int MAX_ITERATIONS = 100;
/** P matrix. */
private final double matrixP[][];
/** T matrix. */
@ -54,9 +57,6 @@ class SchurTransformer {
/** Cached value of PT. */
private RealMatrix cachedPt;
/** Maximum allowed iterations for convergence of the transformation. */
private final int maxIterations = 100;
/** Epsilon criteria taken from JAMA code (originally was 2^-52). */
private final double epsilon = Precision.EPSILON;
@ -205,9 +205,9 @@ class SchurTransformer {
computeShift(l, idx, iteration, shift);
// stop transformation after too many iterations
if (++iteration > maxIterations) {
if (++iteration > MAX_ITERATIONS) {
throw new MaxCountExceededException(LocalizedFormats.CONVERGENCE_FAILED,
maxIterations);
MAX_ITERATIONS);
}
// Look for two consecutive small sub-diagonal elements
@ -370,7 +370,7 @@ class SchurTransformer {
break;
}
double s = FastMath.sqrt(p * p + q * q + r * r);
if (Precision.compareTo(p, 0.0, epsilon) < 0) {
if (p < 0.0) {
s = -s;
}
if (!Precision.equals(s, 0.0, epsilon)) {