From d880dddc55707fcfa4a59b5a8ff3b0b49bd5c4ba Mon Sep 17 00:00:00 2001 From: Thomas Neidhart Date: Sun, 5 Aug 2012 09:32:46 +0000 Subject: [PATCH] Fixed findbugs finding when comparing Integer references. git-svn-id: https://svn.apache.org/repos/asf/commons/proper/math/trunk@1369540 13f79535-47bb-0310-9956-ffa450edef68 --- .../commons/math3/optimization/linear/SimplexSolver.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java b/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java index dec310beb..bb7960b19 100644 --- a/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java +++ b/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java @@ -142,8 +142,9 @@ public class SimplexSolver extends AbstractLinearOptimizer { int minIndex = tableau.getWidth(); for (Integer row : minRatioPositions) { int i = tableau.getNumObjectiveFunctions(); - for (; i < tableau.getWidth() - 1 && minRow != row; i++) { - if (row == tableau.getBasicRow(i)) { + for (; i < tableau.getWidth() - 1 && !row.equals(minRow); i++) { + Integer basicRow = tableau.getBasicRow(i); + if (basicRow != null && basicRow.equals(row)) { if (i < minIndex) { minIndex = i; minRow = row;