From fbd46106cb7ec393b58e318efd255f9a2b89b621 Mon Sep 17 00:00:00 2001
From: Luc Maisonobe <luc@apache.org>
Date: Mon, 20 Jul 2009 16:42:55 +0000
Subject: [PATCH] handle serialization of BigFractionField (which is a
 singleton) properly and test it

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/math/trunk@795908 13f79535-47bb-0310-9956-ffa450edef68
---
 .../math/fraction/BigFractionField.java       | 10 ++++-
 .../math/fraction/BigFractionFieldTest.java   | 44 +++++++++++++++++++
 2 files changed, 52 insertions(+), 2 deletions(-)
 create mode 100644 src/test/org/apache/commons/math/fraction/BigFractionFieldTest.java

diff --git a/src/java/org/apache/commons/math/fraction/BigFractionField.java b/src/java/org/apache/commons/math/fraction/BigFractionField.java
index d633662a3..7c0b0b618 100644
--- a/src/java/org/apache/commons/math/fraction/BigFractionField.java
+++ b/src/java/org/apache/commons/math/fraction/BigFractionField.java
@@ -31,8 +31,6 @@ import org.apache.commons.math.Field;
  * @since 2.0
  */
 public class BigFractionField implements Field<BigFraction>, Serializable  {
-    // TODO: Add Serializable documentation
-    // TODO: Check Serializable implementation
 
     /** Serializable version identifier */
     private static final long serialVersionUID = -1699294557189741703L;
@@ -67,4 +65,12 @@ public class BigFractionField implements Field<BigFraction>, Serializable  {
         private static final BigFractionField INSTANCE = new BigFractionField();
     }
 
+    /** Handle deserialization of the singleton.
+     * @return the singleton instance
+     */
+    private Object readResolve() {
+        // return the singleton instance
+        return LazyHolder.INSTANCE; 
+    }
+
 }
diff --git a/src/test/org/apache/commons/math/fraction/BigFractionFieldTest.java b/src/test/org/apache/commons/math/fraction/BigFractionFieldTest.java
new file mode 100644
index 000000000..02c10e869
--- /dev/null
+++ b/src/test/org/apache/commons/math/fraction/BigFractionFieldTest.java
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.math.fraction;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.math.TestUtils;
+import org.junit.Test;
+
+public class BigFractionFieldTest {
+
+    @Test
+    public void testZero() {
+        assertEquals(BigFraction.ZERO, BigFractionField.getInstance().getZero());
+    }
+
+    @Test
+    public void testOne() {
+        assertEquals(BigFraction.ONE, BigFractionField.getInstance().getOne());
+    }
+
+    @Test
+    public void testSerial() {
+        // deserializing the singleton should give the singleton itself back
+        BigFractionField field = BigFractionField.getInstance();
+        assertTrue(field == TestUtils.serializeAndRecover(field));
+    }
+
+}