Apache/druid
1
0
Fork 0
mirror of https://github.com/apache/druid.git synced 2025-02-26 13:16:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2663 from pjain1/warn_predicate_firehose

Browse Source 
do not silently ignore rows
This commit is contained in:
Nishant 2016-03-16 11:07:26 -07:00
commit 011efbfca7
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
server/src/main/java/io/druid/segment/realtime/firehose/PredicateFirehose.java
View File

@ -20,6 +20,7 @@
package io.druid.segment.realtime.firehose;
import com.google.common.base.Predicate;
import com.metamx.common.logger.Logger;
import io.druid.data.input.Firehose;
import io.druid.data.input.InputRow;
@ -31,6 +32,10 @@ import java.io.IOException;
*/
public class PredicateFirehose implements Firehose
{
private static final Logger log = new Logger(PredicateFirehose.class);
private static final int IGNORE_THRESHOLD = 5000;
private long ignored = 0;
private final Firehose firehose;
private final Predicate<InputRow> predicate;
@ -55,6 +60,11 @@ public class PredicateFirehose implements Firehose
savedInputRow = row;
return true;
}
// Do not silently discard the rows
if (ignored % IGNORE_THRESHOLD == 0) {
log.warn("[%,d] InputRow(s) ignored as they do not satisfy the predicate", ignored);
}
ignored++;
}
return false;