Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add comment and code tweak to Basic HTTP Authenticator (#6029)

This commit is contained in:
Jonathan Wei 2018-07-20 20:35:14 -07:00 committed by GitHub
parent efab3b0160
commit 0590293538
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
extensions-core/druid-basic-security/src/main/java/io/druid/security/basic/authentication/BasicHTTPAuthenticator.java
View File

@ -149,6 +149,7 @@ public class BasicHTTPAuthenticator implements Authenticator
}
@Override
public void doFilter(
ServletRequest servletRequest, ServletResponse servletResponse, FilterChain filterChain
@ -163,9 +164,12 @@ public class BasicHTTPAuthenticator implements Authenticator
return;
}
// At this point, encodedUserSecret is not null, indicating that the request intends to perform
// Basic HTTP authentication. If any errors occur with the authentication, we send a 401 response immediately
// and do not proceed further down the filter chain.
String decodedUserSecret = BasicAuthUtils.decodeUserSecret(encodedUserSecret);
if (decodedUserSecret == null) {
// we recognized a Basic auth header, but could not decode the user secret
// We recognized a Basic auth header, but could not decode the user secret.
httpResp.sendError(HttpServletResponse.SC_UNAUTHORIZED);
return;
}
@ -182,12 +186,10 @@ public class BasicHTTPAuthenticator implements Authenticator
if (checkCredentials(user, password)) {
AuthenticationResult authenticationResult = new AuthenticationResult(user, authorizerName, name, null);
servletRequest.setAttribute(AuthConfig.DRUID_AUTHENTICATION_RESULT, authenticationResult);
filterChain.doFilter(servletRequest, servletResponse);
} else {
httpResp.sendError(HttpServletResponse.SC_UNAUTHORIZED);
return;
}
filterChain.doFilter(servletRequest, servletResponse);
}
@Override