Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

better handling of exceptions during startup

This commit is contained in:
fjy 2013-08-12 12:56:59 -07:00
parent 2f728f3478
commit 0c360c05c2
1 changed files with 58 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
server/src/main/java/com/metamx/druid/coordination/ZkCoordinator.java
View File

@ -20,9 +20,12 @@
package com.metamx.druid.coordination;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.base.Function;
import com.google.common.base.Predicates;
import com.google.common.base.Throwables;
import com.google.common.collect.Lists;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
import com.metamx.common.guava.FunctionalIterable;
import com.metamx.common.lifecycle.LifecycleStart;
import com.metamx.common.lifecycle.LifecycleStop;
import com.metamx.druid.client.DataSegment;
@ -36,6 +39,7 @@ import org.apache.curator.framework.recipes.cache.PathChildrenCacheEvent;
import org.apache.curator.framework.recipes.cache.PathChildrenCacheListener;
import org.apache.curator.utils.ZKPaths;
import javax.annotation.Nullable;
import java.io.File;
import java.io.IOException;
import java.util.List;
@ -107,8 +111,14 @@ public class ZkCoordinator implements DataSegmentChangeHandler
curator.newNamespaceAwareEnsurePath(liveSegmentsLocation).ensure(curator.getZookeeperClient());
if (config.isLoadFromSegmentCacheEnabled()) {
try {
loadCache();
}
catch (Exception e) {
log.makeAlert(e, "Exception loading from cache")
.emit();
}
}
loadQueueCache.getListenable().addListener(
new PathChildrenCacheListener()
@ -254,7 +264,6 @@ public class ZkCoordinator implements DataSegmentChangeHandler
announcer.announceSegment(segment);
}
catch (IOException e) {
removeSegment(segment);
throw new SegmentLoadingException(e, "Failed to announce segment[%s]", segment.getIdentifier());
}
@ -269,15 +278,30 @@ public class ZkCoordinator implements DataSegmentChangeHandler
public void addSegments(Iterable<DataSegment> segments)
{
try {
for (DataSegment segment : segments) {
final List<String> segmentFailures = Lists.newArrayList();
Iterable<DataSegment> validSegments = FunctionalIterable
.create(segments)
.transform(
new Function<DataSegment, DataSegment>()
{
@Nullable
@Override
public DataSegment apply(@Nullable DataSegment segment)
{
if (segment == null) {
return null;
}
log.info("Loading segment %s", segment.getIdentifier());
try {
serverManager.loadSegment(segment);
}
catch (Exception e) {
log.error(e, "Exception loading segment[%s]", segment.getIdentifier());
removeSegment(segment);
throw new SegmentLoadingException(e, "Exception loading segment[%s]", segment.getIdentifier());
segmentFailures.add(segment.getIdentifier());
return null;
}
File segmentInfoCacheFile = new File(config.getSegmentInfoCacheDirectory(), segment.getIdentifier());
@ -286,21 +310,29 @@ public class ZkCoordinator implements DataSegmentChangeHandler
jsonMapper.writeValue(segmentInfoCacheFile, segment);
}
catch (IOException e) {
log.error(e, "Failed to write to disk segment info cache file[%s]", segmentInfoCacheFile);
removeSegment(segment);
throw new SegmentLoadingException(
e, "Failed to write to disk segment info cache file[%s]", segmentInfoCacheFile
);
}
segmentFailures.add(segment.getIdentifier());
return null;
}
}
return segment;
}
}
)
.filter(Predicates.<DataSegment>notNull());
try {
announcer.announceSegments(segments);
announcer.announceSegments(validSegments);
}
catch (IOException e) {
removeSegments(segments);
throw new SegmentLoadingException(e, "Failed to announce segments[%s]", segments);
}
if (!segmentFailures.isEmpty()) {
throw new SegmentLoadingException("Error loading segments: %s", segmentFailures);
}
}
catch (SegmentLoadingException e) {
log.makeAlert(e, "Failed to load segments for dataSource")