Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

address code review

This commit is contained in:
Xavier Léauté 2013-08-21 13:57:50 -07:00
parent 071e8cb2f3
commit 0f4a132807
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
realtime/src/main/java/com/metamx/druid/realtime/firehose/WikipediaIrcDecoder.java
View File

@ -21,6 +21,7 @@ package com.metamx.druid.realtime.firehose;
import com.fasterxml.jackson.annotation.JsonCreator; import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty; import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Lists; import com.google.common.collect.Lists;
import com.google.common.collect.Maps; import com.google.common.collect.Maps;
import com.maxmind.geoip2.DatabaseReader; import com.maxmind.geoip2.DatabaseReader;
@ -79,7 +80,9 @@ class WikipediaIrcDecoder implements IrcDecoder
public WikipediaIrcDecoder(@JsonProperty("namespaces") Map<String, Map<String, String>> namespaces, public WikipediaIrcDecoder(@JsonProperty("namespaces") Map<String, Map<String, String>> namespaces,
@JsonProperty("geoIpDatabase") String geoIpDatabase) @JsonProperty("geoIpDatabase") String geoIpDatabase)
{ {
if(namespaces == null) namespaces = Maps.newHashMap(); if(namespaces == null) {
namespaces = Maps.newHashMap();
}
this.namespaces = namespaces; this.namespaces = namespaces;
@ -195,7 +198,7 @@ class WikipediaIrcDecoder implements IrcDecoder
@Override @Override
public List<String> getDimension(String dimension) public List<String> getDimension(String dimension)
{ {
return Lists.newArrayList(dimensions.get(dimension)); return ImmutableList.of(dimensions.get(dimension));
} }
@Override @Override