Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix dropwizard emitter jvm bufferpoolName metric (#10075) 

* fix dropwizard emitter jvm bufferpoolName metric

* fixes
This commit is contained in:
Clint Wylie 2020-06-25 12:20:25 -07:00 committed by GitHub
parent 422a8af14e
commit 0f51b3c190
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 24 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
docs/design/extensions-contrib/dropwizard.md
View File

@ -465,19 +465,19 @@ Latest default metrics mapping can be found [here] (https://github.com/apache/dr
},
"jvm/bufferpool/counter": {
"dimensions": [
"bufferPoolName"
"bufferpoolName"
],
"type": "gauge"
},
"jvm/bufferpool/used": {
"dimensions": [
"bufferPoolName"
"bufferpoolName"
],
"type": "gauge"
},
"jvm/bufferpool/capacity": {
"dimensions": [
"bufferPoolName"
"bufferpoolName"
],
"type": "gauge"
},
@ -507,20 +507,23 @@ Latest default metrics mapping can be found [here] (https://github.com/apache/dr
},
"jvm/gc/counter": {
"dimensions": [
"gcName"
"gcName",
"gcGen"
],
"type": "counter"
},
"jvm/gc/cpu": {
"dimensions": [
"gcName"
"gcName",
"gcGen"
],
"type": "timer",
"timeUnit": "NANOSECONDS"
},
"ingest/events/buffered": {
"dimensions": [
"serviceName, bufferCapacity"
"serviceName",
"bufferCapacity"
],
"type": "gauge"
},

6
docs/operations/metrics.md
View File

@ -242,9 +242,9 @@ These metrics are only available if the JVMMonitor module is included.
|`jvm/pool/init`|Initial pool.|poolKind, poolName.|Varies.|
|`jvm/pool/max`|Max pool.|poolKind, poolName.|Varies.|
|`jvm/pool/used`|Pool used.|poolKind, poolName.|< max pool|
|`jvm/bufferpool/count`|Bufferpool count.|bufferPoolName.|Varies.|
|`jvm/bufferpool/used`|Bufferpool used.|bufferPoolName.|close to capacity|
|`jvm/bufferpool/capacity`|Bufferpool capacity.|bufferPoolName.|Varies.|
|`jvm/bufferpool/count`|Bufferpool count.|bufferpoolName.|Varies.|
|`jvm/bufferpool/used`|Bufferpool used.|bufferpoolName.|close to capacity|
|`jvm/bufferpool/capacity`|Bufferpool capacity.|bufferpoolName.|Varies.|
|`jvm/mem/init`|Initial memory.|memKind.|Varies.|
|`jvm/mem/max`|Max memory.|memKind.|Varies.|
|`jvm/mem/used`|Used memory.|memKind.|< max memory|

2
extensions-contrib/ambari-metrics-emitter/src/test/java/org/apache/druid/emitter/ambari/metrics/WhiteListBasedDruidToTimelineEventConverterTest.java
View File

@ -183,7 +183,7 @@ public class WhiteListBasedDruidToTimelineEventConverterTest
defaultNamespace + ".data-source.ingest/persists/count"
},
new Object[]{
new ServiceMetricEvent.Builder().setDimension("bufferPoolName", "BufferPool")
new ServiceMetricEvent.Builder().setDimension("bufferpoolName", "BufferPool")
.setDimension("type", "groupBy")
.setDimension("some_random_dim1", "random_dim_value1")
.build(createdTime, "jvm/bufferpool/capacity", 10)

15
extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json
View File

@ -370,19 +370,19 @@
},
"jvm/bufferpool/counter": {
"dimensions": [
"bufferPoolName"
"bufferpoolName"
],
"type": "gauge"
},
"jvm/bufferpool/used": {
"dimensions": [
"bufferPoolName"
"bufferpoolName"
],
"type": "gauge"
},
"jvm/bufferpool/capacity": {
"dimensions": [
"bufferPoolName"
"bufferpoolName"
],
"type": "gauge"
},
@ -412,20 +412,23 @@
},
"jvm/gc/counter": {
"dimensions": [
"gcName"
"gcName",
"gcGen"
],
"type": "counter"
},
"jvm/gc/cpu": {
"dimensions": [
"gcName"
"gcName",
"gcGen"
],
"type": "timer",
"timeUnit": "NANOSECONDS"
},
"ingest/events/buffered": {
"dimensions": [
"serviceName, bufferCapacity"
"serviceName",
"bufferCapacity"
],
"type": "gauge"
},

2
extensions-contrib/graphite-emitter/src/test/java/org/apache/druid/emitter/graphite/WhiteListBasedConverterTest.java
View File

@ -189,7 +189,7 @@ public class WhiteListBasedConverterTest
defaultNamespace + ".ingest/persists/count"
},
new Object[]{
new ServiceMetricEvent.Builder().setDimension("bufferPoolName", "BufferPool")
new ServiceMetricEvent.Builder().setDimension("bufferpoolName", "BufferPool")
.setDimension("type", "groupBy")
.setDimension("some_random_dim1", "random_dim_value1")
.build(createdTime, "jvm/bufferpool/capacity", 10)

2
website/.spelling
View File

@ -1161,7 +1161,7 @@ Sys
SysMonitor
TaskCountStatsMonitor
bufferCapacity
bufferPoolName
bufferpoolName
cms
cpuName
cpuTime