diff --git a/extensions/rabbitmq/src/main/java/io/druid/firehose/rabbitmq/RabbitMQFirehoseFactory.java b/extensions/rabbitmq/src/main/java/io/druid/firehose/rabbitmq/RabbitMQFirehoseFactory.java index 62f9ebb0146..89f20bc0c96 100644 --- a/extensions/rabbitmq/src/main/java/io/druid/firehose/rabbitmq/RabbitMQFirehoseFactory.java +++ b/extensions/rabbitmq/src/main/java/io/druid/firehose/rabbitmq/RabbitMQFirehoseFactory.java @@ -109,11 +109,13 @@ public class RabbitMQFirehoseFactory implements FirehoseFactory jobProperties, final @JsonProperty("combineText") boolean combineText, - final @JsonProperty("useCombiner") Boolean useCombiner + final @JsonProperty("useCombiner") Boolean useCombiner, + // See https://github.com/druid-io/druid/pull/1922 + final @JsonProperty("rowFlushBoundary") Integer maxRowsInMemoryCOMPAT ) { this.workingPath = workingPath; @@ -98,7 +101,7 @@ public class HadoopTuningConfig implements TuningConfig this.partitionsSpec = partitionsSpec == null ? DEFAULT_PARTITIONS_SPEC : partitionsSpec; this.shardSpecs = shardSpecs == null ? DEFAULT_SHARD_SPECS : shardSpecs; this.indexSpec = indexSpec == null ? DEFAULT_INDEX_SPEC : indexSpec; - this.rowFlushBoundary = maxRowsInMemory == null ? DEFAULT_ROW_FLUSH_BOUNDARY : maxRowsInMemory; + this.rowFlushBoundary = maxRowsInMemory == null ? maxRowsInMemoryCOMPAT == null ? DEFAULT_ROW_FLUSH_BOUNDARY : maxRowsInMemoryCOMPAT : maxRowsInMemory; this.leaveIntermediate = leaveIntermediate; this.cleanupOnFailure = cleanupOnFailure == null ? true : cleanupOnFailure; this.overwriteFiles = overwriteFiles; @@ -140,7 +143,7 @@ public class HadoopTuningConfig implements TuningConfig return indexSpec; } - @JsonProperty + @JsonProperty("maxRowsInMemory") public int getRowFlushBoundary() { return rowFlushBoundary; @@ -203,7 +206,8 @@ public class HadoopTuningConfig implements TuningConfig ignoreInvalidRows, jobProperties, combineText, - useCombiner + useCombiner, + null ); } @@ -222,7 +226,8 @@ public class HadoopTuningConfig implements TuningConfig ignoreInvalidRows, jobProperties, combineText, - useCombiner + useCombiner, + null ); } @@ -241,7 +246,8 @@ public class HadoopTuningConfig implements TuningConfig ignoreInvalidRows, jobProperties, combineText, - useCombiner + useCombiner, + null ); } } diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/BatchDeltaIngestionTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/BatchDeltaIngestionTest.java index aa41d8483ed..602e9968491 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/BatchDeltaIngestionTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/BatchDeltaIngestionTest.java @@ -380,7 +380,8 @@ public class BatchDeltaIngestionTest false, null, false, - false + false, + null ) ) ); diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/DetermineHashedPartitionsJobTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/DetermineHashedPartitionsJobTest.java index 0f3abc2e626..02b20a448b1 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/DetermineHashedPartitionsJobTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/DetermineHashedPartitionsJobTest.java @@ -159,7 +159,8 @@ public class DetermineHashedPartitionsJobTest false, null, false, - false + false, + null ) ); this.indexerConfig = new HadoopDruidIndexerConfig(ingestionSpec); diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/DeterminePartitionsJobTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/DeterminePartitionsJobTest.java index ab7a3c09691..203dc46ecb4 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/DeterminePartitionsJobTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/DeterminePartitionsJobTest.java @@ -263,7 +263,8 @@ public class DeterminePartitionsJobTest false, null, false, - false + false, + null ) ) ); diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/HadoopDruidIndexerConfigTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/HadoopDruidIndexerConfigTest.java index 13bf9e8ae98..ab9bac38862 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/HadoopDruidIndexerConfigTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/HadoopDruidIndexerConfigTest.java @@ -206,7 +206,8 @@ public class HadoopDruidIndexerConfigTest false, null, false, - false + false, + null ) ); HadoopDruidIndexerConfig config = HadoopDruidIndexerConfig.fromSpec(spec); diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/HadoopTuningConfigTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/HadoopTuningConfigTest.java index 2a00183a14d..10b8211f004 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/HadoopTuningConfigTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/HadoopTuningConfigTest.java @@ -52,7 +52,8 @@ public class HadoopTuningConfigTest true, null, true, - true + true, + null ); HadoopTuningConfig actual = jsonReadWriteRead(jsonMapper.writeValueAsString(expected), HadoopTuningConfig.class); diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/IndexGeneratorJobTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/IndexGeneratorJobTest.java index 5d67f23f3fa..339a1ccce57 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/IndexGeneratorJobTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/IndexGeneratorJobTest.java @@ -394,7 +394,8 @@ public class IndexGeneratorJobTest false, ImmutableMap.of(JobContext.NUM_REDUCES, "0"), //verifies that set num reducers is ignored false, - useCombiner + useCombiner, + null ) ) ); diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/JobHelperTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/JobHelperTest.java index 3d592871a5a..50bfcc00b83 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/JobHelperTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/JobHelperTest.java @@ -114,7 +114,8 @@ public class JobHelperTest "THISISMYACCESSKEY" ), false, - false + false, + null ) ) ); diff --git a/indexing-hadoop/src/test/java/io/druid/indexer/updater/HadoopConverterJobTest.java b/indexing-hadoop/src/test/java/io/druid/indexer/updater/HadoopConverterJobTest.java index 0a18725839f..770fe061422 100644 --- a/indexing-hadoop/src/test/java/io/druid/indexer/updater/HadoopConverterJobTest.java +++ b/indexing-hadoop/src/test/java/io/druid/indexer/updater/HadoopConverterJobTest.java @@ -200,7 +200,8 @@ public class HadoopConverterJobTest false, null, false, - false + false, + null ) ) ); diff --git a/indexing-service/src/main/java/io/druid/indexing/common/task/MoveTask.java b/indexing-service/src/main/java/io/druid/indexing/common/task/MoveTask.java index a6749750f97..08bfcdc7e8f 100644 --- a/indexing-service/src/main/java/io/druid/indexing/common/task/MoveTask.java +++ b/indexing-service/src/main/java/io/druid/indexing/common/task/MoveTask.java @@ -48,7 +48,9 @@ public class MoveTask extends AbstractFixedIntervalTask @JsonProperty("dataSource") String dataSource, @JsonProperty("interval") Interval interval, @JsonProperty("target") Map targetLoadSpec, - @JsonProperty("context") Map context + @JsonProperty("context") Map context, + // See https://github.com/druid-io/druid/pull/1922 + @JsonProperty("targetLoadSpec") Map targetLoadSpecCOMPAT ) { super( @@ -57,7 +59,7 @@ public class MoveTask extends AbstractFixedIntervalTask interval, context ); - this.targetLoadSpec = targetLoadSpec; + this.targetLoadSpec = targetLoadSpec == null ? targetLoadSpecCOMPAT : targetLoadSpec; } @Override @@ -108,7 +110,7 @@ public class MoveTask extends AbstractFixedIntervalTask return TaskStatus.success(getId()); } - @JsonProperty + @JsonProperty("target") public Map getTargetLoadSpec() { return targetLoadSpec; diff --git a/indexing-service/src/test/java/io/druid/indexing/common/task/TaskSerdeTest.java b/indexing-service/src/test/java/io/druid/indexing/common/task/TaskSerdeTest.java index 488c6204741..32e668f2382 100644 --- a/indexing-service/src/test/java/io/druid/indexing/common/task/TaskSerdeTest.java +++ b/indexing-service/src/test/java/io/druid/indexing/common/task/TaskSerdeTest.java @@ -545,6 +545,7 @@ public class TaskSerdeTest "foo", new Interval("2010-01-01/P1D"), ImmutableMap.of("bucket", "hey", "baseKey", "what"), + null, null ); diff --git a/processing/src/main/java/io/druid/jackson/DefaultObjectMapper.java b/processing/src/main/java/io/druid/jackson/DefaultObjectMapper.java index fe012ccf056..590432a3cef 100644 --- a/processing/src/main/java/io/druid/jackson/DefaultObjectMapper.java +++ b/processing/src/main/java/io/druid/jackson/DefaultObjectMapper.java @@ -55,6 +55,7 @@ public class DefaultObjectMapper extends ObjectMapper configure(MapperFeature.AUTO_DETECT_FIELDS, false); configure(MapperFeature.AUTO_DETECT_IS_GETTERS, false); configure(MapperFeature.AUTO_DETECT_SETTERS, false); + configure(MapperFeature.ALLOW_FINAL_FIELDS_AS_MUTATORS, false); configure(SerializationFeature.INDENT_OUTPUT, false); }