From 7ab810f3eb06d44d788f7934a804309d9eb6831b Mon Sep 17 00:00:00 2001 From: Himanshu Gupta Date: Wed, 6 Jan 2016 09:38:06 -0600 Subject: [PATCH] do not ignore exceptions from curator cleanup in CuratorTestBase --- .../java/io/druid/curator/CuratorTestBase.java | 14 ++++++++++---- .../druid/curator/announcement/AnnouncerTest.java | 2 -- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/server/src/test/java/io/druid/curator/CuratorTestBase.java b/server/src/test/java/io/druid/curator/CuratorTestBase.java index 165f0bde741..c0a4aa67888 100644 --- a/server/src/test/java/io/druid/curator/CuratorTestBase.java +++ b/server/src/test/java/io/druid/curator/CuratorTestBase.java @@ -20,9 +20,8 @@ package io.druid.curator; import com.fasterxml.jackson.databind.ObjectMapper; -import com.google.api.client.repackaged.com.google.common.base.Throwables; +import com.google.common.base.Throwables; import com.google.common.collect.ImmutableSet; -import com.metamx.common.guava.CloseQuietly; import io.druid.client.DruidServer; import io.druid.server.initialization.ZkPathsConfig; import io.druid.timeline.DataSegment; @@ -35,6 +34,8 @@ import org.apache.curator.utils.ZKPaths; import org.apache.zookeeper.CreateMode; import org.apache.zookeeper.KeeperException; +import java.io.IOException; + /** */ public class CuratorTestBase @@ -152,8 +153,13 @@ public class CuratorTestBase protected void tearDownServerAndCurator() { - CloseQuietly.close(curator); - CloseQuietly.close(server); + try { + curator.close(); + server.close(); + } catch(IOException ex) + { + throw Throwables.propagate(ex); + } } } diff --git a/server/src/test/java/io/druid/curator/announcement/AnnouncerTest.java b/server/src/test/java/io/druid/curator/announcement/AnnouncerTest.java index ed73b603dfe..6a6049f0dfc 100644 --- a/server/src/test/java/io/druid/curator/announcement/AnnouncerTest.java +++ b/server/src/test/java/io/druid/curator/announcement/AnnouncerTest.java @@ -32,7 +32,6 @@ import org.apache.zookeeper.data.Stat; import org.junit.After; import org.junit.Assert; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import java.util.Set; @@ -128,7 +127,6 @@ public class AnnouncerTest extends CuratorTestBase Assert.assertNull("expect /somewhere/test2 unannounced", curator.checkExists().forPath(testPath2)); } - @Ignore // https://github.com/druid-io/druid/issues/2167 @Test(timeout = 60_000L) public void testSessionKilled() throws Exception {